JSObjectReference API review follow-up #25476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/JSInterop/Microsoft.JSInterop/src/IJSInProcessObjectReference.cs
Outdated
Show resolved
Hide resolved
Member
|
This looks really good to me. Let us know when it's ready for final review! |
Pilchie
added
the
area-mvc
MackinnonBuck
added
area-blazor
pranavkm
approved these changes
Sep 1, 2020
src/JSInterop/Microsoft.JSInterop/src/JSObjectReferenceExtensions.cs
Outdated
Show resolved
Hide resolved
src/JSInterop/Microsoft.JSInterop/src/JSObjectReferenceExtensions.cs
Outdated
Show resolved
Hide resolved
src/JSInterop/Microsoft.JSInterop/src/JSObjectReferenceExtensions.cs
Outdated
Show resolved
Hide resolved
src/JSInterop/Microsoft.JSInterop/src/JSObjectReferenceExtensions.cs
Outdated
Show resolved
Hide resolved
src/JSInterop/Microsoft.JSInterop/src/JSObjectReferenceExtensions.cs
Outdated
Show resolved
Hide resolved
src/JSInterop/Microsoft.JSInterop/src/JSObjectReferenceExtensions.cs
Outdated
Show resolved
Hide resolved
mkArtakMSFT
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
Member
Author
|
An announcement for this change was posted here: aspnet/Announcements#435 |
Pilchie
added
Servicing-approved
Member
|
Approved for .NET 5 RC2 - thanks for the breaking change announcement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses feedback from the JSObjectReference API review (#25355).
Customer Impact
This is a necessary change to avoid future breaking changes to the public API.
Regression?
No.
Risk
Little risk - this is an area that is well-tested, and the updates in this PR don't make any large implementation changes.