Add more assembly version testing for SharedFx/Targeting pack #25474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
feature-platform
Member
Author
Contributor
Not a big surprise that dotnet/runtime bits have slightly different versioning. Much less worried about our sharedFx dependencies than what shows up in the targeting pack. So, sure, add an exception. And, if @ericstj @safern @Anipik @joperezr expect similar versioning for 5.0 or 6.0 implementation assemblies, make the exception broader -- perhaps even to all referenced |
dougbu
approved these changes
Aug 31, 2020
Contributor
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
Looks fine pending input from dotnet/runtime and getting the CI to pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24541
Adds tests to confirm that assemblies contained in the SharedFx/Targeting pack have versions ending in
0.0, and only reference things with versions ending in.0One of these tests currently fails - today, the
System.Security.Cryptography.Xmlthat we have in the SharedFx (which is versioned5.0.0.0) referencesSystem.Security.Cryptography.Pkcsat4.0.3.2, andSystem.Memoryat4.0.1.1. I believe those are both 3.1 versions. @ericstj @safern @Anipik @joperezr is that expected?