-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Add light/lit command packages #25334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds light command package generation to aspnetcore. After build of a wix project, generate a light package based off of the inputs that are sent to light.exe/lit.exe.
dougbu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a high level, why is this change needed❔ We already produce *.msi installers e.g. https://github.com/dotnet/aspnetcore/blob/release/5.0/src/Installers/Windows/Wix.props#L10-L15 and the MSIs in BlobArtifacts in (last release/5.0 build) https://dev.azure.com/dnceng/internal/_build/results?buildId=789717&view=artifacts&type=publishedArtifacts
This is so these installers can have files replaced and re-linked after having those files signed. You can decompile msis, exes, etc. to do this operation, but it is very hard because database needs to be altered heavily after the files are signed (e.g. the length of files change). This change effectively just captures the pre-link artifacts (files mentioned in the wixobj's) and creates a little file drop and command line script that can be used the create the MSI. Then it becomes trivial to sign the input files and run the script to produce a signed msi. |
|
We sign the input files in a separate step from one one that builds the |
Yep. This effectively creates a way to recreate the msis/exes/bundles/wixlib's out of the context of the build. |
dougbu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this will fail until #25373 goes in❔ Changes on top of that look fine though please remember to align the Microsoft.DotNet.Build.Tasks.Installers version and SHA when resolving conflicts with that PR (or whatever the final commit is if the current build fails).
Yep and will do. |
This adds light command package generation to aspnetcore.
After build of a wix project, generate a light package based off of the inputs that are sent to light.exe/lit.exe.