Skip to content

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Aug 19, 2020

Health checks wasn't in solution. This PR adds it along with other files (solution view, build.cmd, etc)

Also enabled nullable in tests as part of verifying #5680 for health checks.

@JamesNK JamesNK requested a review from pranavkm August 19, 2020 23:19
@JamesNK JamesNK changed the base branch from master to release/5.0 August 19, 2020 23:20
@JamesNK JamesNK added area-healthchecks Includes: Healthchecks (some bugs also in Extensions repo) tell-mode Indicates a PR which is being merged during tell-mode labels Aug 19, 2020
@JamesNK JamesNK added this to the 5.0.0-rc1 milestone Aug 19, 2020
@JamesNK JamesNK force-pushed the jamesnk/healthchecks-solution branch from db47a17 to b2979b3 Compare August 19, 2020 23:24
@ghost
Copy link

ghost commented Aug 20, 2020

Hello @pranavkm!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 818279f into release/5.0 Aug 20, 2020
@ghost ghost deleted the jamesnk/healthchecks-solution branch August 20, 2020 15:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-healthchecks Includes: Healthchecks (some bugs also in Extensions repo) tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants