Skip to content

Conversation

@pranavkm
Copy link
Contributor

See dotnet/sdk#12872 (comment)

There's an inflight PR which makes it difficult to test this end-to-end with this change without editing SDK files. But with those in-flight changes, the analyzer works and provides warnings.

Fixes #24891

@pranavkm pranavkm requested review from a team and SteveSandersonMS as code owners August 17, 2020 21:47
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Aug 17, 2020
@pranavkm pranavkm requested a review from terrajobst August 17, 2020 21:47
@pranavkm pranavkm added this to the 5.0.0-rc1 milestone Aug 17, 2020
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@pranavkm pranavkm merged commit c6814f4 into release/5.0 Aug 19, 2020
@pranavkm pranavkm deleted the prkrishn/supported-platform branch August 19, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-blazor Includes: Blazor, Razor Components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants