HTTP2: Optimize header processing #24945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JamesNK
commented
Aug 16, 2020
JamesNK
commented
- Even faster path for static index only request headers
- Skip :method validation if value is already known
- Compare scheme by reference
ghost
added
the
Member
Author
|
Validating - no longer needs to validate :method and scheme is compared by reference Before:
After:
|
Member
Author
|
Handling headers - Fast path avoids TryHPackAppend for method and scheme Before:
After:
|
Tratcher
approved these changes
Aug 17, 2020
src/Servers/Kestrel/Core/src/Internal/Http2/HPackHeaderWriter.cs
Outdated
Show resolved
Hide resolved
JamesNK
force-pushed
the
jamesnk/header-optimization
branch
from
d809854 to
8ef37c5
Compare
JamesNK
added
the
tell-mode
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.