Skip to content

Add gRPC testassets projects to solution #24177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2020
Merged

Add gRPC testassets projects to solution #24177

merged 1 commit into from
Jul 22, 2020

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Jul 21, 2020

Projects are present in Grpc.slnf, but not in AspNetCore.sln.

@JamesNK JamesNK requested review from JunTaoLuo and Pilchie July 21, 2020 22:09
@Pilchie Pilchie added the area-grpc Includes: GRPC wire-up, templates label Jul 22, 2020
@JamesNK JamesNK merged commit 95c3bd5 into master Jul 22, 2020
@JamesNK JamesNK deleted the jamesnk/grpc-testassets-solution branch July 22, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

+1 more reviewer

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-grpc Includes: GRPC wire-up, templates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JamesNK @JunTaoLuo @BrennanConroy @Pilchie