Add DisplayName to inputs #24029
Merged
Add DisplayName to inputs #24029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
pranavkm
reviewed
Jul 16, 2020
Co-authored-by: Pranav K <[email protected]>
Member
|
Nice one, thanks! I’ll leave it to others on the team to verify and sign off, but just wanted to say the approach looks good, and thanks for the work on the tests! |
pranavkm
approved these changes
Jul 16, 2020
Contributor
|
Thanks for the PR @zHaytam ! |
Contributor
Author
|
Big thanks to you guys for the help and the event! |
mkArtakMSFT
added
the
community-contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
DisplayNameparameter toInputBase, which is used in validation messages instead ofFieldIdentifier.FieldName.InputDate,InputNumberandInputSelect.Addresses #11414