Skip to content

Set executable bit on SetupNugetSources.sh #22521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2020
Merged

Set executable bit on SetupNugetSources.sh #22521

merged 1 commit into from
Jun 4, 2020

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jun 3, 2020

Should resolve #22245

I tested & confirmed in dotnet/arcade-services#2525 that maestro won't flip the bit back off in the next Arcade update

@wtgodbe wtgodbe requested a review from a team June 3, 2020 21:50
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 3, 2020
@wtgodbe
Copy link
Member Author

wtgodbe commented Jun 3, 2020

Internal build: https://dev.azure.com/dnceng/internal/_build/results?buildId=670601&view=results

@wtgodbe wtgodbe merged commit 7df0a97 into master Jun 4, 2020
@wtgodbe wtgodbe deleted the wtgodbe/FlipNugetSourcesBit branch June 4, 2020 16:28
@wtgodbe wtgodbe mentioned this pull request Jun 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix warning 'Executable bit is not set on target script, sourcing instead of executing.'

3 participants

@wtgodbe @dougbu