Skip to content

Quarantine flaky tests #22450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2020
Merged

Quarantine flaky tests #22450

merged 1 commit into from
Jun 2, 2020

Conversation

@BrennanConroy
Copy link
Member

@BrennanConroy BrennanConroy commented Jun 2, 2020 •
edited
Loading

ConnectionClosedTokenFiresOnClientFIN: #20163

Publish_WithBuildReferencesDisabled_CopiesStaticWebAssetsToDestinationFolder: #22451

halter73
halter73 approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just recently unquarantined the Kestrel test. Do you recall if any other tests failed in the same build as the Kestrel one?

@BrennanConroy
Copy link
Member Author

BrennanConroy commented Jun 2, 2020

Do you recall if any other tests failed in the same build as the Kestrel one?

https://dev.azure.com/dnceng/public/_build/results?buildId=667090&view=ms.vss-test-web.build-test-results-tab&runId=20678620&resultId=120233&paneView=debug

@Pilchie Pilchie added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates area-servers labels Jun 2, 2020
@BrennanConroy BrennanConroy merged commit b5e3786 into master Jun 2, 2020
@BrennanConroy BrennanConroy deleted the brecon/quar3 branch June 2, 2020 20:01
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halter73 halter73 halter73 approved these changes

@Pilchie Pilchie Pilchie approved these changes

@jkotalik jkotalik Awaiting requested review from jkotalik

@Tratcher Tratcher Awaiting requested review from Tratcher

+1 more reviewer

@pranavkm pranavkm pranavkm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BrennanConroy @halter73 @pranavkm @Pilchie @amcasey