Skip to content

Don't explicitly import Arcade SDK in AfterSigning.targets #22429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2020
Merged

Don't explicitly import Arcade SDK in AfterSigning.targets #22429

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35ea3e6
Don't explicitly import Arcade SDK in AfterSigning.targets
wtgodbe Jun 1, 2020
9b8db8c
Only import sdk.targets
wtgodbe Jun 1, 2020
23d0ad7
Set _SuppressSdkImports
wtgodbe Jun 2, 2020
e2c251d
Undo whitespace
wtgodbe Jun 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions eng/AfterSigning.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
<Project>

<Import Project="Sdk.props" Sdk="Microsoft.DotNet.Arcade.Sdk" Condition="'$(GenerateChecksums)' == 'true'" />

<PropertyGroup Condition="'$(GenerateChecksums)' == 'true'">
<!-- The one use of ArtifactsDir in Publish.proj adds an additional slash, confusing itself. -->
<ArtifactsDir Condition=" HasTrailingSlash('$(ArtifactsDir)') ">$(ArtifactsDir.Substring(0, $([MSBuild]::Subtract($(ArtifactsDir.Length), 1))))</ArtifactsDir>
<!-- $(InstallersOutputPath) is not defined. Root Directory.Build.props is not imported. -->
<InstallersOutputPath>$(ArtifactsDir)\installers\</InstallersOutputPath>
<_SuppressSdkImports>false</_SuppressSdkImports>
</PropertyGroup>

<Target Name="PopulateGenerateChecksumItems"
Expand Down