Skip to content

Quarantine InteropTest #22102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
May 21, 2020
Merged

Quarantine InteropTest #22102

1 commit merged into from
May 21, 2020

Conversation

@pranavkm
Copy link
Contributor

@pranavkm pranavkm commented May 21, 2020

No description provided.

@pranavkm pranavkm requested a review from JunTaoLuo May 21, 2020 21:43
@ghost
Copy link

ghost commented May 21, 2020

Hello @pranavkm!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@pranavkm pranavkm added this to the 5.0.0-preview5 milestone May 21, 2020
@ghost ghost merged commit 09da906 into master May 21, 2020
@ghost ghost deleted the prkrishn/quarantine-test branch May 21, 2020 23:33
dougbu
dougbu reviewed May 21, 2020
View reviewed changes
src/Grpc/test/InteropTests/InteropTests.cs
}

[Theory]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/22101")]
Copy link
Contributor

@dougbu dougbu May 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JunTaoLuo and @JamesNK can we please prioritize splitting up this [Theory] so that we can quarantine things more granularly? Is there an issue tracking that work?

Copy link
Member

@JamesNK JamesNK May 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New issue: #22117

@Pilchie
Copy link
Member

Pilchie commented May 22, 2020

Hmm - several other interop test failed in https://dev.azure.com/dnceng/public/_build/results?buildId=656709&view=results.

@dougbu
Copy link
Contributor

dougbu commented May 22, 2020

@JamesNK are the tests in InteropTests now running in a random order where before they were done in a predictable order that happened to work? Either way, I guess we have to quarantine many tests now. I'll do that.

@JamesNK
Copy link
Member

JamesNK commented May 22, 2020 •
edited
Loading

The tests are independent. Order doesn't matter.

There is either a transient environmental issue causing all these tests to suddenly start failing, or a lower level change in Kestrel/ASP.NET Core.

@JamesNK JamesNK mentioned this pull request May 22, 2020
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesNK JamesNK JamesNK left review comments

+2 more reviewers

@dougbu dougbu dougbu left review comments

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.0.0-preview5

Development

Successfully merging this pull request may close these issues.

6 participants

@pranavkm @Pilchie @dougbu @JamesNK @JunTaoLuo