From cf14b5584b67d896c3a8ccf6ded4c37d9e5484d3 Mon Sep 17 00:00:00 2001 From: Will Godbe Date: Thu, 23 Apr 2020 11:36:59 -0700 Subject: [PATCH 1/5] Move SDL validation to ringed release --- .azure/pipelines/ci.yml | 17 ----------------- eng/sdl-tsa-vars.config | 11 +++++++++++ 2 files changed, 11 insertions(+), 17 deletions(-) create mode 100644 eng/sdl-tsa-vars.config diff --git a/.azure/pipelines/ci.yml b/.azure/pipelines/ci.yml index 44de26de0f50..c6532669a71b 100644 --- a/.azure/pipelines/ci.yml +++ b/.azure/pipelines/ci.yml @@ -78,8 +78,6 @@ variables: /p:DotNetPublishUsingPipelines=$(_PublishUsingPipelines) /p:DotNetArtifactsCategory=$(_DotNetArtifactsCategory) - # used for post-build phases, internal builds only - - group: DotNet-AspNet-SDLValidation-Params - ${{ if in(variables['Build.Reason'], 'PullRequest') }}: - name: _BuildArgs value: '' @@ -781,18 +779,3 @@ stages: # See https://github.com/dotnet/arcade/issues/2871 enableSymbolValidation: false publishInstallersAndChecksums: true - # This is to enable SDL runs part of Post-Build Validation Stage - SDLValidationParameters: - enable: false - continueOnError: false - params: ' -SourceToolsList @("policheck","credscan") - -TsaInstanceURL $(_TsaInstanceURL) - -TsaProjectName $(_TsaProjectName) - -TsaNotificationEmail $(_TsaNotificationEmail) - -TsaCodebaseAdmin $(_TsaCodebaseAdmin) - -TsaBugAreaPath $(_TsaBugAreaPath) - -TsaIterationPath $(_TsaIterationPath) - -TsaRepositoryName "AspNetCore" - -TsaCodebaseName "AspNetCore" - -TsaPublish $True - -PoliCheckAdditionalRunConfigParams @("UserExclusionPath < $(Build.SourcesDirectory)/eng/PoliCheckExclusions.xml")' diff --git a/eng/sdl-tsa-vars.config b/eng/sdl-tsa-vars.config new file mode 100644 index 000000000000..ad9bb02d6504 --- /dev/null +++ b/eng/sdl-tsa-vars.config @@ -0,0 +1,11 @@ +-SourceToolsList @("policheck","credscan") +-TsaInstanceURL https://devdiv.visualstudio.com/ +-TsaProjectName DEVDIV +-TsaNotificationEmail aspnetcore-build@microsoft.com +-TsaCodebaseAdmin REDMOND\kevinpi +-TsaBugAreaPath DevDiv\ASP.NET Core +-TsaIterationPath DevDiv +-TsaRepositoryName aspnetcore +-TsaCodebaseName dotnet +-TsaOnboard $True +-TsaPublish $True From c7e63a00527bf7ded888cc023823c5ca32867320 Mon Sep 17 00:00:00 2001 From: Will Godbe Date: Thu, 23 Apr 2020 11:45:07 -0700 Subject: [PATCH 2/5] Remove unneeded stuff --- eng/sdl-tsa-vars.config | 2 -- 1 file changed, 2 deletions(-) diff --git a/eng/sdl-tsa-vars.config b/eng/sdl-tsa-vars.config index ad9bb02d6504..983f0d870a9f 100644 --- a/eng/sdl-tsa-vars.config +++ b/eng/sdl-tsa-vars.config @@ -5,7 +5,5 @@ -TsaCodebaseAdmin REDMOND\kevinpi -TsaBugAreaPath DevDiv\ASP.NET Core -TsaIterationPath DevDiv --TsaRepositoryName aspnetcore --TsaCodebaseName dotnet -TsaOnboard $True -TsaPublish $True From ff6cbd5b89e907f1988d69b559ef9ff635d76875 Mon Sep 17 00:00:00 2001 From: Will Godbe Date: Thu, 23 Apr 2020 13:30:09 -0700 Subject: [PATCH 3/5] Add back variables --- eng/sdl-tsa-vars.config | 2 ++ 1 file changed, 2 insertions(+) diff --git a/eng/sdl-tsa-vars.config b/eng/sdl-tsa-vars.config index 983f0d870a9f..d6116b54e3c5 100644 --- a/eng/sdl-tsa-vars.config +++ b/eng/sdl-tsa-vars.config @@ -5,5 +5,7 @@ -TsaCodebaseAdmin REDMOND\kevinpi -TsaBugAreaPath DevDiv\ASP.NET Core -TsaIterationPath DevDiv +-TsaRepositoryName AspNetCore +-TsaCodebaseName AspNetCore -TsaOnboard $True -TsaPublish $True From ad7640beed15ed1919542f726875b2659b7b00b8 Mon Sep 17 00:00:00 2001 From: Will Godbe Date: Thu, 23 Apr 2020 13:48:08 -0700 Subject: [PATCH 4/5] fixup --- eng/sdl-tsa-vars.config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/sdl-tsa-vars.config b/eng/sdl-tsa-vars.config index d6116b54e3c5..4c435ea06621 100644 --- a/eng/sdl-tsa-vars.config +++ b/eng/sdl-tsa-vars.config @@ -3,7 +3,7 @@ -TsaProjectName DEVDIV -TsaNotificationEmail aspnetcore-build@microsoft.com -TsaCodebaseAdmin REDMOND\kevinpi --TsaBugAreaPath DevDiv\ASP.NET Core +-TsaBugAreaPath "DevDiv\ASP.NET Core" -TsaIterationPath DevDiv -TsaRepositoryName AspNetCore -TsaCodebaseName AspNetCore From 6ec3f57e425d28ed50fd93ec0ddc31017f8d3c94 Mon Sep 17 00:00:00 2001 From: Will Godbe Date: Wed, 6 May 2020 12:23:43 -0700 Subject: [PATCH 5/5] Add missing param --- eng/sdl-tsa-vars.config | 1 + 1 file changed, 1 insertion(+) diff --git a/eng/sdl-tsa-vars.config b/eng/sdl-tsa-vars.config index 4c435ea06621..18d6a50c51bb 100644 --- a/eng/sdl-tsa-vars.config +++ b/eng/sdl-tsa-vars.config @@ -9,3 +9,4 @@ -TsaCodebaseName AspNetCore -TsaOnboard $True -TsaPublish $True +-PoliCheckAdditionalRunConfigParams @("UserExclusionPath < $(Build.SourcesDirectory)/eng/PoliCheckExclusions.xml")