[Templates] Diagnostics improvements and certificate fixes #21493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
javiercn
commented
May 5, 2020
javiercn
commented
- Move template specific helpers back to templates.
- Fix casing issue when loading the certificate.
- Capture startup output and throw when the app can't find the listening URL
ghost
added
the
area-mvc
dougbu
reviewed
May 5, 2020
Contributor
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
LGTM though I have a couple of questions about hidden output / details
| } | ||
|
|
||
| throw new InvalidOperationException(@$"Couldn't find listening url: | ||
| {string.Join(Environment.NewLine, buffer)}"); |
| return RequestWithRetries(client => client.GetAsync(new Uri(ListeningUri, path)), _httpClient); | ||
| } | ||
| internal Task<HttpResponseMessage> SendRequest(string path) => | ||
| RetryHelper.RetryRequest(() => _httpClient.GetAsync(new Uri(ListeningUri, path)), logger: NullLogger.Instance); |
Contributor
There was a problem hiding this comment.
Another question about hiding details here…
javiercn
force-pushed
the
javiercn/more-data
branch
from
2de1a55 to
a8a9593
Compare
Member
Author
|
Thanks @dougbu for baby sitting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.