From 6356a6b301f2b2b4281a02f3c01cf2c2fbbe1c78 Mon Sep 17 00:00:00 2001 From: Doug Bunting <6431421+dougbu@users.noreply.github.com> Date: Sun, 5 Jan 2020 21:36:02 -0800 Subject: [PATCH 1/3] Improve build reliability - ensure `ResolveCustomReferences` target executes before packages are used - `ResolveAssemblyReferences` and `ResolveAssemblyReferencesDesignTime` targets run too late - e.g. failed builds of Microsoft.AspNetCore.WebUtilities or Microsoft.AspNetCore.Hosting when building from root - add `GetReferenceProjectTargetPathMetadata` for ease of use as well as reliability - avoids extra work to get existing metadata (ref/ projects execute no tasks in this target) nit: rename `@(ReferenceProjectMetadata)` -> `@(ReferenceProjectTargetPathMetadata)` --- eng/targets/ResolveReferences.targets | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/eng/targets/ResolveReferences.targets b/eng/targets/ResolveReferences.targets index e77922ebcb71..3a59f8a691b3 100644 --- a/eng/targets/ResolveReferences.targets +++ b/eng/targets/ResolveReferences.targets @@ -144,7 +144,7 @@ This executes on NuGet restore and during DesignTimeBuild. It should not run in the outer, cross-targeting build. --> @@ -252,20 +252,35 @@ this assembly. Reset properties to avoid error when copying non-existent @(IntermediateRefAssembly) to $(TargetRefPath). --> - $(GetTargetPathWithTargetPlatformMonikerDependsOn);AddReferenceProjectMetadata + + $(GetTargetPathWithTargetPlatformMonikerDependsOn);AddReferenceProjectMetadata + RemoveReferenceProjectMetadata;$(PrepareForRunDependsOn) - + - ReferenceProjectMetadata false - + + + + + + + + + + @(IntermediateAssembly) + + + + true - @(ReferenceProjectMetadata) + @(ReferenceProjectTargetPathMetadata) From 12a5c49a607022e78ca5f46c3c2959f3c6ed9d5d Mon Sep 17 00:00:00 2001 From: Doug Bunting <6431421+dougbu@users.noreply.github.com> Date: Wed, 15 Apr 2020 22:43:12 -0700 Subject: [PATCH 2/3] Ensure `GetTargetPathMetadata` target runs with `$(TargetFramework)` set - ref/ projects all multi-target and otherwise no-op this target --- eng/targets/ResolveReferences.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/targets/ResolveReferences.targets b/eng/targets/ResolveReferences.targets index 3a59f8a691b3..bfa4bdb13240 100644 --- a/eng/targets/ResolveReferences.targets +++ b/eng/targets/ResolveReferences.targets @@ -266,7 +266,7 @@ - + From c739b293b2c2e123ed44c33c36fb096b01154fe5 Mon Sep 17 00:00:00 2001 From: Doug Bunting <6431421+dougbu@users.noreply.github.com> Date: Wed, 15 Apr 2020 22:52:12 -0700 Subject: [PATCH 3/3] Revert "Fix various "Type or namespace not found" errors (#20736)" - change is no longer needed with other fixes in this PR This reverts commit 8218d6e0e72dd9cb495baedb9644695d8747b8de. --- eng/scripts/CodeCheck.ps1 | 5 +++++ .../Microsoft.AspNetCore.Antiforgery.csproj | 5 +---- ...rosoft.AspNetCore.Components.Server.csproj | 12 +++++----- ...oft.AspNetCore.Hosting.Abstractions.csproj | 4 +--- .../src/Microsoft.AspNetCore.Hosting.csproj | 22 +++++++++---------- ...NetCore.Hosting.Server.Abstractions.csproj | 4 +--- ...NetCore.Authentication.Abstractions.csproj | 6 ++--- .../src/Microsoft.Net.Http.Headers.csproj | 3 +-- ...rosoft.AspNetCore.Http.Abstractions.csproj | 4 +--- ...icrosoft.AspNetCore.Http.Extensions.csproj | 4 +--- .../Http/src/Microsoft.AspNetCore.Http.csproj | 6 ++--- .../src/Microsoft.AspNetCore.Routing.csproj | 10 ++++----- .../Microsoft.AspNetCore.WebUtilities.csproj | 4 +--- .../CORS/src/Microsoft.AspNetCore.Cors.csproj | 10 ++++----- .../Microsoft.AspNetCore.Diagnostics.csproj | 10 ++++----- ...AspNetCore.Diagnostics.HealthChecks.csproj | 6 ++--- .../Microsoft.AspNetCore.HostFiltering.csproj | 4 +--- .../Microsoft.AspNetCore.HttpOverrides.csproj | 6 ++--- .../Microsoft.AspNetCore.HttpsPolicy.csproj | 6 ++--- .../Microsoft.AspNetCore.Localization.csproj | 8 +++---- ...etCore.ResponseCaching.Abstractions.csproj | 3 +-- ...icrosoft.AspNetCore.ResponseCaching.csproj | 6 ++--- ...soft.AspNetCore.ResponseCompression.csproj | 6 ++--- .../src/Microsoft.AspNetCore.Rewrite.csproj | 10 ++++----- .../src/Microsoft.AspNetCore.Session.csproj | 8 +++---- .../Microsoft.AspNetCore.StaticFiles.csproj | 8 +++---- .../Microsoft.AspNetCore.WebSockets.csproj | 6 ++--- ...crosoft.AspNetCore.Mvc.Abstractions.csproj | 3 +-- .../src/Microsoft.AspNetCore.Mvc.Core.csproj | 14 +++++------- ...soft.AspNetCore.Mvc.DataAnnotations.csproj | 4 +--- ...crosoft.AspNetCore.Mvc.Localization.csproj | 7 +++--- .../src/Microsoft.AspNetCore.Mvc.Razor.csproj | 6 ++--- ...Microsoft.AspNetCore.Mvc.TagHelpers.csproj | 8 +++---- ...crosoft.AspNetCore.Mvc.ViewFeatures.csproj | 4 +--- .../Mvc/src/Microsoft.AspNetCore.Mvc.csproj | 6 ++--- .../src/Microsoft.AspNetCore.Razor.csproj | 4 +--- ...Microsoft.AspNetCore.Authentication.csproj | 8 +++---- .../Microsoft.AspNetCore.CookiePolicy.csproj | 6 ++--- ...Microsoft.AspNetCore.Server.HttpSys.csproj | 6 ++--- .../Microsoft.AspNetCore.Server.IIS.csproj | 10 ++++----- ...ft.AspNetCore.Server.IISIntegration.csproj | 10 ++++----- ...soft.AspNetCore.Server.Kestrel.Core.csproj | 10 ++++----- ...re.Server.Kestrel.Transport.Sockets.csproj | 4 +--- ...crosoft.AspNetCore.Http.Connections.csproj | 6 ++--- .../Microsoft.AspNetCore.SignalR.Core.csproj | 6 ++--- 45 files changed, 114 insertions(+), 194 deletions(-) diff --git a/eng/scripts/CodeCheck.ps1 b/eng/scripts/CodeCheck.ps1 index 012819ff1bc8..072f55fe2196 100644 --- a/eng/scripts/CodeCheck.ps1 +++ b/eng/scripts/CodeCheck.ps1 @@ -165,6 +165,11 @@ try { & $PSScriptRoot\GenerateProjectList.ps1 -ci:$ci } + Write-Host "Re-generating references assemblies" + Invoke-Block { + & $PSScriptRoot\GenerateReferenceAssemblies.ps1 -ci:$ci + } + Write-Host "Re-generating package baselines" Invoke-Block { & dotnet run -p "$repoRoot/eng/tools/BaselineGenerator/" diff --git a/src/Antiforgery/src/Microsoft.AspNetCore.Antiforgery.csproj b/src/Antiforgery/src/Microsoft.AspNetCore.Antiforgery.csproj index 6dee6dec2d65..566e221871c3 100644 --- a/src/Antiforgery/src/Microsoft.AspNetCore.Antiforgery.csproj +++ b/src/Antiforgery/src/Microsoft.AspNetCore.Antiforgery.csproj @@ -7,7 +7,6 @@ true aspnetcore;antiforgery false - true @@ -15,9 +14,7 @@ - - - + diff --git a/src/Components/Server/src/Microsoft.AspNetCore.Components.Server.csproj b/src/Components/Server/src/Microsoft.AspNetCore.Components.Server.csproj index 036fe23821c0..b47c1c2fe36a 100644 --- a/src/Components/Server/src/Microsoft.AspNetCore.Components.Server.csproj +++ b/src/Components/Server/src/Microsoft.AspNetCore.Components.Server.csproj @@ -10,7 +10,6 @@ CS0436;$(NoWarn) $(DefineConstants);MESSAGEPACK_INTERNAL;COMPONENTS_SERVER false - true @@ -19,12 +18,11 @@ - - - - - - + + + + + diff --git a/src/Hosting/Abstractions/src/Microsoft.AspNetCore.Hosting.Abstractions.csproj b/src/Hosting/Abstractions/src/Microsoft.AspNetCore.Hosting.Abstractions.csproj index e629f75f152b..4def523880c5 100644 --- a/src/Hosting/Abstractions/src/Microsoft.AspNetCore.Hosting.Abstractions.csproj +++ b/src/Hosting/Abstractions/src/Microsoft.AspNetCore.Hosting.Abstractions.csproj @@ -8,14 +8,12 @@ true aspnetcore;hosting false - true - - + diff --git a/src/Hosting/Hosting/src/Microsoft.AspNetCore.Hosting.csproj b/src/Hosting/Hosting/src/Microsoft.AspNetCore.Hosting.csproj index 222c7798ba17..38ec417cb468 100644 --- a/src/Hosting/Hosting/src/Microsoft.AspNetCore.Hosting.csproj +++ b/src/Hosting/Hosting/src/Microsoft.AspNetCore.Hosting.csproj @@ -8,7 +8,6 @@ true aspnetcore;hosting false - true @@ -21,17 +20,16 @@ - - - - - - - - - - - + + + + + + + + + + diff --git a/src/Hosting/Server.Abstractions/src/Microsoft.AspNetCore.Hosting.Server.Abstractions.csproj b/src/Hosting/Server.Abstractions/src/Microsoft.AspNetCore.Hosting.Server.Abstractions.csproj index 2d24ec4ba4a9..4e6c350a519c 100644 --- a/src/Hosting/Server.Abstractions/src/Microsoft.AspNetCore.Hosting.Server.Abstractions.csproj +++ b/src/Hosting/Server.Abstractions/src/Microsoft.AspNetCore.Hosting.Server.Abstractions.csproj @@ -8,13 +8,11 @@ true aspnetcore;hosting false - true - - + diff --git a/src/Http/Authentication.Abstractions/src/Microsoft.AspNetCore.Authentication.Abstractions.csproj b/src/Http/Authentication.Abstractions/src/Microsoft.AspNetCore.Authentication.Abstractions.csproj index 4210f732367a..999e6741e57f 100644 --- a/src/Http/Authentication.Abstractions/src/Microsoft.AspNetCore.Authentication.Abstractions.csproj +++ b/src/Http/Authentication.Abstractions/src/Microsoft.AspNetCore.Authentication.Abstractions.csproj @@ -7,14 +7,12 @@ true aspnetcore;authentication;security false - true - - - + + diff --git a/src/Http/Headers/src/Microsoft.Net.Http.Headers.csproj b/src/Http/Headers/src/Microsoft.Net.Http.Headers.csproj index 73e9b97b72a5..d0c27e7ed75d 100644 --- a/src/Http/Headers/src/Microsoft.Net.Http.Headers.csproj +++ b/src/Http/Headers/src/Microsoft.Net.Http.Headers.csproj @@ -9,11 +9,10 @@ true http false - true - + diff --git a/src/Http/Http.Abstractions/src/Microsoft.AspNetCore.Http.Abstractions.csproj b/src/Http/Http.Abstractions/src/Microsoft.AspNetCore.Http.Abstractions.csproj index 26abf996c25f..adea0a305988 100644 --- a/src/Http/Http.Abstractions/src/Microsoft.AspNetCore.Http.Abstractions.csproj +++ b/src/Http/Http.Abstractions/src/Microsoft.AspNetCore.Http.Abstractions.csproj @@ -14,7 +14,6 @@ Microsoft.AspNetCore.Http.HttpResponse aspnetcore $(NoWarn);CS1591 false - true @@ -23,9 +22,8 @@ Microsoft.AspNetCore.Http.HttpResponse + - - diff --git a/src/Http/Http.Extensions/src/Microsoft.AspNetCore.Http.Extensions.csproj b/src/Http/Http.Extensions/src/Microsoft.AspNetCore.Http.Extensions.csproj index f6e2da192051..73ba2b8a9ce4 100644 --- a/src/Http/Http.Extensions/src/Microsoft.AspNetCore.Http.Extensions.csproj +++ b/src/Http/Http.Extensions/src/Microsoft.AspNetCore.Http.Extensions.csproj @@ -8,7 +8,6 @@ true aspnetcore false - true @@ -18,8 +17,7 @@ - - + diff --git a/src/Http/Http/src/Microsoft.AspNetCore.Http.csproj b/src/Http/Http/src/Microsoft.AspNetCore.Http.csproj index ef3925b0d649..a7fb56774bd1 100644 --- a/src/Http/Http/src/Microsoft.AspNetCore.Http.csproj +++ b/src/Http/Http/src/Microsoft.AspNetCore.Http.csproj @@ -9,7 +9,6 @@ true aspnetcore false - true @@ -22,10 +21,9 @@ + + - - - diff --git a/src/Http/Routing/src/Microsoft.AspNetCore.Routing.csproj b/src/Http/Routing/src/Microsoft.AspNetCore.Routing.csproj index ae3996e3c716..95a5f0327daf 100644 --- a/src/Http/Routing/src/Microsoft.AspNetCore.Routing.csproj +++ b/src/Http/Routing/src/Microsoft.AspNetCore.Routing.csproj @@ -12,7 +12,6 @@ Microsoft.AspNetCore.Routing.RouteCollection aspnetcore;routing true false - true @@ -31,11 +30,10 @@ Microsoft.AspNetCore.Routing.RouteCollection - - - - - + + + + diff --git a/src/Http/WebUtilities/src/Microsoft.AspNetCore.WebUtilities.csproj b/src/Http/WebUtilities/src/Microsoft.AspNetCore.WebUtilities.csproj index a64eb3bef82c..63d3582d520b 100644 --- a/src/Http/WebUtilities/src/Microsoft.AspNetCore.WebUtilities.csproj +++ b/src/Http/WebUtilities/src/Microsoft.AspNetCore.WebUtilities.csproj @@ -9,7 +9,6 @@ true aspnetcore false - true @@ -19,8 +18,7 @@ - - + diff --git a/src/Middleware/CORS/src/Microsoft.AspNetCore.Cors.csproj b/src/Middleware/CORS/src/Microsoft.AspNetCore.Cors.csproj index 31823a5384c2..656043ab16be 100644 --- a/src/Middleware/CORS/src/Microsoft.AspNetCore.Cors.csproj +++ b/src/Middleware/CORS/src/Microsoft.AspNetCore.Cors.csproj @@ -11,17 +11,15 @@ Microsoft.AspNetCore.Cors.EnableCorsAttribute true aspnetcore;cors false - true - - - - - + + + + diff --git a/src/Middleware/Diagnostics/src/Microsoft.AspNetCore.Diagnostics.csproj b/src/Middleware/Diagnostics/src/Microsoft.AspNetCore.Diagnostics.csproj index fc4724f6e013..a8ac2a09018d 100644 --- a/src/Middleware/Diagnostics/src/Microsoft.AspNetCore.Diagnostics.csproj +++ b/src/Middleware/Diagnostics/src/Microsoft.AspNetCore.Diagnostics.csproj @@ -8,7 +8,6 @@ true aspnetcore;diagnostics false - true @@ -23,11 +22,10 @@ - - - - - + + + + diff --git a/src/Middleware/HealthChecks/src/Microsoft.AspNetCore.Diagnostics.HealthChecks.csproj b/src/Middleware/HealthChecks/src/Microsoft.AspNetCore.Diagnostics.HealthChecks.csproj index c4e859ed19b4..99c01627f6c1 100644 --- a/src/Middleware/HealthChecks/src/Microsoft.AspNetCore.Diagnostics.HealthChecks.csproj +++ b/src/Middleware/HealthChecks/src/Microsoft.AspNetCore.Diagnostics.HealthChecks.csproj @@ -8,16 +8,14 @@ true diagnostics;healthchecks false - true + + - - - diff --git a/src/Middleware/HostFiltering/src/Microsoft.AspNetCore.HostFiltering.csproj b/src/Middleware/HostFiltering/src/Microsoft.AspNetCore.HostFiltering.csproj index 2ec1e17645ee..b1098f3cea32 100644 --- a/src/Middleware/HostFiltering/src/Microsoft.AspNetCore.HostFiltering.csproj +++ b/src/Middleware/HostFiltering/src/Microsoft.AspNetCore.HostFiltering.csproj @@ -9,14 +9,12 @@ true aspnetcore false - true + - - diff --git a/src/Middleware/HttpOverrides/src/Microsoft.AspNetCore.HttpOverrides.csproj b/src/Middleware/HttpOverrides/src/Microsoft.AspNetCore.HttpOverrides.csproj index 511ec8428f06..aa225718c4cc 100644 --- a/src/Middleware/HttpOverrides/src/Microsoft.AspNetCore.HttpOverrides.csproj +++ b/src/Middleware/HttpOverrides/src/Microsoft.AspNetCore.HttpOverrides.csproj @@ -10,14 +10,12 @@ true aspnetcore;proxy;headers;xforwarded false - true - - - + + diff --git a/src/Middleware/HttpsPolicy/src/Microsoft.AspNetCore.HttpsPolicy.csproj b/src/Middleware/HttpsPolicy/src/Microsoft.AspNetCore.HttpsPolicy.csproj index 9e807899b0ae..c6c14dd30dad 100644 --- a/src/Middleware/HttpsPolicy/src/Microsoft.AspNetCore.HttpsPolicy.csproj +++ b/src/Middleware/HttpsPolicy/src/Microsoft.AspNetCore.HttpsPolicy.csproj @@ -10,15 +10,13 @@ true aspnetcore;https;hsts false - true + + - - - diff --git a/src/Middleware/Localization/src/Microsoft.AspNetCore.Localization.csproj b/src/Middleware/Localization/src/Microsoft.AspNetCore.Localization.csproj index 49750865c425..20a32d0507b8 100644 --- a/src/Middleware/Localization/src/Microsoft.AspNetCore.Localization.csproj +++ b/src/Middleware/Localization/src/Microsoft.AspNetCore.Localization.csproj @@ -9,15 +9,13 @@ true aspnetcore;localization false - true - - - - + + + diff --git a/src/Middleware/ResponseCaching.Abstractions/src/Microsoft.AspNetCore.ResponseCaching.Abstractions.csproj b/src/Middleware/ResponseCaching.Abstractions/src/Microsoft.AspNetCore.ResponseCaching.Abstractions.csproj index 171db6b36942..226e595816e1 100644 --- a/src/Middleware/ResponseCaching.Abstractions/src/Microsoft.AspNetCore.ResponseCaching.Abstractions.csproj +++ b/src/Middleware/ResponseCaching.Abstractions/src/Microsoft.AspNetCore.ResponseCaching.Abstractions.csproj @@ -7,11 +7,10 @@ true aspnetcore;cache;caching false - true - + diff --git a/src/Middleware/ResponseCaching/src/Microsoft.AspNetCore.ResponseCaching.csproj b/src/Middleware/ResponseCaching/src/Microsoft.AspNetCore.ResponseCaching.csproj index d7ed2100a92c..2846ee5907c0 100644 --- a/src/Middleware/ResponseCaching/src/Microsoft.AspNetCore.ResponseCaching.csproj +++ b/src/Middleware/ResponseCaching/src/Microsoft.AspNetCore.ResponseCaching.csproj @@ -9,16 +9,14 @@ true aspnetcore;cache;caching false - true - - - + + diff --git a/src/Middleware/ResponseCompression/src/Microsoft.AspNetCore.ResponseCompression.csproj b/src/Middleware/ResponseCompression/src/Microsoft.AspNetCore.ResponseCompression.csproj index e7d03125a7ee..d63d281422aa 100644 --- a/src/Middleware/ResponseCompression/src/Microsoft.AspNetCore.ResponseCompression.csproj +++ b/src/Middleware/ResponseCompression/src/Microsoft.AspNetCore.ResponseCompression.csproj @@ -7,15 +7,13 @@ true aspnetcore false - true - - - + + diff --git a/src/Middleware/Rewrite/src/Microsoft.AspNetCore.Rewrite.csproj b/src/Middleware/Rewrite/src/Microsoft.AspNetCore.Rewrite.csproj index 5e6acc822f14..1f2336373280 100644 --- a/src/Middleware/Rewrite/src/Microsoft.AspNetCore.Rewrite.csproj +++ b/src/Middleware/Rewrite/src/Microsoft.AspNetCore.Rewrite.csproj @@ -11,17 +11,15 @@ true aspnetcore;urlrewrite;mod_rewrite false - true - - - - - + + + + diff --git a/src/Middleware/Session/src/Microsoft.AspNetCore.Session.csproj b/src/Middleware/Session/src/Microsoft.AspNetCore.Session.csproj index 4eb2cbef6884..4763fe2b207d 100644 --- a/src/Middleware/Session/src/Microsoft.AspNetCore.Session.csproj +++ b/src/Middleware/Session/src/Microsoft.AspNetCore.Session.csproj @@ -9,16 +9,14 @@ true aspnetcore;session;sessionstate false - true - - - - + + + diff --git a/src/Middleware/StaticFiles/src/Microsoft.AspNetCore.StaticFiles.csproj b/src/Middleware/StaticFiles/src/Microsoft.AspNetCore.StaticFiles.csproj index bfc3c8719ea4..52f563a36bbb 100644 --- a/src/Middleware/StaticFiles/src/Microsoft.AspNetCore.StaticFiles.csproj +++ b/src/Middleware/StaticFiles/src/Microsoft.AspNetCore.StaticFiles.csproj @@ -8,7 +8,6 @@ true aspnetcore;staticfiles false - true @@ -19,10 +18,9 @@ - - - - + + + diff --git a/src/Middleware/WebSockets/src/Microsoft.AspNetCore.WebSockets.csproj b/src/Middleware/WebSockets/src/Microsoft.AspNetCore.WebSockets.csproj index d87f72c751cd..74b48aea512d 100644 --- a/src/Middleware/WebSockets/src/Microsoft.AspNetCore.WebSockets.csproj +++ b/src/Middleware/WebSockets/src/Microsoft.AspNetCore.WebSockets.csproj @@ -9,14 +9,12 @@ true aspnetcore false - true - - - + + diff --git a/src/Mvc/Mvc.Abstractions/src/Microsoft.AspNetCore.Mvc.Abstractions.csproj b/src/Mvc/Mvc.Abstractions/src/Microsoft.AspNetCore.Mvc.Abstractions.csproj index 6552972c8d63..71d459fb80cf 100644 --- a/src/Mvc/Mvc.Abstractions/src/Microsoft.AspNetCore.Mvc.Abstractions.csproj +++ b/src/Mvc/Mvc.Abstractions/src/Microsoft.AspNetCore.Mvc.Abstractions.csproj @@ -9,7 +9,6 @@ Microsoft.AspNetCore.Mvc.IActionResult true aspnetcore;aspnetcoremvc false - true @@ -22,7 +21,7 @@ Microsoft.AspNetCore.Mvc.IActionResult - + diff --git a/src/Mvc/Mvc.Core/src/Microsoft.AspNetCore.Mvc.Core.csproj b/src/Mvc/Mvc.Core/src/Microsoft.AspNetCore.Mvc.Core.csproj index 46526209d621..4c3e760a90fd 100644 --- a/src/Mvc/Mvc.Core/src/Microsoft.AspNetCore.Mvc.Core.csproj +++ b/src/Mvc/Mvc.Core/src/Microsoft.AspNetCore.Mvc.Core.csproj @@ -16,7 +16,6 @@ Microsoft.AspNetCore.Mvc.RouteAttribute true aspnetcore;aspnetcoremvc false - true @@ -43,16 +42,15 @@ Microsoft.AspNetCore.Mvc.RouteAttribute - - - - + + + - - - + + + diff --git a/src/Mvc/Mvc.DataAnnotations/src/Microsoft.AspNetCore.Mvc.DataAnnotations.csproj b/src/Mvc/Mvc.DataAnnotations/src/Microsoft.AspNetCore.Mvc.DataAnnotations.csproj index d896e59ba4dc..dcd837d20bec 100644 --- a/src/Mvc/Mvc.DataAnnotations/src/Microsoft.AspNetCore.Mvc.DataAnnotations.csproj +++ b/src/Mvc/Mvc.DataAnnotations/src/Microsoft.AspNetCore.Mvc.DataAnnotations.csproj @@ -7,12 +7,10 @@ true aspnetcore;aspnetcoremvc false - true - - + diff --git a/src/Mvc/Mvc.Localization/src/Microsoft.AspNetCore.Mvc.Localization.csproj b/src/Mvc/Mvc.Localization/src/Microsoft.AspNetCore.Mvc.Localization.csproj index b571ad70ca1d..e3f4cfd3c8a3 100644 --- a/src/Mvc/Mvc.Localization/src/Microsoft.AspNetCore.Mvc.Localization.csproj +++ b/src/Mvc/Mvc.Localization/src/Microsoft.AspNetCore.Mvc.Localization.csproj @@ -10,15 +10,14 @@ Microsoft.AspNetCore.Mvc.Localization.IViewLocalizer true aspnetcore;aspnetcoremvc;localization false - true - - - + + + diff --git a/src/Mvc/Mvc.Razor/src/Microsoft.AspNetCore.Mvc.Razor.csproj b/src/Mvc/Mvc.Razor/src/Microsoft.AspNetCore.Mvc.Razor.csproj index 4a7dd372971c..e9fc306a9e5e 100644 --- a/src/Mvc/Mvc.Razor/src/Microsoft.AspNetCore.Mvc.Razor.csproj +++ b/src/Mvc/Mvc.Razor/src/Microsoft.AspNetCore.Mvc.Razor.csproj @@ -8,15 +8,13 @@ true aspnetcore;aspnetcoremvc;cshtml;razor false - true - - - + + diff --git a/src/Mvc/Mvc.TagHelpers/src/Microsoft.AspNetCore.Mvc.TagHelpers.csproj b/src/Mvc/Mvc.TagHelpers/src/Microsoft.AspNetCore.Mvc.TagHelpers.csproj index a4291cdbc5c1..4d31ad0585f0 100644 --- a/src/Mvc/Mvc.TagHelpers/src/Microsoft.AspNetCore.Mvc.TagHelpers.csproj +++ b/src/Mvc/Mvc.TagHelpers/src/Microsoft.AspNetCore.Mvc.TagHelpers.csproj @@ -7,7 +7,6 @@ aspnetcore;aspnetcoremvc;taghelper;taghelpers true false - true @@ -19,9 +18,8 @@ - - - - + + + diff --git a/src/Mvc/Mvc.ViewFeatures/src/Microsoft.AspNetCore.Mvc.ViewFeatures.csproj b/src/Mvc/Mvc.ViewFeatures/src/Microsoft.AspNetCore.Mvc.ViewFeatures.csproj index 06d70acbab17..56f7a3921815 100644 --- a/src/Mvc/Mvc.ViewFeatures/src/Microsoft.AspNetCore.Mvc.ViewFeatures.csproj +++ b/src/Mvc/Mvc.ViewFeatures/src/Microsoft.AspNetCore.Mvc.ViewFeatures.csproj @@ -15,7 +15,6 @@ aspnetcore;aspnetcoremvc true false - true @@ -26,10 +25,9 @@ + - - diff --git a/src/Mvc/Mvc/src/Microsoft.AspNetCore.Mvc.csproj b/src/Mvc/Mvc/src/Microsoft.AspNetCore.Mvc.csproj index 469e8ea75452..fbc44beae3c5 100644 --- a/src/Mvc/Mvc/src/Microsoft.AspNetCore.Mvc.csproj +++ b/src/Mvc/Mvc/src/Microsoft.AspNetCore.Mvc.csproj @@ -7,7 +7,6 @@ aspnetcore;aspnetcoremvc true false - true @@ -19,9 +18,8 @@ - - - + + diff --git a/src/Razor/Razor/src/Microsoft.AspNetCore.Razor.csproj b/src/Razor/Razor/src/Microsoft.AspNetCore.Razor.csproj index 6ada5367af86..9f8d7443c4a8 100644 --- a/src/Razor/Razor/src/Microsoft.AspNetCore.Razor.csproj +++ b/src/Razor/Razor/src/Microsoft.AspNetCore.Razor.csproj @@ -14,7 +14,6 @@ Microsoft.AspNetCore.Razor.TagHelpers.ITagHelper $(PackageTags);taghelper;taghelpers $(NoWarn);CS1591 false - true true @@ -22,8 +21,7 @@ Microsoft.AspNetCore.Razor.TagHelpers.ITagHelper - - + diff --git a/src/Security/Authentication/Core/src/Microsoft.AspNetCore.Authentication.csproj b/src/Security/Authentication/Core/src/Microsoft.AspNetCore.Authentication.csproj index 3174f810ddfd..e81a55f314c3 100644 --- a/src/Security/Authentication/Core/src/Microsoft.AspNetCore.Authentication.csproj +++ b/src/Security/Authentication/Core/src/Microsoft.AspNetCore.Authentication.csproj @@ -8,7 +8,6 @@ true aspnetcore;authentication;security false - true @@ -20,10 +19,9 @@ - - - - + + + diff --git a/src/Security/CookiePolicy/src/Microsoft.AspNetCore.CookiePolicy.csproj b/src/Security/CookiePolicy/src/Microsoft.AspNetCore.CookiePolicy.csproj index 20be02e4a575..d401e8d69f1f 100644 --- a/src/Security/CookiePolicy/src/Microsoft.AspNetCore.CookiePolicy.csproj +++ b/src/Security/CookiePolicy/src/Microsoft.AspNetCore.CookiePolicy.csproj @@ -8,14 +8,12 @@ true aspnetcore false - true - - - + + diff --git a/src/Servers/HttpSys/src/Microsoft.AspNetCore.Server.HttpSys.csproj b/src/Servers/HttpSys/src/Microsoft.AspNetCore.Server.HttpSys.csproj index 5ce3a5155ab6..06d5ad8b82c6 100644 --- a/src/Servers/HttpSys/src/Microsoft.AspNetCore.Server.HttpSys.csproj +++ b/src/Servers/HttpSys/src/Microsoft.AspNetCore.Server.HttpSys.csproj @@ -9,7 +9,6 @@ true aspnetcore;weblistener;httpsys false - true @@ -21,9 +20,8 @@ - - - + + diff --git a/src/Servers/IIS/IIS/src/Microsoft.AspNetCore.Server.IIS.csproj b/src/Servers/IIS/IIS/src/Microsoft.AspNetCore.Server.IIS.csproj index 901f954df679..c645b127412c 100644 --- a/src/Servers/IIS/IIS/src/Microsoft.AspNetCore.Server.IIS.csproj +++ b/src/Servers/IIS/IIS/src/Microsoft.AspNetCore.Server.IIS.csproj @@ -11,7 +11,6 @@ true $(DefaultNetCoreTargetFramework) false - true @@ -38,11 +37,10 @@ - - - - - + + + + diff --git a/src/Servers/IIS/IISIntegration/src/Microsoft.AspNetCore.Server.IISIntegration.csproj b/src/Servers/IIS/IISIntegration/src/Microsoft.AspNetCore.Server.IISIntegration.csproj index 4fad3da05129..addaf56ff283 100644 --- a/src/Servers/IIS/IISIntegration/src/Microsoft.AspNetCore.Server.IISIntegration.csproj +++ b/src/Servers/IIS/IISIntegration/src/Microsoft.AspNetCore.Server.IISIntegration.csproj @@ -9,7 +9,6 @@ aspnetcore;iis true false - true @@ -19,11 +18,10 @@ - - - - - + + + + diff --git a/src/Servers/Kestrel/Core/src/Microsoft.AspNetCore.Server.Kestrel.Core.csproj b/src/Servers/Kestrel/Core/src/Microsoft.AspNetCore.Server.Kestrel.Core.csproj index f36b501a5209..6c18f1a07820 100644 --- a/src/Servers/Kestrel/Core/src/Microsoft.AspNetCore.Server.Kestrel.Core.csproj +++ b/src/Servers/Kestrel/Core/src/Microsoft.AspNetCore.Server.Kestrel.Core.csproj @@ -9,7 +9,6 @@ true CS1591;$(NoWarn) false - true @@ -23,12 +22,11 @@ + + + - - - - - + diff --git a/src/Servers/Kestrel/Transport.Sockets/src/Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.csproj b/src/Servers/Kestrel/Transport.Sockets/src/Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.csproj index 217212a4ab03..ecdca4391bd0 100644 --- a/src/Servers/Kestrel/Transport.Sockets/src/Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.csproj +++ b/src/Servers/Kestrel/Transport.Sockets/src/Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.csproj @@ -9,7 +9,6 @@ true CS1591;$(NoWarn) false - true @@ -24,8 +23,7 @@ - - + diff --git a/src/SignalR/common/Http.Connections/src/Microsoft.AspNetCore.Http.Connections.csproj b/src/SignalR/common/Http.Connections/src/Microsoft.AspNetCore.Http.Connections.csproj index c86676c7ec46..1e8738d9a960 100644 --- a/src/SignalR/common/Http.Connections/src/Microsoft.AspNetCore.Http.Connections.csproj +++ b/src/SignalR/common/Http.Connections/src/Microsoft.AspNetCore.Http.Connections.csproj @@ -5,7 +5,6 @@ $(DefaultNetCoreTargetFramework) true false - true @@ -32,9 +31,8 @@ - - - + + diff --git a/src/SignalR/server/Core/src/Microsoft.AspNetCore.SignalR.Core.csproj b/src/SignalR/server/Core/src/Microsoft.AspNetCore.SignalR.Core.csproj index f24889b2048c..9a18d8ac7426 100644 --- a/src/SignalR/server/Core/src/Microsoft.AspNetCore.SignalR.Core.csproj +++ b/src/SignalR/server/Core/src/Microsoft.AspNetCore.SignalR.Core.csproj @@ -6,7 +6,6 @@ true Microsoft.AspNetCore.SignalR false - true @@ -21,9 +20,8 @@ - - - + +