From 001f5d8bbd6a5c3c914f424649dbf3c6924e6f3e Mon Sep 17 00:00:00 2001 From: Doug Bunting <6431421+dougbu@users.noreply.github.com> Date: Sun, 5 Apr 2020 13:29:47 -0700 Subject: [PATCH] Remove Code_check job from publish-build-assets.yml `dependsOn` - re-enable the "Build SiteExtension" build step! - nit: remove redundant conditions for easier reading --- .azure/pipelines/ci.yml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.azure/pipelines/ci.yml b/.azure/pipelines/ci.yml index 1c85f16acc2c..56ba9bcad7d6 100644 --- a/.azure/pipelines/ci.yml +++ b/.azure/pipelines/ci.yml @@ -76,6 +76,9 @@ variables: /p:DotNetPublishToBlobFeed=$(_DotNetPublishToBlobFeed) /p:DotNetPublishUsingPipelines=$(_PublishUsingPipelines) /p:DotNetArtifactsCategory=$(_DotNetArtifactsCategory) + + # used for post-build phases, internal builds only + - group: DotNet-AspNet-SDLValidation-Params - ${{ if in(variables['Build.Reason'], 'PullRequest') }}: - name: _BuildArgs value: '' @@ -83,9 +86,6 @@ variables: value: test - name: _PublishArgs value: '' - # used for post-build phases, internal builds only - - ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}: - - group: DotNet-AspNet-SDLValidation-Params stages: - stage: build @@ -176,8 +176,7 @@ stages: -noBuildDeps $(_BuildArgs) $(_InternalRuntimeDownloadArgs) - # Disabled until 3.1.3 is released - condition: false + condition: ne(variables['Build.Reason'], 'PullRequest') displayName: Build SiteExtension # This runs code-signing on all packages, zips, and jar files as defined in build/CodeSign.targets. If https://github.com/dotnet/arcade/issues/1957 is resolved, @@ -798,7 +797,6 @@ stages: - CodeSign_Xplat_Linux_musl_x64 - CodeSign_Xplat_Linux_musl_arm64 # In addition to the dependencies above, ensure the build was successful overall. - - Code_check - Linux_Test - MacOS_Test - Source_Build