Skip to content

Conversation

@dougbu
Copy link
Contributor

@dougbu dougbu commented Apr 5, 2020

  • nit: remove redundant conditions for easier reading

- nit: remove redundant conditions for easier reading
@dougbu dougbu added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode labels Apr 5, 2020
@dougbu dougbu requested a review from a team April 5, 2020 20:58
@dougbu dougbu merged commit 5019088 into release/3.1 Apr 5, 2020
@dougbu dougbu deleted the dougbu/use.codecheck.less/3.1 branch April 5, 2020 22:29
mmitche pushed a commit to mmitche/AspNetCore that referenced this pull request Apr 7, 2020
…dotnet#20558)

- nit: remove redundant conditions for easier reading
mmitche added a commit that referenced this pull request Apr 7, 2020
…#20558) (#20612)

- nit: remove redundant conditions for easier reading

Co-authored-by: Doug Bunting <[email protected]>
pranavkm pushed a commit that referenced this pull request Apr 8, 2020
* Update dependencies from https://github.com/dotnet/aspnetcore-tooling build 20200406.4 (#20600)

- Microsoft.AspNetCore.Mvc.Razor.Extensions - 5.0.0-preview.3.20206.4
- Microsoft.AspNetCore.Razor.Language - 5.0.0-preview.3.20206.4
- Microsoft.CodeAnalysis.Razor - 5.0.0-preview.3.20206.4
- Microsoft.NET.Sdk.Razor - 5.0.0-preview.3.20206.4

Dependency coherency updates

- Microsoft.AspNetCore.Analyzer.Testing - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Caching.Abstractions - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Caching.Memory - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Caching.SqlServer - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Caching.StackExchangeRedis - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.Abstractions - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.Binder - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.CommandLine - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.EnvironmentVariables - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.FileExtensions - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.Ini - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.Json - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.UserSecrets - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration.Xml - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Configuration - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.DependencyInjection.Abstractions - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.DependencyInjection - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.DiagnosticAdapter - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.FileProviders.Abstractions - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.FileProviders.Composite - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.FileProviders.Physical - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.FileSystemGlobbing - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Hosting.Abstractions - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Hosting - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Http - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.Abstractions - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.AzureAppServices - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.Configuration - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.Console - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.Debug - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.EventSource - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.EventLog - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.TraceSource - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Logging.Testing - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Options.ConfigurationExtensions - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Options.DataAnnotations - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Options - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Extensions.Primitives - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Internal.Extensions.Refs - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Win32.Registry - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- Microsoft.NETCore.App.Runtime.win-x64 - 5.0.0-preview.3.20206.14 (parent: Microsoft.Extensions.Logging)
- Microsoft.Extensions.Logging - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)
- Microsoft.Win32.SystemEvents - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.ComponentModel.Annotations - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Diagnostics.EventLog - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Drawing.Common - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.IO.Pipelines - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Net.Http.WinHttpHandler - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Net.WebSockets.WebSocketProtocol - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Reflection.Metadata - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Runtime.CompilerServices.Unsafe - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Security.Cryptography.Cng - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Security.Cryptography.Pkcs - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Security.Cryptography.Xml - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Security.Permissions - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Security.Principal.Windows - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.ServiceProcess.ServiceController - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Text.Encodings.Web - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Text.Json - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Threading.Channels - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- System.Windows.Extensions - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- Microsoft.Extensions.DependencyModel - 5.0.0-preview.3-runtime.20206.14 (parent: Microsoft.Extensions.Logging)
- Microsoft.NETCore.App.Ref - 5.0.0-preview.3.20206.14 (parent: Microsoft.Extensions.Logging)
- Microsoft.NETCore.App.Internal - 5.0.0-preview.3.20206.14 (parent: Microsoft.Extensions.Logging)
- Microsoft.NETCore.Platforms - 5.0.0-preview.3.20206.14 (parent: Microsoft.NETCore.App.Runtime.win-x64)
- Internal.AspNetCore.Analyzers - 5.0.0-preview.3.20206.5 (parent: Microsoft.AspNetCore.Razor.Language)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* [3.1] Remove Code_check job from publish-build-assets.yml `dependsOn` (#20558) (#20612)

- nit: remove redundant conditions for easier reading

Co-authored-by: Doug Bunting <[email protected]>

* Use correct version f or 3.1 SiteExtension package (#20615)

Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Matt Mitchell <[email protected]>
Co-authored-by: Doug Bunting <[email protected]>
Co-authored-by: William Godbe <[email protected]>
Co-authored-by: John Luo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants