From f45f4e3b17731eece424cbe80d8b27d9420ef46c Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Sun, 15 Mar 2020 14:22:59 +0100 Subject: [PATCH 01/11] Default templates to net5.0 --- eng/Workarounds.targets | 15 ++++++++++----- global.json | 2 +- src/ProjectTemplates/Directory.Build.props | 3 +++ src/ProjectTemplates/build.cmd | 2 +- 4 files changed, 15 insertions(+), 7 deletions(-) diff --git a/eng/Workarounds.targets b/eng/Workarounds.targets index 0e2159fd3c25..03f896502278 100644 --- a/eng/Workarounds.targets +++ b/eng/Workarounds.targets @@ -40,17 +40,22 @@ + + $(DefaultNetCoreTargetFramework) + netcoreapp5.0 + + - + diff --git a/global.json b/global.json index 15a1a6543efb..db95de474aad 100644 --- a/global.json +++ b/global.json @@ -3,7 +3,7 @@ "version": "5.0.100-preview.2.20120.3" }, "tools": { - "dotnet": "5.0.100-preview.2.20120.3", + "dotnet": "5.0.100-preview.2.20163.4", "runtimes": { "dotnet/x64": [ "$(MicrosoftNETCoreAppInternalPackageVersion)" diff --git a/src/ProjectTemplates/Directory.Build.props b/src/ProjectTemplates/Directory.Build.props index c12abcf463e5..360aa5600185 100644 --- a/src/ProjectTemplates/Directory.Build.props +++ b/src/ProjectTemplates/Directory.Build.props @@ -2,6 +2,9 @@ + + net5.0 + false false diff --git a/src/ProjectTemplates/build.cmd b/src/ProjectTemplates/build.cmd index b5aa28c66337..7010509e0ad3 100644 --- a/src/ProjectTemplates/build.cmd +++ b/src/ProjectTemplates/build.cmd @@ -1,3 +1,3 @@ @ECHO OFF SET RepoRoot=%~dp0..\.. -%RepoRoot%\build.cmd -projects %~dp0*\*.*proj "/p:EnforceE2ETestPrerequisites=true" %* +%RepoRoot%\build.cmd -projects %~dp0*\*.*proj -ForceCoreMsbuild "/p:EnforceE2ETestPrerequisites=true" %* From 4472da1c541c79c1912fbf353ad16333cdd8d6ef Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Mon, 16 Mar 2020 15:06:53 +0100 Subject: [PATCH 02/11] Update global.json to allow prerelease and rollforward --- global.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/global.json b/global.json index db95de474aad..ff76a30504ef 100644 --- a/global.json +++ b/global.json @@ -1,6 +1,8 @@ { "sdk": { - "version": "5.0.100-preview.2.20120.3" + "version": "5.0.100-preview.2.20120.3", + "allowPrerelease": true, + "rollForward": "major" }, "tools": { "dotnet": "5.0.100-preview.2.20163.4", From 81698d2b0e953485d35c48b492d1310edbd7354a Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Mon, 16 Mar 2020 21:32:28 +0100 Subject: [PATCH 03/11] Update required vs msbuild version --- global.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/global.json b/global.json index ff76a30504ef..3f042f67c70d 100644 --- a/global.json +++ b/global.json @@ -1,6 +1,6 @@ { "sdk": { - "version": "5.0.100-preview.2.20120.3", + "version": "5.0.100-preview.2.20163.4", "allowPrerelease": true, "rollForward": "major" }, @@ -17,7 +17,7 @@ "Git": "2.22.0", "jdk": "11.0.3", "vs": { - "version": "16.3", + "version": "16.5", "components": [ "Microsoft.VisualStudio.Component.VC.ATL", "Microsoft.VisualStudio.Component.VC.Tools.x86.x64", From 05d74f74fde6fa5157bf99676a7f7cd2c2762ae6 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Mon, 16 Mar 2020 21:34:03 +0100 Subject: [PATCH 04/11] PR feedback --- eng/Workarounds.targets | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/Workarounds.targets b/eng/Workarounds.targets index 03f896502278..4a00c1786bee 100644 --- a/eng/Workarounds.targets +++ b/eng/Workarounds.targets @@ -49,12 +49,12 @@ From 47ed39a0b72326847d7f43dd6a3b9d71883b1edc Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Tue, 17 Mar 2020 16:23:28 +0100 Subject: [PATCH 05/11] Update queues to use 16.5 --- .azure/pipelines/jobs/default-build.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.azure/pipelines/jobs/default-build.yml b/.azure/pipelines/jobs/default-build.yml index f1596a7b10b1..4988373b8a32 100644 --- a/.azure/pipelines/jobs/default-build.yml +++ b/.azure/pipelines/jobs/default-build.yml @@ -97,14 +97,14 @@ jobs: name: NetCorePublic-Pool ${{ if ne(parameters.isTestingJob, true) }}: # Visual Studio Build Tools - queue: BuildPool.Server.Amd64.VS2019.BT.Open + queue: buildpool.server.amd64.vs2019.pre.open ${{ if eq(parameters.isTestingJob, true) }}: # Visual Studio Enterprise - contains some stuff, like SQL Server and IIS Express, that we use for testing - queue: BuildPool.Server.Amd64.VS2019.Open + queue: buildpool.server.amd64.vs2019.pre.open ${{ if eq(variables['System.TeamProject'], 'internal') }}: name: NetCoreInternal-Pool # Visual Studio Enterprise - contains some stuff, like SQL Server and IIS Express, that we use for testing - queue: BuildPool.Server.Amd64.VS2019 + queue: buildpool.server.amd64.vs2019.pre variables: - AgentOsName: ${{ parameters.agentOs }} - ASPNETCORE_TEST_LOG_MAXPATH: "200" # Keep test log file name length low enough for artifact zipping From e0a8ea1423eca757cca7ad98f43595d5fb042c9f Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Wed, 18 Mar 2020 19:38:42 +0100 Subject: [PATCH 06/11] Update missing project templates tfms --- .../BlazorWasm-CSharp/.template.config/template.json | 8 ++++---- .../BlazorServerWeb-CSharp/.template.config/template.json | 8 ++++---- .../EmptyWeb-CSharp/.template.config/template.json | 8 ++++---- .../EmptyWeb-FSharp/.template.config/template.json | 8 ++++---- .../GrpcService-CSharp/.template.config/template.json | 6 +++--- .../.template.config/template.json | 6 +++--- .../RazorPagesWeb-CSharp/.template.config/template.json | 8 ++++---- .../StarterWeb-CSharp/.template.config/template.json | 8 ++++---- .../StarterWeb-FSharp/.template.config/template.json | 8 ++++---- .../content/WebApi-CSharp/.template.config/template.json | 8 ++++---- .../content/WebApi-FSharp/.template.config/template.json | 8 ++++---- .../content/Worker-CSharp/.template.config/template.json | 8 ++++---- .../content/Angular-CSharp/.template.config/template.json | 8 ++++---- .../content/React-CSharp/.template.config/template.json | 8 ++++---- .../ReactRedux-CSharp/.template.config/template.json | 8 ++++---- 15 files changed, 58 insertions(+), 58 deletions(-) diff --git a/src/ProjectTemplates/BlazorWasm.ProjectTemplates/content/BlazorWasm-CSharp/.template.config/template.json b/src/ProjectTemplates/BlazorWasm.ProjectTemplates/content/BlazorWasm-CSharp/.template.config/template.json index e49f99528931..29d5eef17448 100644 --- a/src/ProjectTemplates/BlazorWasm.ProjectTemplates/content/BlazorWasm-CSharp/.template.config/template.json +++ b/src/ProjectTemplates/BlazorWasm.ProjectTemplates/content/BlazorWasm-CSharp/.template.config/template.json @@ -85,12 +85,12 @@ "datatype": "choice", "choices": [ { - "choice": "netcoreapp5.0", - "description": "Target netcoreapp5.0" + "choice": "net5.0", + "description": "Target net5.0" } ], - "replaces": "netcoreapp5.0", - "defaultValue": "netcoreapp5.0" + "replaces": "net5.0", + "defaultValue": "net5.0" }, "HostIdentifier": { "type": "bind", diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorServerWeb-CSharp/.template.config/template.json b/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorServerWeb-CSharp/.template.config/template.json index 66bfdc777bb2..484e81863cd8 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorServerWeb-CSharp/.template.config/template.json +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/BlazorServerWeb-CSharp/.template.config/template.json @@ -337,12 +337,12 @@ "datatype": "choice", "choices": [ { - "choice": "netcoreapp5.0", - "description": "Target netcoreapp5.0" + "choice": "net5.0", + "description": "Target net5.0" } ], - "replaces": "netcoreapp5.0", - "defaultValue": "netcoreapp5.0" + "replaces": "net5.0", + "defaultValue": "net5.0" }, "copyrightYear": { "type": "generated", diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/EmptyWeb-CSharp/.template.config/template.json b/src/ProjectTemplates/Web.ProjectTemplates/content/EmptyWeb-CSharp/.template.config/template.json index caf1ab80e607..9964a3ae5a5a 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/EmptyWeb-CSharp/.template.config/template.json +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/EmptyWeb-CSharp/.template.config/template.json @@ -86,12 +86,12 @@ "datatype": "choice", "choices": [ { - "choice": "netcoreapp5.0", - "description": "Target netcoreapp5.0" + "choice": "net5.0", + "description": "Target net5.0" } ], - "replaces": "netcoreapp5.0", - "defaultValue": "netcoreapp5.0" + "replaces": "net5.0", + "defaultValue": "net5.0" }, "copyrightYear": { "type": "generated", diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/EmptyWeb-FSharp/.template.config/template.json b/src/ProjectTemplates/Web.ProjectTemplates/content/EmptyWeb-FSharp/.template.config/template.json index df7b62a1697b..9f436eba9c3e 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/EmptyWeb-FSharp/.template.config/template.json +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/EmptyWeb-FSharp/.template.config/template.json @@ -82,12 +82,12 @@ "datatype": "choice", "choices": [ { - "choice": "netcoreapp5.0", - "description": "Target netcoreapp5.0" + "choice": "net5.0", + "description": "Target net5.0" } ], - "replaces": "netcoreapp5.0", - "defaultValue": "netcoreapp5.0" + "replaces": "net5.0", + "defaultValue": "net5.0" }, "copyrightYear": { "type": "generated", diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/GrpcService-CSharp/.template.config/template.json b/src/ProjectTemplates/Web.ProjectTemplates/content/GrpcService-CSharp/.template.config/template.json index 0ca933164a50..7c9acda73b39 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/GrpcService-CSharp/.template.config/template.json +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/GrpcService-CSharp/.template.config/template.json @@ -41,11 +41,11 @@ "datatype": "choice", "choices": [ { - "choice": "netcoreapp5.0", - "description": "Target netcoreapp5.0" + "choice": "net5.0", + "description": "Target net5.0" } ], - "defaultValue": "netcoreapp5.0" + "defaultValue": "net5.0" }, "ExcludeLaunchSettings": { "type": "parameter", diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/RazorClassLibrary-CSharp/.template.config/template.json b/src/ProjectTemplates/Web.ProjectTemplates/content/RazorClassLibrary-CSharp/.template.config/template.json index 543e0bdd5dd9..5a6a957a2ca7 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/RazorClassLibrary-CSharp/.template.config/template.json +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/RazorClassLibrary-CSharp/.template.config/template.json @@ -47,11 +47,11 @@ "datatype": "choice", "choices": [ { - "choice": "netcoreapp5.0", - "description": "Target netcoreapp5.0" + "choice": "net5.0", + "description": "Target net5.0" } ], - "defaultValue": "netcoreapp5.0" + "defaultValue": "net5.0" }, "HostIdentifier": { "type": "bind", diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/RazorPagesWeb-CSharp/.template.config/template.json b/src/ProjectTemplates/Web.ProjectTemplates/content/RazorPagesWeb-CSharp/.template.config/template.json index 81aacfa7e7b4..a98d4dcf6c56 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/RazorPagesWeb-CSharp/.template.config/template.json +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/RazorPagesWeb-CSharp/.template.config/template.json @@ -316,12 +316,12 @@ "datatype": "choice", "choices": [ { - "choice": "netcoreapp5.0", - "description": "Target netcoreapp5.0" + "choice": "net5.0", + "description": "Target net5.0" } ], - "replaces": "netcoreapp5.0", - "defaultValue": "netcoreapp5.0" + "replaces": "net5.0", + "defaultValue": "net5.0" }, "copyrightYear": { "type": "generated", diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/StarterWeb-CSharp/.template.config/template.json b/src/ProjectTemplates/Web.ProjectTemplates/content/StarterWeb-CSharp/.template.config/template.json index d846394fa943..9fabeb1cc414 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/StarterWeb-CSharp/.template.config/template.json +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/StarterWeb-CSharp/.template.config/template.json @@ -306,12 +306,12 @@ "datatype": "choice", "choices": [ { - "choice": "netcoreapp5.0", - "description": "Target netcoreapp5.0" + "choice": "net5.0", + "description": "Target net5.0" } ], - "replaces": "netcoreapp5.0", - "defaultValue": "netcoreapp5.0" + "replaces": "net5.0", + "defaultValue": "net5.0" }, "copyrightYear": { "type": "generated", diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/StarterWeb-FSharp/.template.config/template.json b/src/ProjectTemplates/Web.ProjectTemplates/content/StarterWeb-FSharp/.template.config/template.json index 779cf7d82c17..6988370f4eb2 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/StarterWeb-FSharp/.template.config/template.json +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/StarterWeb-FSharp/.template.config/template.json @@ -87,12 +87,12 @@ "datatype": "choice", "choices": [ { - "choice": "netcoreapp5.0", - "description": "Target netcoreapp5.0" + "choice": "net5.0", + "description": "Target net5.0" } ], - "replaces": "netcoreapp5.0", - "defaultValue": "netcoreapp5.0" + "replaces": "net5.0", + "defaultValue": "net5.0" }, "copyrightYear": { "type": "generated", diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/WebApi-CSharp/.template.config/template.json b/src/ProjectTemplates/Web.ProjectTemplates/content/WebApi-CSharp/.template.config/template.json index 9c560017be7a..731fcbcb0fa7 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/WebApi-CSharp/.template.config/template.json +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/WebApi-CSharp/.template.config/template.json @@ -209,12 +209,12 @@ "datatype": "choice", "choices": [ { - "choice": "netcoreapp5.0", - "description": "Target netcoreapp5.0" + "choice": "net5.0", + "description": "Target net5.0" } ], - "replaces": "netcoreapp5.0", - "defaultValue": "netcoreapp5.0" + "replaces": "net5.0", + "defaultValue": "net5.0" }, "copyrightYear": { "type": "generated", diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/WebApi-FSharp/.template.config/template.json b/src/ProjectTemplates/Web.ProjectTemplates/content/WebApi-FSharp/.template.config/template.json index b3f4e81300f7..d9d9cf819322 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/WebApi-FSharp/.template.config/template.json +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/WebApi-FSharp/.template.config/template.json @@ -82,12 +82,12 @@ "datatype": "choice", "choices": [ { - "choice": "netcoreapp5.0", - "description": "Target netcoreapp5.0" + "choice": "net5.0", + "description": "Target net5.0" } ], - "replaces": "netcoreapp5.0", - "defaultValue": "netcoreapp5.0" + "replaces": "net5.0", + "defaultValue": "net5.0" }, "copyrightYear": { "type": "generated", diff --git a/src/ProjectTemplates/Web.ProjectTemplates/content/Worker-CSharp/.template.config/template.json b/src/ProjectTemplates/Web.ProjectTemplates/content/Worker-CSharp/.template.config/template.json index fa3775c56451..fdffe3815f25 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/content/Worker-CSharp/.template.config/template.json +++ b/src/ProjectTemplates/Web.ProjectTemplates/content/Worker-CSharp/.template.config/template.json @@ -47,12 +47,12 @@ "datatype": "choice", "choices": [ { - "choice": "netcoreapp5.0", - "description": "Target netcoreapp5.0" + "choice": "net5.0", + "description": "Target net5.0" } ], - "replaces": "netcoreapp5.0", - "defaultValue": "netcoreapp5.0" + "replaces": "net5.0", + "defaultValue": "net5.0" }, "copyrightYear": { "type": "generated", diff --git a/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/Angular-CSharp/.template.config/template.json b/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/Angular-CSharp/.template.config/template.json index fb376267c2c8..1a26e86718a6 100644 --- a/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/Angular-CSharp/.template.config/template.json +++ b/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/Angular-CSharp/.template.config/template.json @@ -177,12 +177,12 @@ "datatype": "choice", "choices": [ { - "choice": "netcoreapp5.0", - "description": "Target netcoreapp5.0" + "choice": "net5.0", + "description": "Target net5.0" } ], - "replaces": "netcoreapp5.0", - "defaultValue": "netcoreapp5.0" + "replaces": "net5.0", + "defaultValue": "net5.0" }, "HostIdentifier": { "type": "bind", diff --git a/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/React-CSharp/.template.config/template.json b/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/React-CSharp/.template.config/template.json index 4b2e6ad78671..24854b9c5631 100644 --- a/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/React-CSharp/.template.config/template.json +++ b/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/React-CSharp/.template.config/template.json @@ -178,12 +178,12 @@ "datatype": "choice", "choices": [ { - "choice": "netcoreapp5.0", - "description": "Target netcoreapp5.0" + "choice": "net5.0", + "description": "Target net5.0" } ], - "replaces": "netcoreapp5.0", - "defaultValue": "netcoreapp5.0" + "replaces": "net5.0", + "defaultValue": "net5.0" }, "HostIdentifier": { "type": "bind", diff --git a/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/ReactRedux-CSharp/.template.config/template.json b/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/ReactRedux-CSharp/.template.config/template.json index f32b4adac42d..935a599725d4 100644 --- a/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/ReactRedux-CSharp/.template.config/template.json +++ b/src/ProjectTemplates/Web.Spa.ProjectTemplates/content/ReactRedux-CSharp/.template.config/template.json @@ -87,12 +87,12 @@ "datatype": "choice", "choices": [ { - "choice": "netcoreapp5.0", - "description": "Target netcoreapp5.0" + "choice": "net5.0", + "description": "Target net5.0" } ], - "replaces": "netcoreapp5.0", - "defaultValue": "netcoreapp5.0" + "replaces": "net5.0", + "defaultValue": "net5.0" }, "HostIdentifier": { "type": "bind", From f7c9e4139c889508951cded3ad3a5adc4f03bb23 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Thu, 2 Apr 2020 19:18:44 +0200 Subject: [PATCH 07/11] Update queue temporarily to scout change --- .azure/pipelines/jobs/default-build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.azure/pipelines/jobs/default-build.yml b/.azure/pipelines/jobs/default-build.yml index 4988373b8a32..47d3bc9a6041 100644 --- a/.azure/pipelines/jobs/default-build.yml +++ b/.azure/pipelines/jobs/default-build.yml @@ -97,10 +97,10 @@ jobs: name: NetCorePublic-Pool ${{ if ne(parameters.isTestingJob, true) }}: # Visual Studio Build Tools - queue: buildpool.server.amd64.vs2019.pre.open + queue: BuildPool.Windows.10.Amd64.VS2019.tmp.Open ${{ if eq(parameters.isTestingJob, true) }}: # Visual Studio Enterprise - contains some stuff, like SQL Server and IIS Express, that we use for testing - queue: buildpool.server.amd64.vs2019.pre.open + queue: BuildPool.Windows.10.Amd64.VS2019.tmp.Open ${{ if eq(variables['System.TeamProject'], 'internal') }}: name: NetCoreInternal-Pool # Visual Studio Enterprise - contains some stuff, like SQL Server and IIS Express, that we use for testing From f87e81ca23454bc78c80c68d9ba75a17373fa17b Mon Sep 17 00:00:00 2001 From: Doug Bunting <6431421+dougbu@users.noreply.github.com> Date: Wed, 8 Apr 2020 10:07:35 -0700 Subject: [PATCH 08/11] Revert changes to default-build.yml --- .azure/pipelines/jobs/default-build.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.azure/pipelines/jobs/default-build.yml b/.azure/pipelines/jobs/default-build.yml index 47d3bc9a6041..1c94bf6ad4d8 100644 --- a/.azure/pipelines/jobs/default-build.yml +++ b/.azure/pipelines/jobs/default-build.yml @@ -97,14 +97,14 @@ jobs: name: NetCorePublic-Pool ${{ if ne(parameters.isTestingJob, true) }}: # Visual Studio Build Tools - queue: BuildPool.Windows.10.Amd64.VS2019.tmp.Open + queue: BuildPool.Server.Amd64.VS2019.Open ${{ if eq(parameters.isTestingJob, true) }}: # Visual Studio Enterprise - contains some stuff, like SQL Server and IIS Express, that we use for testing - queue: BuildPool.Windows.10.Amd64.VS2019.tmp.Open + queue: BuildPool.Server.Amd64.VS2019.Open ${{ if eq(variables['System.TeamProject'], 'internal') }}: name: NetCoreInternal-Pool # Visual Studio Enterprise - contains some stuff, like SQL Server and IIS Express, that we use for testing - queue: buildpool.server.amd64.vs2019.pre + queue: BuildPool.Server.Amd64.VS2019 variables: - AgentOsName: ${{ parameters.agentOs }} - ASPNETCORE_TEST_LOG_MAXPATH: "200" # Keep test log file name length low enough for artifact zipping From 26020edc02423091b2d10b2e07740255689bf3a6 Mon Sep 17 00:00:00 2001 From: Doug Bunting <6431421+dougbu@users.noreply.github.com> Date: Wed, 8 Apr 2020 10:08:23 -0700 Subject: [PATCH 09/11] !fixup! oops --- .azure/pipelines/jobs/default-build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.azure/pipelines/jobs/default-build.yml b/.azure/pipelines/jobs/default-build.yml index 1c94bf6ad4d8..f1596a7b10b1 100644 --- a/.azure/pipelines/jobs/default-build.yml +++ b/.azure/pipelines/jobs/default-build.yml @@ -97,7 +97,7 @@ jobs: name: NetCorePublic-Pool ${{ if ne(parameters.isTestingJob, true) }}: # Visual Studio Build Tools - queue: BuildPool.Server.Amd64.VS2019.Open + queue: BuildPool.Server.Amd64.VS2019.BT.Open ${{ if eq(parameters.isTestingJob, true) }}: # Visual Studio Enterprise - contains some stuff, like SQL Server and IIS Express, that we use for testing queue: BuildPool.Server.Amd64.VS2019.Open From 99d7b083f9db159a2c4f2bd64b874338d709e15c Mon Sep 17 00:00:00 2001 From: William Godbe Date: Wed, 8 Apr 2020 13:41:29 -0700 Subject: [PATCH 10/11] Try newer SDK --- global.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/global.json b/global.json index 3f042f67c70d..5cb43de1eb73 100644 --- a/global.json +++ b/global.json @@ -1,11 +1,11 @@ { "sdk": { - "version": "5.0.100-preview.2.20163.4", + "version": "5.0.100-preview.2.20177.6", "allowPrerelease": true, "rollForward": "major" }, "tools": { - "dotnet": "5.0.100-preview.2.20163.4", + "dotnet": "5.0.100-preview.2.20177.6", "runtimes": { "dotnet/x64": [ "$(MicrosoftNETCoreAppInternalPackageVersion)" From b825f6b2500807d54e8fb079375e6dde9e3bf440 Mon Sep 17 00:00:00 2001 From: William Godbe Date: Wed, 8 Apr 2020 14:57:57 -0700 Subject: [PATCH 11/11] Revert to slightly older SDK --- global.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/global.json b/global.json index 5cb43de1eb73..3f042f67c70d 100644 --- a/global.json +++ b/global.json @@ -1,11 +1,11 @@ { "sdk": { - "version": "5.0.100-preview.2.20177.6", + "version": "5.0.100-preview.2.20163.4", "allowPrerelease": true, "rollForward": "major" }, "tools": { - "dotnet": "5.0.100-preview.2.20177.6", + "dotnet": "5.0.100-preview.2.20163.4", "runtimes": { "dotnet/x64": [ "$(MicrosoftNETCoreAppInternalPackageVersion)"