From ef665efb065c738dfb75239d71acadc3b366f17d Mon Sep 17 00:00:00 2001 From: Brennan Conroy Date: Tue, 22 Oct 2019 12:38:35 -0700 Subject: [PATCH 1/2] Remove flaky test --- .../test/FunctionalTests/ServerTests.cs | 25 ------------------- 1 file changed, 25 deletions(-) diff --git a/src/Servers/HttpSys/test/FunctionalTests/ServerTests.cs b/src/Servers/HttpSys/test/FunctionalTests/ServerTests.cs index 1816fdcc282b..395edcfb35c7 100644 --- a/src/Servers/HttpSys/test/FunctionalTests/ServerTests.cs +++ b/src/Servers/HttpSys/test/FunctionalTests/ServerTests.cs @@ -366,31 +366,6 @@ public void Server_SetConnectionLimitArgumentValidation_Success() } } - [ConditionalFact] - public async Task Server_SetConnectionLimit_Success() - { - using (Utilities.CreateDynamicHost(out var address, options => - { - Assert.Null(options.MaxConnections); - options.MaxConnections = 3; - }, httpContext => Task.FromResult(0))) - { - using (var client1 = await SendHungRequestAsync("GET", address)) - using (var client2 = await SendHungRequestAsync("GET", address)) - { - using (var client3 = await SendHungRequestAsync("GET", address)) - { - // Maxed out, refuses connection and throws - await Assert.ThrowsAsync(() => SendRequestAsync(address)); - } - - // A connection has been closed, try again. - string responseText = await SendRequestAsync(address); - Assert.Equal(string.Empty, responseText); - } - } - } - [ConditionalFact] public async Task Server_SetConnectionLimitChangeAfterStarted_Success() { From b1b0398a1cbe3c33ec42db2e02d8a990b4446080 Mon Sep 17 00:00:00 2001 From: Brennan Conroy Date: Wed, 23 Oct 2019 08:30:31 -0700 Subject: [PATCH 2/2] fixup flaky test --- src/Servers/HttpSys/test/FunctionalTests/ServerTests.cs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/Servers/HttpSys/test/FunctionalTests/ServerTests.cs b/src/Servers/HttpSys/test/FunctionalTests/ServerTests.cs index 395edcfb35c7..04228c6da6e4 100644 --- a/src/Servers/HttpSys/test/FunctionalTests/ServerTests.cs +++ b/src/Servers/HttpSys/test/FunctionalTests/ServerTests.cs @@ -345,10 +345,6 @@ public async Task Server_SetHttp503VebosityHittingThrottle_Success() Assert.Equal(HttpStatusCode.ServiceUnavailable, response.StatusCode); } } - - // A connection has been closed, try again. - string responseText = await SendRequestAsync(address); - Assert.Equal(string.Empty, responseText); } } }