Skip to content

Conversation

@sakthi1985
Copy link

No description provided.

@dnfclas
Copy link

dnfclas commented Feb 8, 2016

Hi @sakthi1985, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@sakthi1985 sakthi1985 closed this Feb 8, 2016
@natemcmaster natemcmaster deleted the glennc/rc1 branch October 16, 2018 22:08
jkotalik added a commit that referenced this pull request Nov 1, 2018
natemcmaster pushed a commit that referenced this pull request Nov 20, 2018
SteveSandersonMS pushed a commit that referenced this pull request Nov 27, 2018
* Reenable HtmlBlock unit tests

* Add E2E tests for HTML Block cases

* Remove harded GenerateBaselines=true

* Fix #1193

This commit addresses the root cause of #1193. When we merge HTML
text nodes into HTML blocks we need to re-encode any HTML entities that
were encoded eariler.

I did a bit of a deep dive on how HTML encoding is handled in Blazor and
I think this is the best strategy. I think it's valuable that the
BrowserRenderer uses document.createTextNode, which will always encode
the text - this handles dynamic content. We want to keep this in place
to avoid HTML injection attacks.

* Fix #1265 Reenable MarkupBlock

* test cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants