What to do with Microsoft.Extensions.DiagnosticAdapter dependency

[wtgodbe]

We depend on a random preview version of Microsoft.Extensions.DiagnosticAdapter, which appears to be a deprecated package:

aspnetcore/eng/Versions.props

Line 162 in 10e3fe3

<MicrosoftExtensionsDiagnosticAdapterVersion>5.0.0-preview.4.20180.4</MicrosoftExtensionsDiagnosticAdapterVersion>

It's used by a bunch of tests/packages. We should figure out if we can stop using it or switch to a different version, since it appears to be the only thing forcing us to keep the dotnet5 feed in nuget.config:

aspnetcore/NuGet.config

Lines 7 to 8 in 10e3fe3

	<add key="dotnet5" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5/nuget/v3/index.json" />
	<add key="dotnet5-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5-transport/nuget/v3/index.json" />

CC @dotnet/aspnet-build

[dougbu]

@wtgodbe, to @ericstj's point in dotnet/extensions#3165, how exactly are we using what the assembly provided and can those uses be removed❔

@ericstj when you mentioned "latest stable version" in that PR, did you mean 5.0.0-preview.3.20215.2❔ That's in dotnet-public 😄

nit: the dotnet5-transport feed cannot be removed because it's used to create the site extension bundle.

[dougbu]

Package still used in 'main' though exclusively in tests and test infrastructure.

[dougbu]

Package actually used in release/6.0, release/7.0, and main. As-is, it's the sole reason we require the dotnet5 feed in those branches. I'm moving to 5.0.0-preview.3.20215.2 in draft PRs aimed at reducing our feed count. That's not a complete solution however.

I don't think this is truly an area-infrastructure issue but will admit it doesn't clearly fit in one area. The package is used in hosting, middleware, and MVC tests. Anyone familiar enough w/ the relevant tests (see src\Mvc\shared\Mvc.TestDiagnosticListener\TestDiagnosticListener.cs for example, which hasn't changed much since it was in aspnet/Mvc) to get rid of this dependency during MQ @adityamandaleeka @rafikiassumani-msft @mkArtakMSFT❔

[dougbu]

Note my draft PRs will address @ericstj's "latest preview" point but not "Can you just remove usage?"

[ericstj]

when you mentioned "latest stable version" in that PR, did you mean 5.0.0-preview.3.20215.2❔ That's in dotnet-public 😄

That wouldn't be stable. A stable version doesn't have a pre-release suffix. So I think the latest stable is 3.1.30

5.0.0-preview.3.20215.2 is a dead-end that built from dotnet/extensions repo before the project was deleted so it shouldn't be used since it has no servicing story.

[dougbu]

I'll do another round of Microsoft.Extensions.DiagnosticAdapter downgrades (to 3.1.31 or so) if I can't get @adityamandaleeka @rafikiassumani-msft or @mkArtakMSFT interested in avoiding the underlying test dependencies on that package.

[delixfe]

This is also referenced by a sample: src/Middleware/MiddlewareAnalysis/samples/MiddlewareAnalysisSample/MiddlewareAnalysisSample.csproj.

It took a while to figure out that the package is deprecated.