Microsoft.AspNetCore.Hosting.ListenOptionsHttpsExtensions without reflection ?

[LLT21]

I have tried to compile my .NET 5 bare http server project with Native AOT without reflection. This is possible for a normal http connection, but not for a https connection because in Microsoft.AspNetCore.Hosting.ListenOptionsHttpsExtensions the line of code:

var loggerFactory = listenOptions.KestrelServerOptions?.ApplicationServices.GetRequiredService<ILoggerFactory>() ?? NullLoggerFactory.Instance;

that appears twice in this class requires reflection. Could it be changed to:

var loggerFactory = listenOptions.KestrelServerOptions?.ApplicationServices?.GetRequiredService<ILoggerFactory>() ?? NullLoggerFactory.Instance;

so that it has the ? after ApplicationServices. In this way I believe the reflection can be avoided.

[davidfowl]

This must be the tip of the iceberg. We can change small things if people send pull requests but without a way to stop future regressions with tests it'll keep breaking in the future

[BrennanConroy]

Like David said, until we have AOT testing we wont be able to make any significant improvements for AOT environments.

If you would like to send a PR we can accept that, otherwise we wont be fixing this issue specifically right now.

Also, what was the actual error you were getting? A nullref?

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

[LLT21]

Thanks for the feedback. I am investigating further on my side whether the requested change would solve my issue, but I have a new MacBook Air ARM and building aspnetcore on that one seems not easy/possible. Will have to switch to my MacBook Pro but that will be for next weekend.

…

On 7 Apr 2021, at 22:12, msftbot[bot] ***@***.***> wrote: We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process <https://github.com/dotnet/aspnetcore/blob/master/docs/TriageProcess.md>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#31561 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKO6WGFWKLTICCWI5QZDA5DTHS4CDANCNFSM42O4F65Q>.

[davidfowl]

I don't think it will.

[LLT21]

Here some more info after doing a lot of testing this weekend; I have the feeling it is almost there, just still looking for how to include my custom Kestrel build in the NativeAOT flow. First, let me give you some more background about the feature I am looking for: the idea is to make some simple web api's, developed in C#, making use of Kestrel, but natively compiled for size, speed and C++ alike code protection. Based on some examples I found, I came to the following program: ```C# using System; using System.Collections.Generic; using System.IO; using System.Security.Cryptography.X509Certificates; using System.Text; using System.Text.Json; using System.Threading; using System.Threading.Tasks; using Microsoft.AspNetCore.Hosting; using Microsoft.AspNetCore.Hosting.Server; using Microsoft.AspNetCore.Http.Features; using Microsoft.AspNetCore.Server.Kestrel.Core; using Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets; using Microsoft.Extensions.DependencyInjection; using Microsoft.Extensions.Logging.Abstractions; using Microsoft.Extensions.Options; namespace tinykestrel { class Program { static async Task Main(string[] args) { NullLoggerFactory nullLoggerFactory = new NullLoggerFactory(); SocketTransportOptions socketTransportOptions = new SocketTransportOptions(); SocketTransportFactory socketTransportFactory = new SocketTransportFactory( new OptionsWrapper<SocketTransportOptions>(socketTransportOptions), nullLoggerFactory); KestrelServerOptions kestrelServerOptions = new KestrelServerOptions(); /* This ApplicationServices configuration is required to make .NET5 and .NET6 work, but it prohibits NativeAOT without reflection */ /* kestrelServerOptions.ApplicationServices = new ServiceCollection() .AddLogging() .BuildServiceProvider(); */ kestrelServerOptions.ListenLocalhost(5001, listenOptions => { X509Certificate2 serverCertificate = new X509Certificate2("server.pfx", "xxx"); listenOptions.UseHttps(serverCertificate); }); using (KestrelServer kestrelServer = new KestrelServer(new OptionsWrapper<KestrelServerOptions>(kestrelServerOptions), socketTransportFactory, nullLoggerFactory ) ) { await kestrelServer.StartAsync(new HttpApplication(), CancellationToken.None); Console.ReadLine(); } } } public class HttpApplication : IHttpApplication<IFeatureCollection> { public IFeatureCollection CreateContext(IFeatureCollection contextFeatures) { return contextFeatures; } public void DisposeContext(IFeatureCollection context, Exception exception) { } public async Task ProcessRequestAsync(IFeatureCollection features) { IHttpRequestFeature request = (IHttpRequestFeature)features[typeof(IHttpRequestFeature)]; IHttpResponseFeature response = (IHttpResponseFeature)features[typeof(IHttpResponseFeature)]; IHttpResponseBodyFeature responseBody = (IHttpResponseBodyFeature)features[typeof(IHttpResponseBodyFeature)]; //IHttpConnectionFeature connection = (IHttpConnectionFeature)features[typeof(IHttpConnectionFeature)]; string requestBodyString; Dictionary<string, object> jsonObjects = null; using (StreamReader streamReader = new StreamReader(request.Body)) { requestBodyString = await streamReader.ReadToEndAsync(); if (requestBodyString != string.Empty) { jsonObjects = await JsonSerializer.DeserializeAsync<Dictionary<string, object>>(new MemoryStream(Encoding.UTF8.GetBytes(requestBodyString))); jsonObjects.Add("extra 1", "hey, I just changed your json"); } } if (jsonObjects == null) { jsonObjects = new Dictionary<string, object>(); jsonObjects.Add("line 1", "please send me some json and I will send it back to you"); jsonObjects.Add("line 2", "you can use me if you like"); jsonObjects.Add("line 3", "do no use subobjects in the json, I am a simple web api"); } string responseBodyString = JsonSerializer.Serialize(jsonObjects); byte[] responseBodyBytes = Encoding.UTF8.GetBytes(responseBodyString); response.Headers.ContentLength = responseBodyBytes.Length; response.Headers.Add("Content-Type", "application/json"); await responseBody.Stream.WriteAsync(responseBodyBytes, 0, responseBodyBytes.Length); } } } ``` Without the https configuration lines: ```C# kestrelServerOptions.ListenLocalhost(5001, listenOptions => { X509Certificate2 serverCertificate = new X509Certificate2("server.pfx", "xxx"); listenOptions.UseHttps(serverCertificate); }); ``` I can natively compile and run this on my Mac. However, when I add the UseHttps lines above without: ```C# kestrelServerOptions.ApplicationServices = new ServiceCollection() .AddLogging() .BuildServiceProvider(); ``` Then I indeed get as you replied a Null reference error on the lines mentioned in the Microsoft.AspNetCore.Hosting.ListenOptionsHttpsExtensions. I managed to compile the Kestrel project with the requested change implemented locally on my Mac and then in debug mode the above program runs fine again, also with the UseHttps and without the kestrelServerOptions.ApplicationServices configured. The only thing I am missing at the moment is how to include my custom built Microsoft.AspNetCore.Server.Kestrel.Core.dll and Microsoft.AspNetCore.Server.Kestrel.dll in the NativeAOT compilation on Mac. I am pretty sure if I get there, the above will work and opens a nice solution to develop simple natively compiled web api's with Kestrel in C#. So it would be nice if you could include the 2 question marks to avoid the Null reference error.

[davidfowl]

Instead of doing this:

kestrelServerOptions.ApplicationServices = new ServiceCollection()
                                                         .AddLogging()
                                                         .BuildServiceProvider();

Implement a custom IServiceProvider that does this:

private class ServiceProvider : IServiceProvider
        {
            public object GetService(Type serviceType)
            {
                if (serviceType == typeof(ILoggerFactory))
                {
                    return NullLoggerFactory.Instance;
                }

                return null;
            }
        }

[LLT21]

Will this avoid then using the dependency injection ? Because that seems to be the problem to natively compile without reflection.

…

On 11 Apr 2021, at 17:29, David Fowler ***@***.***> wrote: Instead of doing this: kestrelServerOptions.ApplicationServices = new ServiceCollection() .AddLogging() .BuildServiceProvider(); Implement a custom IServiceProvider that does this: private class ServiceProvider : IServiceProvider { public object GetService(Type serviceType) { if (serviceType == typeof(ILoggerFactory)) { return NullLoggerFactory.Instance; } return null; } } — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#31561 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKO6WGESLP4MJTLRZ432EGTTIG56VANCNFSM42O4F65Q>.

[davidfowl]

Will this avoid then using the dependency injection ? Because that seems to be the problem to natively compile without reflection.

Yes, you're basically implementing your own IServiceProvider and it can do whatever you want. Like manually create objects.

[LLT21]

I will try later today. Thanks.

…

On 11 Apr 2021, at 17:32, David Fowler ***@***.***> wrote: Will this avoid then using the dependency injection ? Because that seems to be the problem to natively compile without reflection. Yes, you're basically implementing your own IServiceProvider and it can do whatever you want. Like manually create objects. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#31561 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKO6WGGOYAZLK6HCXQRO263TIG6I7ANCNFSM42O4F65Q>.

[davidfowl]

You can use the HttpContext directly in your application as well. You might want to use something like https://github.com/benaadams/Ben.Http which wraps these Kestrel APIs and lets you create the server directly.

cc @benaadams you might need to test https with your server,