Skip to content

Commit ffb399b

Browse files
committed
Removing unnecesary implementations and fixing public api
1 parent 7710230 commit ffb399b

File tree

5 files changed

+4
-25
lines changed

5 files changed

+4
-25
lines changed

src/Antiforgery/test/DefaultAntiforgeryTokenStoreTest.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -491,11 +491,6 @@ public void Append(string key, string value)
491491
throw new NotImplementedException();
492492
}
493493

494-
public void Append(ReadOnlySpan<KeyValuePair<string, string>> keyValuePairs, CookieOptions options)
495-
{
496-
throw new NotImplementedException();
497-
}
498-
499494
public void Delete(string key, CookieOptions options)
500495
{
501496
throw new NotImplementedException();

src/Http/Http.Features/src/IResponseCookies.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright (c) .NET Foundation. All rights reserved.
22
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
33

4-
#if NET6_0
4+
#if NET6_0_OR_GREATER
55
using System;
66
using System.Collections.Generic;
77
#endif
@@ -28,7 +28,7 @@ public interface IResponseCookies
2828
/// <param name="options"><see cref="CookieOptions"/> included in the new cookie setting.</param>
2929
void Append(string key, string value, CookieOptions options);
3030

31-
#if NET6_0
31+
#if NET6_0_OR_GREATER
3232
/// <summary>
3333
/// Add elements of specified dictionary as cookies.
3434
/// </summary>

src/Http/Http.Features/src/PublicAPI.Unshipped.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,6 @@ Microsoft.AspNetCore.Http.Features.IFeatureCollection.Set<TFeature>(TFeature? in
1515
Microsoft.AspNetCore.Http.Features.IServerVariablesFeature.this[string! variableName].get -> string?
1616
Microsoft.AspNetCore.Http.ISession.TryGetValue(string! key, out byte[]? value) -> bool
1717
Microsoft.AspNetCore.Http.Features.FeatureCollection.FeatureCollection(int initialCapacity) -> void
18+
#if NET6_0_OR_GREATER
1819
Microsoft.AspNetCore.Http.IResponseCookies.Append(System.ReadOnlySpan<System.Collections.Generic.KeyValuePair<string!, string!>> keyValuePairs, Microsoft.AspNetCore.Http.CookieOptions! options) -> void
20+
#endif

src/Mvc/Mvc.ViewFeatures/test/CookieTempDataProviderTest.cs

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -416,19 +416,6 @@ IEnumerator IEnumerable.GetEnumerator()
416416
{
417417
return GetEnumerator();
418418
}
419-
420-
public void Append(ReadOnlySpan<KeyValuePair<string, string>> keyValuePairs, CookieOptions options)
421-
{
422-
foreach (var keyValuePair in keyValuePairs)
423-
{
424-
_cookies[keyValuePair.Key] = new CookieInfo()
425-
{
426-
Key = keyValuePair.Key,
427-
Value = keyValuePair.Value,
428-
Options = options
429-
};
430-
}
431-
}
432419
}
433420

434421
private CookieTempDataProvider GetProvider(IDataProtector dataProtector = null, CookieTempDataProviderOptions options = null)

src/Security/CookiePolicy/test/CookiePolicyTests.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -486,11 +486,6 @@ public void Append(string key, string value, CookieOptions options)
486486
throw new NotImplementedException();
487487
}
488488

489-
public void Append(ReadOnlySpan<KeyValuePair<string, string>> keyValuePairs, CookieOptions options)
490-
{
491-
throw new NotImplementedException();
492-
}
493-
494489
public void Delete(string key)
495490
{
496491
throw new NotImplementedException();

0 commit comments

Comments
 (0)