Remove unnecessary null check in SignInManager (#29580)

badrshs · web-flow · commit fdc88228cfa7 · 2021-01-25T14:41:06.000-08:00
diff --git a/src/Identity/Core/src/SignInManager.cs b/src/Identity/Core/src/SignInManager.cs
@@ -129,7 +129,7 @@ public virtual bool IsSignedIn(ClaimsPrincipal principal)
             {
                 throw new ArgumentNullException(nameof(principal));
             }
-            return principal?.Identities != null &&
+            return principal.Identities != null &&
                 principal.Identities.Any(i => i.AuthenticationType == IdentityConstants.ApplicationScheme);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ public virtual bool IsSignedIn(ClaimsPrincipal principal)`
`129`	`129`	`{`
`130`	`130`	`throw new ArgumentNullException(nameof(principal));`
`131`	`131`	`}`
`132`		`- return principal?.Identities != null &&`
	`132`	`+ return principal.Identities != null &&`
`133`	`133`	`principal.Identities.Any(i => i.AuthenticationType == IdentityConstants.ApplicationScheme);`
`134`	`134`	`}`
`135`	`135`