Optimize _MvcCopyDependencyFiles and _GeneratePublishTestManifest targets to reduce Copy task overhead (#63994)

* Initial plan

* Optimize _MvcCopyDependencyFiles target to reduce Copy task invocations

Co-authored-by: joperezr <[email protected]>

* Also optimize _GeneratePublishTestManifest target for consistency

Co-authored-by: joperezr <[email protected]>

* Fix MSBuild item list handling and condition syntax per review feedback

- Use new item list _DepsFilesToPublishResolved from FullPath metadata instead of overwriting _DepsFileToPublish
- Change condition syntax from '@(list) != empty' to '@(list->Count()) > 0' to avoid list rendering overhead

Co-authored-by: baronfel <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: joperezr <[email protected]>
Co-authored-by: baronfel <[email protected]>

Author: 3 people

src/Mvc/Mvc.Testing/src/Microsoft.AspNetCore.Mvc.Testing.targets

@@ -55,7 +55,12 @@
     </ItemGroup>
 
     <GenerateMvcTestManifestTask ManifestPath="$(PublishDir)MvcTestingAppManifest.json" Projects="@(_PublishManifestProjects)" />
-    <Copy SourceFiles="%(_DepsFileToPublish.FullPath)" DestinationFolder="$(PublishDir)" Condition="Exists('%(_DepsFileToPublish.FullPath)')" />
+    
+    <ItemGroup>
+      <_DepsFilesToPublishResolved Include="%(_DepsFileToPublish.FullPath)" Condition="Exists('%(_DepsFileToPublish.FullPath)')" />
+    </ItemGroup>
+    
+    <Copy SourceFiles="@(_DepsFilesToPublishResolved)" DestinationFolder="$(PublishDir)" SkipUnchangedFiles="true" Condition="@(_DepsFilesToPublishResolved->Count()) > 0" />
   </Target>
 
   <Target Name="_MvcCopyDependencyFiles" AfterTargets="Build;_ResolveMvcTestProjectReferences" Condition="'$(TargetFramework)'!=''">
@@ -70,11 +75,16 @@
         <_CreateSymbolicLinksForMvcCopyDependencyFilesIfPossible Condition="'$(_CreateSymbolicLinksMvcCopyDependencyFilesIfPossible)' == ''">$(CreateSymbolicLinksForCopyFilesToOutputDirectoryIfPossible)</_CreateSymbolicLinksForMvcCopyDependencyFilesIfPossible>
     </PropertyGroup>
 
-    <Copy SourceFiles="%(DepsFilePaths.FullPath)"
+    <ItemGroup>
+      <_DepsFilesToCopy Include="@(DepsFilePaths)" Condition="Exists('%(DepsFilePaths.FullPath)')" />
+    </ItemGroup>
+
+    <Copy SourceFiles="@(_DepsFilesToCopy)"
        DestinationFolder="$(OutDir)"
        UseHardlinksIfPossible="$(_CreateHardLinksForMvcCopyDependencyFilesIfPossible)"
        UseSymboliclinksIfPossible="$(_CreateSymbolicLinksForMvcCopyDependencyFilesIfPossible)"
-       Condition="Exists('%(DepsFilePaths.FullPath)')" />
+       SkipUnchangedFiles="true"
+       Condition="@(_DepsFilesToCopy->Count()) > 0" />
   </Target>
 
 </Project>