Update SslProtocols to use system defaults

John Luo · John Luo · commit f7e3fac1ed47 · 2020-06-15T15:07:01.000-07:00
diff --git a/src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsTests.cs b/src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsTests.cs
@@ -203,7 +203,7 @@ public async Task DoesNotThrowObjectDisposedExceptionOnConnectionAbort()
                 using (var sslStream = new SslStream(connection.Stream, true, (sender, certificate, chain, errors) => true))
                 {
                     await sslStream.AuthenticateAsClientAsync("127.0.0.1", clientCertificates: null,
-                        enabledSslProtocols: SslProtocols.Tls11 | SslProtocols.Tls12,
+                        enabledSslProtocols: SslProtocols.None,
                         checkCertificateRevocation: false);
 
                     var request = Encoding.ASCII.GetBytes("GET / HTTP/1.1\r\nHost:\r\n\r\n");
@@ -279,7 +279,7 @@ public async Task DoesNotThrowObjectDisposedExceptionOnEmptyConnection()
                 using (var sslStream = new SslStream(connection.Stream, true, (sender, certificate, chain, errors) => true))
                 {
                     await sslStream.AuthenticateAsClientAsync("127.0.0.1", clientCertificates: null,
-                        enabledSslProtocols: SslProtocols.Tls11 | SslProtocols.Tls12,
+                        enabledSslProtocols: SslProtocols.None,
                         checkCertificateRevocation: false);
                 }
             }
diff --git a/src/Servers/Kestrel/test/InMemory.FunctionalTests/TestTransport/InMemoryHttpClientSlim.cs b/src/Servers/Kestrel/test/InMemory.FunctionalTests/TestTransport/InMemoryHttpClientSlim.cs
@@ -124,7 +124,7 @@ private static async Task<Stream> GetStream(Stream rawStream, Uri requestUri, bo
                     validateCertificate ? null : (RemoteCertificateValidationCallback)((a, b, c, d) => true));
 
                 await sslStream.AuthenticateAsClientAsync(requestUri.Host, clientCertificates: null,
-                    enabledSslProtocols: SslProtocols.Tls11 | SslProtocols.Tls12,
+                    enabledSslProtocols: SslProtocols.None,
                     checkCertificateRevocation: validateCertificate).ConfigureAwait(false);
                 return sslStream;
             }
diff --git a/src/Testing/src/HttpClientSlim.cs b/src/Testing/src/HttpClientSlim.cs
@@ -153,7 +153,7 @@ private static async Task<Stream> GetStream(Uri requestUri, bool validateCertifi
                     validateCertificate ? null : (RemoteCertificateValidationCallback)((a, b, c, d) => true));
 
                 await sslStream.AuthenticateAsClientAsync(requestUri.Host, clientCertificates: null,
-                    enabledSslProtocols: SslProtocols.Tls11 | SslProtocols.Tls12,
+                    enabledSslProtocols: SslProtocols.None,
                     checkCertificateRevocation: validateCertificate).ConfigureAwait(false);
                 return sslStream;
             }

Original file line number	Diff line number	Diff line change
`@@ -203,7 +203,7 @@ public async Task DoesNotThrowObjectDisposedExceptionOnConnectionAbort()`
`203`	`203`	`using (var sslStream = new SslStream(connection.Stream, true, (sender, certificate, chain, errors) => true))`
`204`	`204`	`{`
`205`	`205`	`await sslStream.AuthenticateAsClientAsync("127.0.0.1", clientCertificates: null,`
`206`		`- enabledSslProtocols: SslProtocols.Tls11 \| SslProtocols.Tls12,`
	`206`	`+ enabledSslProtocols: SslProtocols.None,`
`207`	`207`	`checkCertificateRevocation: false);`
`208`	`208`
`209`	`209`	`var request = Encoding.ASCII.GetBytes("GET / HTTP/1.1\r\nHost:\r\n\r\n");`
`@@ -279,7 +279,7 @@ public async Task DoesNotThrowObjectDisposedExceptionOnEmptyConnection()`
`279`	`279`	`using (var sslStream = new SslStream(connection.Stream, true, (sender, certificate, chain, errors) => true))`
`280`	`280`	`{`
`281`	`281`	`await sslStream.AuthenticateAsClientAsync("127.0.0.1", clientCertificates: null,`
`282`		`- enabledSslProtocols: SslProtocols.Tls11 \| SslProtocols.Tls12,`
	`282`	`+ enabledSslProtocols: SslProtocols.None,`
`283`	`283`	`checkCertificateRevocation: false);`
`284`	`284`	`}`
`285`	`285`	`}`
Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ private static async Task<Stream> GetStream(Stream rawStream, Uri requestUri, bo`
`124`	`124`	`validateCertificate ? null : (RemoteCertificateValidationCallback)((a, b, c, d) => true));`
`125`	`125`
`126`	`126`	`await sslStream.AuthenticateAsClientAsync(requestUri.Host, clientCertificates: null,`
`127`		`- enabledSslProtocols: SslProtocols.Tls11 \| SslProtocols.Tls12,`
	`127`	`+ enabledSslProtocols: SslProtocols.None,`
`128`	`128`	`checkCertificateRevocation: validateCertificate).ConfigureAwait(false);`
`129`	`129`	`return sslStream;`
`130`	`130`	`}`
Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ private static async Task<Stream> GetStream(Uri requestUri, bool validateCertifi`
`153`	`153`	`validateCertificate ? null : (RemoteCertificateValidationCallback)((a, b, c, d) => true));`
`154`	`154`
`155`	`155`	`await sslStream.AuthenticateAsClientAsync(requestUri.Host, clientCertificates: null,`
`156`		`- enabledSslProtocols: SslProtocols.Tls11 \| SslProtocols.Tls12,`
	`156`	`+ enabledSslProtocols: SslProtocols.None,`
`157`	`157`	`checkCertificateRevocation: validateCertificate).ConfigureAwait(false);`
`158`	`158`	`return sslStream;`
`159`	`159`	`}`