An attempt to fix database error page tests (#25978)

jkotalik · web-flow · commit ecaf78672a68 · 2020-09-16T17:42:35.000-07:00
diff --git a/src/Middleware/Diagnostics.EntityFrameworkCore/test/FunctionalTests/DatabaseErrorPageMiddlewareTest.cs b/src/Middleware/Diagnostics.EntityFrameworkCore/test/FunctionalTests/DatabaseErrorPageMiddlewareTest.cs
@@ -398,10 +398,10 @@ public async Task Pass_thru_when_context_not_in_services()
 
             await host.StartAsync();
 
-            var server = host.GetTestServer();
 
             try
             {
+                using var server = host.GetTestServer();
                 await server.CreateClient().GetAsync("http://localhost/");
             }
             catch (Exception exception)
@@ -446,10 +446,10 @@ public async Task Pass_thru_when_exception_in_logic()
                 var logProvider = new TestLoggerProvider();
 
                 using var host = await SetupServer<BloggingContextWithSnapshotThatThrows, ExceptionInLogicMiddleware>(database, logProvider);
-                using var server = host.GetTestServer();
 
                 try
                 {
+                    using var server = host.GetTestServer();
                     await server.CreateClient().GetAsync("http://localhost/");
                 }
                 catch (Exception exception)

Original file line number	Diff line number	Diff line change
`@@ -398,10 +398,10 @@ public async Task Pass_thru_when_context_not_in_services()`
`398`	`398`
`399`	`399`	`await host.StartAsync();`
`400`	`400`
`401`		`- var server = host.GetTestServer();`
`402`	`401`
`403`	`402`	`try`
`404`	`403`	`{`
	`404`	`+ using var server = host.GetTestServer();`
`405`	`405`	`await server.CreateClient().GetAsync("http://localhost/");`
`406`	`406`	`}`
`407`	`407`	`catch (Exception exception)`
`@@ -446,10 +446,10 @@ public async Task Pass_thru_when_exception_in_logic()`
`446`	`446`	`var logProvider = new TestLoggerProvider();`
`447`	`447`
`448`	`448`	`using var host = await SetupServer<BloggingContextWithSnapshotThatThrows, ExceptionInLogicMiddleware>(database, logProvider);`
`449`		`- using var server = host.GetTestServer();`
`450`	`449`
`451`	`450`	`try`
`452`	`451`	`{`
	`452`	`+ using var server = host.GetTestServer();`
`453`	`453`	`await server.CreateClient().GetAsync("http://localhost/");`
`454`	`454`	`}`
`455`	`455`	`catch (Exception exception)`