Fill in logging

Author: amcasey

src/Shared/CertificateGeneration/CertificateManager.cs

@@ -1075,6 +1075,9 @@ public sealed class CertificateManagerEventSource : EventSource
 
         [Event(71, Level = EventLevel.Warning, Message = "The on-disk store directory was not found.")]
         internal void MacOSDiskStoreDoesNotExist() => WriteEvent(71);
+
+        [Event(72, Level = EventLevel.Warning, Message = "Directory '{0}' may be readable by other users.")]
+        internal void DirectoryPermissionsNotSecure(string directoryPath) => WriteEvent(72, directoryPath);
     }
 
     internal sealed class UserCancelledTrustException : Exception

src/Shared/CertificateGeneration/MacOSCertificateManager.cs

@@ -487,7 +487,7 @@ protected override void CreateDirectoryWithPermissions(string directoryPath)
         {
             if ((dirInfo.UnixFileMode & ~DirectoryPermissions) != 0)
             {
-                // TODO (acasey): Log.DirectoryPermissionsNotSecure(dirInfo.FullName);
+                Log.DirectoryPermissionsNotSecure(dirInfo.FullName);
             }
         }
         else

src/Shared/CertificateGeneration/UnixCertificateManager.cs

@@ -80,7 +80,7 @@ protected override void CreateDirectoryWithPermissions(string directoryPath)
         {
             if ((dirInfo.UnixFileMode & ~DirectoryPermissions) != 0)
             {
-                // TODO (acasey): Log.DirectoryPermissionsNotSecure(dirInfo.FullName);
+                Log.DirectoryPermissionsNotSecure(dirInfo.FullName);
             }
         }
         else

src/Shared/CertificateGeneration/WindowsCertificateManager.cs

@@ -158,7 +158,7 @@ protected override void CreateDirectoryWithPermissions(string directoryPath)
                 // is to allow access to anyone other than the current user, system, or administrators
                 // is very complicated.  We're not going to do anything but log, so an approximation
                 // is fine.
-                // TODO (acasey): Log.DirectoryPermissionsNotSecure(dirInfo.FullName);
+                Log.DirectoryPermissionsNotSecure(dirInfo.FullName);
                 break;
             }
         }