Remove PortablePdbReader except trace cleanup (#19957)

* Remove PortablePdbReader except trace cleanup

Co-authored-by: Rowse <[email protected]>

Author: RozzaysRed

src/Shared/StackTrace/StackFrame/PortablePdbReader.cs

@@ -25,70 +25,48 @@ public static IList<StackFrameInfo> GetFrames(Exception exception, out Aggregate
                 return frames;
             }
 
-            using (var portablePdbReader = new PortablePdbReader())
+            var needFileInfo = true;
+            var stackTrace = new System.Diagnostics.StackTrace(exception, needFileInfo);
+            var stackFrames = stackTrace.GetFrames();
+
+            if (stackFrames == null)
             {
-                var needFileInfo = true;
-                var stackTrace = new System.Diagnostics.StackTrace(exception, needFileInfo);
-                var stackFrames = stackTrace.GetFrames();
+                error = default;
+                return frames;
+            }
 
-                if (stackFrames == null)
-                {
-                    error = default;
-                    return frames;
-                }
+            List<Exception> exceptions = null;
 
-                List<Exception> exceptions = null;
+            for (var i = 0; i < stackFrames.Length; i++)
+            {
+                var frame = stackFrames[i];
+                var method = frame.GetMethod();
 
-                for (var i = 0; i < stackFrames.Length; i++)
+                // Always show last stackFrame
+                if (!ShowInStackTrace(method) && i < stackFrames.Length - 1)
                 {
-                    var frame = stackFrames[i];
-                    var method = frame.GetMethod();
-
-                    // Always show last stackFrame
-                    if (!ShowInStackTrace(method) && i < stackFrames.Length - 1)
-                    {
-                        continue;
-                    }
-
-                    var stackFrame = new StackFrameInfo
-                    {
-                        StackFrame = frame,
-                        FilePath = frame.GetFileName(),
-                        LineNumber = frame.GetFileLineNumber(),
-                        MethodDisplayInfo = GetMethodDisplayString(frame.GetMethod()),
-                    };
-
-                    if (string.IsNullOrEmpty(stackFrame.FilePath))
-                    {
-                        try
-                        {
-                            // .NET Framework and older versions of mono don't support portable PDBs
-                            // so we read it manually to get file name and line information
-                            portablePdbReader.PopulateStackFrame(stackFrame, method, frame.GetILOffset());
-                        }
-                        catch (Exception ex)
-                        {
-                            if (exceptions is null)
-                            {
-                                exceptions = new List<Exception>();
-                            }
-
-                            exceptions.Add(ex);
-                        }
-                    }
-
-                    frames.Add(stackFrame);
+                    continue;
                 }
 
-                if (exceptions != null)
+                var stackFrame = new StackFrameInfo
                 {
-                    error = new AggregateException(exceptions);
-                    return frames;
-                }
+                    StackFrame = frame,
+                    FilePath = frame.GetFileName(),
+                    LineNumber = frame.GetFileLineNumber(),
+                    MethodDisplayInfo = GetMethodDisplayString(frame.GetMethod()),
+                };
 
-                error = default;
+                frames.Add(stackFrame);
+            }
+
+            if (exceptions != null)
+            {
+                error = new AggregateException(exceptions);
                 return frames;
             }
+
+            error = default;
+            return frames;
         }
 
         internal static MethodDisplayInfo GetMethodDisplayString(MethodBase method)