HTTP/3: Fix tests to skip TLS name validation (#34688)

Author: JamesNK

src/Servers/Kestrel/Transport.Quic/test/WebHostTests.cs

@@ -54,7 +54,7 @@ public async Task UseUrls_HelloWorld_ClientSuccess()
                 .ConfigureServices(AddTestLogging);
 
             using (var host = builder.Build())
-            using (var client = new HttpClient())
+            using (var client = CreateClient())
             {
                 await host.StartAsync();
 
@@ -183,10 +183,7 @@ public async Task Listen_Http3AndSocketsCoexistOnSameEndpoint_AltSvcEnabled_Upgr
             using var host = builder.Build();
             await host.StartAsync().DefaultTimeout();
 
-            var httpClientHandler = new HttpClientHandler();
-            httpClientHandler.ServerCertificateCustomValidationCallback = HttpClientHandler.DangerousAcceptAnyServerCertificateValidator;
-
-            using (var client = new HttpClient(httpClientHandler))
+            using (var client = CreateClient())
             {
                 // Act
                 var request1 = new HttpRequestMessage(HttpMethod.Get, $"https://127.0.0.1:{host.GetPort()}/");
@@ -221,43 +218,44 @@ public async Task Listen_Http3AndSocketsCoexistOnSameEndpoint_AltSvcEnabled_Upgr
 
         private static async Task CallHttp3AndHttp1EndpointsAsync(int http3Port, int http1Port)
         {
-            // HTTP/3
-            using (var client = new HttpClient())
+            using (var client = CreateClient())
             {
-                var request = new HttpRequestMessage(HttpMethod.Get, $"https://127.0.0.1:{http3Port}/");
-                request.Version = HttpVersion.Version30;
-                request.VersionPolicy = HttpVersionPolicy.RequestVersionExact;
+                // HTTP/3
+                var request1 = new HttpRequestMessage(HttpMethod.Get, $"https://127.0.0.1:{http3Port}/");
+                request1.Version = HttpVersion.Version30;
+                request1.VersionPolicy = HttpVersionPolicy.RequestVersionExact;
 
                 // Act
-                var response = await client.SendAsync(request).DefaultTimeout();
+                var response1 = await client.SendAsync(request1).DefaultTimeout();
 
                 // Assert
-                response.EnsureSuccessStatusCode();
-                Assert.Equal(HttpVersion.Version30, response.Version);
-                var responseText = await response.Content.ReadAsStringAsync().DefaultTimeout();
-                Assert.Equal("hello, world", responseText);
-            }
-
-            // HTTP/1.1
-            var httpClientHandler = new HttpClientHandler();
-            httpClientHandler.ServerCertificateCustomValidationCallback = HttpClientHandler.DangerousAcceptAnyServerCertificateValidator;
+                response1.EnsureSuccessStatusCode();
+                Assert.Equal(HttpVersion.Version30, response1.Version);
+                var responseText1 = await response1.Content.ReadAsStringAsync().DefaultTimeout();
+                Assert.Equal("hello, world", responseText1);
 
-            using (var client = new HttpClient(httpClientHandler))
-            {
                 // HTTP/1.1
-                var request = new HttpRequestMessage(HttpMethod.Get, $"https://127.0.0.1:{http1Port}/");
+                var request2 = new HttpRequestMessage(HttpMethod.Get, $"https://127.0.0.1:{http1Port}/");
 
                 // Act
-                var response = await client.SendAsync(request).DefaultTimeout();
+                var response2 = await client.SendAsync(request2).DefaultTimeout();
 
                 // Assert
-                response.EnsureSuccessStatusCode();
-                Assert.Equal(HttpVersion.Version11, response.Version);
-                var responseText = await response.Content.ReadAsStringAsync().DefaultTimeout();
-                Assert.Equal("hello, world", responseText);
+                response2.EnsureSuccessStatusCode();
+                Assert.Equal(HttpVersion.Version11, response2.Version);
+                var responseText2 = await response2.Content.ReadAsStringAsync().DefaultTimeout();
+                Assert.Equal("hello, world", responseText2);
             }
         }
 
+        private static HttpClient CreateClient()
+        {
+            var httpHandler = new HttpClientHandler();
+            httpHandler.ServerCertificateCustomValidationCallback = HttpClientHandler.DangerousAcceptAnyServerCertificateValidator;
+
+            return new HttpClient(httpHandler);
+        }
+
         public static IHostBuilder GetHostBuilder(long? maxReadBufferSize = null)
         {
             return new HostBuilder()

src/Servers/Kestrel/test/Interop.FunctionalTests/Http3/Http3RequestTests.cs

@@ -75,7 +75,7 @@ public async Task POST_ServerCompletsWithoutReadingRequestBody_ClientGetsRespons
             });
 
             using (var host = builder.Build())
-            using (var client = new HttpClient())
+            using (var client = CreateClient())
             {
                 await host.StartAsync();
 
@@ -130,7 +130,7 @@ public async Task GET_MultipleRequestsInSequence_ReusedState()
             });
 
             using (var host = builder.Build())
-            using (var client = new HttpClient())
+            using (var client = CreateClient())
             {
                 await host.StartAsync();
 
@@ -186,7 +186,7 @@ public async Task GET_ConnectionLoggingConfigured_OutputToLogs()
                 });
 
             using (var host = builder.Build())
-            using (var client = new HttpClient())
+            using (var client = CreateClient())
             {
                 await host.StartAsync();
 
@@ -215,6 +215,14 @@ public async Task GET_ConnectionLoggingConfigured_OutputToLogs()
             }
         }
 
+        private static HttpClient CreateClient()
+        {
+            var httpHandler = new HttpClientHandler();
+            httpHandler.ServerCertificateCustomValidationCallback = HttpClientHandler.DangerousAcceptAnyServerCertificateValidator;
+
+            return new HttpClient(httpHandler);
+        }
+
         private IHostBuilder CreateHttp3HostBuilder(RequestDelegate requestDelegate, Action<KestrelServerOptions> configureKestrel = null)
         {
             return GetHostBuilder()