Port Resolve C26496 compiler errors when building in release mode with VS 15.9 (#4141)

pakrym · web-flow · commit d17392bc451b · 2018-11-20T10:00:37.000-08:00
diff --git a/src/IISIntegration/src/AspNetCoreModuleV2/AspNetCore/applicationinfo.cpp b/src/IISIntegration/src/AspNetCoreModuleV2/AspNetCore/applicationinfo.cpp
@@ -106,7 +106,7 @@ APPLICATION_INFO::CreateApplication(IHttpContext& pHttpContext)
             }
             return S_OK;
         }
-        catch (ConfigurationLoadException &ex)
+        catch (const ConfigurationLoadException &ex)
         {
             EventLog::Error(
                 ASPNETCORE_CONFIGURATION_LOAD_ERROR,
diff --git a/src/IISIntegration/src/AspNetCoreModuleV2/CommonLib/BaseOutputManager.h b/src/IISIntegration/src/AspNetCoreModuleV2/CommonLib/BaseOutputManager.h
@@ -55,7 +55,7 @@ class BaseOutputManager :
         {
             func();
         }
-        catch (std::runtime_error& exception)
+        catch (const std::runtime_error& exception)
         {
             EventLog::Warn(ASPNETCORE_EVENT_GENERAL_WARNING, exceptionMessage.c_str(), GetModuleName().c_str(), to_wide_string(exception.what(), GetConsoleOutputCP()).c_str());
         }

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ APPLICATION_INFO::CreateApplication(IHttpContext& pHttpContext)`
`106`	`106`	`}`
`107`	`107`	`return S_OK;`
`108`	`108`	`}`
`109`		`- catch (ConfigurationLoadException &ex)`
	`109`	`+ catch (const ConfigurationLoadException &ex)`
`110`	`110`	`{`
`111`	`111`	`EventLog::Error(`
`112`	`112`	`ASPNETCORE_CONFIGURATION_LOAD_ERROR,`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ class BaseOutputManager :`
`55`	`55`	`{`
`56`	`56`	`func();`
`57`	`57`	`}`
`58`		`- catch (std::runtime_error& exception)`
	`58`	`+ catch (const std::runtime_error& exception)`
`59`	`59`	`{`
`60`	`60`	`EventLog::Warn(ASPNETCORE_EVENT_GENERAL_WARNING, exceptionMessage.c_str(), GetModuleName().c_str(), to_wide_string(exception.what(), GetConsoleOutputCP()).c_str());`
`61`	`61`	`}`