Add tests for register + confirm flow

Author: HaoK

src/Identity/UI/src/Areas/Identity/Pages/V3/Account/RegisterConfirmation.cshtml

@@ -10,7 +10,7 @@
     {
 <p>
     This app does not currently have a real email sender registered, see <a href="https://docs.microsoft.com/en-us/aspnet/core/security/authentication/accconfirm">these docs</a> for how to configure a real email sender.
-    Normally this would be emailed: <a href="@Model.EmailConfirmationUrl">Click here to confirm your account</a>
+    Normally this would be emailed: <a id="confirm-link" href="@Model.EmailConfirmationUrl">Click here to confirm your account</a>
 </p>
     }
     else

src/Identity/UI/src/Areas/Identity/Pages/V4/Account/RegisterConfirmation.cshtml

@@ -10,7 +10,7 @@
     {
 <p>
     This app does not currently have a real email sender registered, see <a href="https://docs.microsoft.com/en-us/aspnet/core/security/authentication/accconfirm">these docs</a> for how to configure a real email sender.
-    Normally this would be emailed: <a href="@Model.EmailConfirmationUrl">Click here to confirm your account</a>
+    Normally this would be emailed: <a id="confirm-link" href="@Model.EmailConfirmationUrl">Click here to confirm your account</a>
 </p>
     }
     else

src/Identity/test/Identity.FunctionalTests/Infrastructure/DefaultUIContext.cs

@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
@@ -35,6 +35,9 @@ internal DefaultUIContext WithPasswordLogin() =>
         internal DefaultUIContext WithCookieConsent() =>
             new DefaultUIContext(this) { CookiePolicyAccepted = true };
 
+        internal DefaultUIContext WithRealEmailSender() =>
+            new DefaultUIContext(this) { HasRealEmailSender = true };
+
         public string AuthenticatorKey
         {
             get => GetValue<string>(nameof(AuthenticatorKey));
@@ -93,5 +96,11 @@ public bool CookiePolicyAccepted
             get => GetValue<bool>(nameof(CookiePolicyAccepted));
             set => SetValue(nameof(CookiePolicyAccepted), value);
         }
+
+        public bool HasRealEmailSender
+        {
+            get => GetValue<bool>(nameof(HasRealEmailSender));
+            set => SetValue(nameof(HasRealEmailSender), value);
+        }
     }
 }

src/Identity/test/Identity.FunctionalTests/Pages/Account/Register.cs

@@ -53,5 +53,22 @@ public async Task<Index> SubmitRegisterFormForValidUserAsync(string userName, st
 
             return new Index(Client, index, Context.WithAuthenticatedUser());
         }
+
+        public async Task<RegisterConfirmation> SubmitRegisterFormWithConfirmation(string userName, string password, bool hasRealEmail = false)
+        {
+            var registered = await Client.SendAsync(_registerForm, new Dictionary<string, string>()
+            {
+                ["Input_Email"] = userName,
+                ["Input_Password"] = password,
+                ["Input_ConfirmPassword"] = password
+            });
+
+            var registeredLocation = ResponseAssert.IsRedirect(registered);
+            Assert.Equal(RegisterConfirmation.Path + "?email="+userName, registeredLocation.ToString());
+            var registerResponse = await Client.GetAsync(registeredLocation);
+            var register = await ResponseAssert.IsHtmlDocumentAsync(registerResponse);
+
+            return new RegisterConfirmation(Client, register, hasRealEmail ? Context.WithRealEmailSender() : Context);
+        }
     }
 }

src/Identity/test/Identity.FunctionalTests/Pages/Index.cs

@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System.Net.Http;

src/Identity/test/Identity.FunctionalTests/Pages/RegisterConfirmation.cs

@@ -0,0 +1,41 @@
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+using System.Net.Http;
+using System.Threading.Tasks;
+using AngleSharp.Dom.Html;
+using Microsoft.AspNetCore.Identity.FunctionalTests.Account;
+using Xunit;
+
+namespace Microsoft.AspNetCore.Identity.FunctionalTests
+{
+    public class RegisterConfirmation : DefaultUIPage
+    {
+        private readonly IHtmlAnchorElement _confirmLink;
+        public static readonly string Path = "/Identity/Account/RegisterConfirmation";
+
+        public RegisterConfirmation(
+            HttpClient client,
+            IHtmlDocument register,
+            DefaultUIContext context)
+            : base(client, register, context)
+        {
+            if (Context.HasRealEmailSender)
+            {
+                Assert.Empty(Document.QuerySelectorAll("#confirm-link"));
+            }
+            else
+            {
+                _confirmLink = HtmlAssert.HasLink("#confirm-link", Document);
+            }
+        }
+
+        public async Task<ConfirmEmail> ClickConfirmLinkAsync()
+        {
+            var goToConfirm = await Client.GetAsync(_confirmLink.Href);
+            var confirm = await ResponseAssert.IsHtmlDocumentAsync(goToConfirm);
+
+            return await ConfirmEmail.Create(_confirmLink, Client, Context);
+        }
+    }
+}

src/Identity/test/Identity.FunctionalTests/RegistrationTests.cs

@@ -3,6 +3,7 @@
 
 using System;
 using System.Threading.Tasks;
+using Microsoft.AspNetCore.Identity.UI.Services;
 using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.DependencyInjection;
 using Xunit;
@@ -37,6 +38,59 @@ public async Task CanRegisterAUser()
             await UserStories.RegisterNewUserAsync(client, userName, password);
         }
 
+        [Fact]
+        public async Task CanRegisterAUserWithRequiredConfirmation()
+        {
+            // Arrange
+            void ConfigureTestServices(IServiceCollection services) { services.Configure<IdentityOptions>(o => o.SignIn.RequireConfirmedAccount = true); };
+
+            var server = ServerFactory
+                    .WithWebHostBuilder(whb => whb.ConfigureServices(ConfigureTestServices));
+            var client = server.CreateClient();
+            var client2 = server.CreateClient();
+
+            var userName = $"{Guid.NewGuid()}@example.com";
+            var password = $"!Test.Password1$";
+
+            // Act & Assert
+            var register = await UserStories.RegisterNewUserAsyncWithConfirmation(client, userName, password);
+
+            // Since we aren't confirmed yet, login should fail until we confirm
+            await UserStories.LoginFailsWithWrongPasswordAsync(client, userName, password);
+            await register.ClickConfirmLinkAsync();
+            await UserStories.LoginExistingUserAsync(client, userName, password);
+        }
+
+        private class FakeEmailSender : IEmailSender
+        {
+            public Task SendEmailAsync(string email, string subject, string htmlMessage)
+                => Task.CompletedTask;
+        }
+
+        [Fact]
+        public async Task RegisterWithRealConfirmationDoesNotShowLink()
+        {
+            // Arrange
+            void ConfigureTestServices(IServiceCollection services) {
+                services.Configure<IdentityOptions>(o => o.SignIn.RequireConfirmedAccount = true);
+                services.AddSingleton<IEmailSender, FakeEmailSender>();
+            };
+
+            var server = ServerFactory
+                    .WithWebHostBuilder(whb => whb.ConfigureServices(ConfigureTestServices));
+            var client = server.CreateClient();
+            var client2 = server.CreateClient();
+
+            var userName = $"{Guid.NewGuid()}@example.com";
+            var password = $"!Test.Password1$";
+
+            // Act & Assert
+            var register = await UserStories.RegisterNewUserAsyncWithConfirmation(client, userName, password, hasRealEmailSender: true);
+
+            // Since we aren't confirmed yet, login should fail until we confirm
+            await UserStories.LoginFailsWithWrongPasswordAsync(client, userName, password);
+        }
+
         [Fact]
         public async Task CanRegisterAUser_WithGlobalAuthorizeFilter()
         {

src/Identity/test/Identity.FunctionalTests/UserStories.cs

@@ -27,6 +27,17 @@ internal static async Task<Index> RegisterNewUserAsync(HttpClient client, string
             return await register.SubmitRegisterFormForValidUserAsync(userName, password);
         }
 
+        internal static async Task<RegisterConfirmation> RegisterNewUserAsyncWithConfirmation(HttpClient client, string userName = null, string password = null, bool hasRealEmailSender = false)
+        {
+            userName = userName ?? $"{Guid.NewGuid()}@example.com";
+            password = password ?? $"!Test.Password1$";
+
+            var index = await Index.CreateAsync(client);
+            var register = await index.ClickRegisterLinkAsync();
+
+            return await register.SubmitRegisterFormWithConfirmation(userName, password, hasRealEmailSender);
+        }
+
 
         internal static async Task<Index> LoginExistingUserAsync(HttpClient client, string userName, string password)
         {