Remove Blazor internal profiling infrastructure (#24468) (#24589)

* Put back InternalCalls

* Removing .NET profiling calls

* Remove JS side profiling

Co-authored-by: Steve Sanderson <[email protected]>

Author: pranavkm

src/Components/Components/src/Microsoft.AspNetCore.Components.csproj

@@ -10,7 +10,6 @@
 
   <ItemGroup>
     <Compile Include="$(ComponentsSharedSourceRoot)src\ArrayBuilder.cs" LinkBase="RenderTree" />
-    <Compile Include="$(ComponentsSharedSourceRoot)src\WebAssemblyJSInteropInternalCalls.cs" />
   </ItemGroup>
 
   <ItemGroup>

src/Components/Components/src/Profiling/ComponentsProfiling.cs

@@ -7,7 +7,6 @@
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Runtime.CompilerServices;
-using Microsoft.AspNetCore.Components.Profiling;
 using Microsoft.AspNetCore.Components.Rendering;
 
 namespace Microsoft.AspNetCore.Components.RenderTree
@@ -28,7 +27,6 @@ public static RenderTreeDiff ComputeDiff(
             ArrayRange<RenderTreeFrame> oldTree,
             ArrayRange<RenderTreeFrame> newTree)
         {
-            ComponentsProfiling.Instance.Start();
             var editsBuffer = batchBuilder.EditsBuffer;
             var editsBufferStartLength = editsBuffer.Count;
 
@@ -37,7 +35,6 @@ public static RenderTreeDiff ComputeDiff(
 
             var editsSegment = editsBuffer.ToSegment(editsBufferStartLength, editsBuffer.Count);
             var result = new RenderTreeDiff(componentId, editsSegment);
-            ComponentsProfiling.Instance.End();
             return result;
         }
 
@@ -49,7 +46,6 @@ private static void AppendDiffEntriesForRange(
             int oldStartIndex, int oldEndIndexExcl,
             int newStartIndex, int newEndIndexExcl)
         {
-            ProfilingStart();
             // This is deliberately a very large method. Parts of it could be factored out
             // into other private methods, but doing so comes at a consequential perf cost,
             // because it involves so much parameter passing. You can think of the code here
@@ -300,12 +296,10 @@ private static void AppendDiffEntriesForRange(
                     diffContext.KeyedItemInfoDictionaryPool.Return(keyedItemInfos);
                 }
             }
-            ProfilingEnd();
         }
 
         private static Dictionary<object, KeyedItemInfo> BuildKeyToInfoLookup(DiffContext diffContext, int oldStartIndex, int oldEndIndexExcl, int newStartIndex, int newEndIndexExcl)
         {
-            ProfilingStart();
             var result = diffContext.KeyedItemInfoDictionaryPool.Get();
             var oldTree = diffContext.OldTree;
             var newTree = diffContext.NewTree;
@@ -351,7 +345,6 @@ private static Dictionary<object, KeyedItemInfo> BuildKeyToInfoLookup(DiffContex
                 newStartIndex = NextSiblingIndex(frame, newStartIndex);
             }
 
-            ProfilingEnd();
             return result;
         }
 
@@ -384,7 +377,6 @@ private static void AppendAttributeDiffEntriesForRange(
             int oldStartIndex, int oldEndIndexExcl,
             int newStartIndex, int newEndIndexExcl)
         {
-            ProfilingStart();
             // The overhead of the dictionary used by AppendAttributeDiffEntriesForRangeSlow is
             // significant, so we want to try and do a merge-join if possible, but fall back to
             // a hash-join if not. We'll do a merge join until we hit a case we can't handle and
@@ -433,7 +425,6 @@ private static void AppendAttributeDiffEntriesForRange(
                             ref diffContext,
                             oldStartIndex, oldEndIndexExcl,
                             newStartIndex, newEndIndexExcl);
-                        ProfilingEnd();
                         return;
                     }
 
@@ -459,20 +450,16 @@ private static void AppendAttributeDiffEntriesForRange(
                         ref diffContext,
                         oldStartIndex, oldEndIndexExcl,
                         newStartIndex, newEndIndexExcl);
-                    ProfilingEnd();
                     return;
                 }
             }
-
-            ProfilingEnd();
         }
 
         private static void AppendAttributeDiffEntriesForRangeSlow(
             ref DiffContext diffContext,
             int oldStartIndex, int oldEndIndexExcl,
             int newStartIndex, int newEndIndexExcl)
         {
-            ProfilingStart();
             var oldTree = diffContext.OldTree;
             var newTree = diffContext.NewTree;
 
@@ -511,15 +498,13 @@ private static void AppendAttributeDiffEntriesForRangeSlow(
 
             // We should have processed any additions at this point. Reset for the next batch.
             diffContext.AttributeDiffSet.Clear();
-            ProfilingEnd();
         }
 
         private static void UpdateRetainedChildComponent(
             ref DiffContext diffContext,
             int oldComponentIndex,
             int newComponentIndex)
         {
-            ProfilingStart();
             var oldTree = diffContext.OldTree;
             var newTree = diffContext.NewTree;
             ref var oldComponentFrame = ref oldTree[oldComponentIndex];
@@ -546,8 +531,6 @@ private static void UpdateRetainedChildComponent(
             {
                 componentState.SetDirectParameters(newParameters);
             }
-
-            ProfilingEnd();
         }
 
         private static int NextSiblingIndex(in RenderTreeFrame frame, int frameIndex)
@@ -570,7 +553,6 @@ private static void AppendDiffEntriesForFramesWithSameSequence(
             int oldFrameIndex,
             int newFrameIndex)
         {
-            ProfilingStart();
             var oldTree = diffContext.OldTree;
             var newTree = diffContext.NewTree;
             ref var oldFrame = ref oldTree[oldFrameIndex];
@@ -583,7 +565,6 @@ private static void AppendDiffEntriesForFramesWithSameSequence(
             {
                 InsertNewFrame(ref diffContext, newFrameIndex);
                 RemoveOldFrame(ref diffContext, oldFrameIndex);
-                ProfilingEnd();
                 return;
             }
 
@@ -709,8 +690,6 @@ private static void AppendDiffEntriesForFramesWithSameSequence(
                 default:
                     throw new NotImplementedException($"Encountered unsupported frame type during diffing: {newTree[newFrameIndex].FrameType}");
             }
-
-            ProfilingEnd();
         }
 
         // This should only be called for attributes that have the same name. This is an
@@ -720,7 +699,6 @@ private static void AppendDiffEntriesForAttributeFrame(
             int oldFrameIndex,
             int newFrameIndex)
         {
-            ProfilingStart();
             var oldTree = diffContext.OldTree;
             var newTree = diffContext.NewTree;
             ref var oldFrame = ref oldTree[oldFrameIndex];
@@ -749,13 +727,10 @@ private static void AppendDiffEntriesForAttributeFrame(
                 // since it was unchanged.
                 newFrame = oldFrame;
             }
-
-            ProfilingEnd();
         }
 
         private static void InsertNewFrame(ref DiffContext diffContext, int newFrameIndex)
         {
-            ProfilingStart();
             var newTree = diffContext.NewTree;
             ref var newFrame = ref newTree[newFrameIndex];
             switch (newFrame.FrameType)
@@ -808,12 +783,10 @@ private static void InsertNewFrame(ref DiffContext diffContext, int newFrameInde
                 default:
                     throw new NotImplementedException($"Unexpected frame type during {nameof(InsertNewFrame)}: {newFrame.FrameType}");
             }
-            ProfilingEnd();
         }
 
         private static void RemoveOldFrame(ref DiffContext diffContext, int oldFrameIndex)
         {
-            ProfilingStart();
             var oldTree = diffContext.OldTree;
             ref var oldFrame = ref oldTree[oldFrameIndex];
             switch (oldFrame.FrameType)
@@ -855,7 +828,6 @@ private static void RemoveOldFrame(ref DiffContext diffContext, int oldFrameInde
                 default:
                     throw new NotImplementedException($"Unexpected frame type during {nameof(RemoveOldFrame)}: {oldFrame.FrameType}");
             }
-            ProfilingEnd();
         }
 
         private static int GetAttributesEndIndexExclusive(RenderTreeFrame[] tree, int rootIndex)
@@ -889,7 +861,6 @@ private static void AppendStepOut(ref DiffContext diffContext)
 
         private static void InitializeNewSubtree(ref DiffContext diffContext, int frameIndex)
         {
-            ProfilingStart();
             var frames = diffContext.NewTree;
             var endIndexExcl = frameIndex + frames[frameIndex].ElementSubtreeLength;
             for (var i = frameIndex; i < endIndexExcl; i++)
@@ -911,12 +882,10 @@ private static void InitializeNewSubtree(ref DiffContext diffContext, int frameI
                         break;
                 }
             }
-            ProfilingEnd();
         }
 
         private static void InitializeNewComponentFrame(ref DiffContext diffContext, int frameIndex)
         {
-            ProfilingStart();
             var frames = diffContext.NewTree;
             ref var frame = ref frames[frameIndex];
 
@@ -933,7 +902,6 @@ private static void InitializeNewComponentFrame(ref DiffContext diffContext, int
             var initialParametersLifetime = new ParameterViewLifetime(diffContext.BatchBuilder);
             var initialParameters = new ParameterView(initialParametersLifetime, frames, frameIndex);
             childComponentState.SetDirectParameters(initialParameters);
-            ProfilingEnd();
         }
 
         private static void InitializeNewAttributeFrame(ref DiffContext diffContext, ref RenderTreeFrame newFrame)
@@ -978,7 +946,6 @@ private static void InitializeNewComponentReferenceCaptureFrame(ref DiffContext
 
         private static void DisposeFramesInRange(RenderBatchBuilder batchBuilder, RenderTreeFrame[] frames, int startIndex, int endIndexExcl)
         {
-            ProfilingStart();
             for (var i = startIndex; i < endIndexExcl; i++)
             {
                 ref var frame = ref frames[i];
@@ -991,7 +958,6 @@ private static void DisposeFramesInRange(RenderBatchBuilder batchBuilder, Render
                     batchBuilder.DisposedEventHandlerIds.Append(frame.AttributeEventHandlerId);
                 }
             }
-            ProfilingEnd();
         }
 
         /// <summary>
@@ -1033,18 +999,5 @@ public DiffContext(
                 SiblingIndex = 0;
             }
         }
-
-        // Having too many calls to ComponentsProfiling.Instance.Start/End has a measurable perf impact
-        // even when capturing is disabled. So, to enable detailed profiling for this class, define the
-        // Profile_RenderTreeDiffBuilder compiler symbol, otherwise the calls are compiled out entirely.
-        // Enabling detailed profiling adds about 5% to rendering benchmark times.
-
-        [Conditional("Profile_RenderTreeDiffBuilder")]
-        private static void ProfilingStart([CallerMemberName] string? name = null)
-            => ComponentsProfiling.Instance.Start(name);
-
-        [Conditional("Profile_RenderTreeDiffBuilder")]
-        private static void ProfilingEnd([CallerMemberName] string? name = null)
-            => ComponentsProfiling.Instance.End(name);
     }
 }