Follow-up to cleaning up obsolete types in Razor (#28706)

* Follow-up to cleaning up obsolete types in Razor

* Revert "Follow-up to cleaning up obsolete types in Razor"

This reverts commit 0ccc3d6.

* Address feedback from peer review

Author: captainsafia

src/Mvc/Mvc.Razor.RuntimeCompilation/src/FileProviderRazorProjectFileSystem.cs

@@ -34,7 +34,7 @@ public FileProviderRazorProjectFileSystem(RuntimeCompilationFileProvider filePro
 
         public IFileProvider FileProvider => _fileProvider.FileProvider;
 
-        [Obsolete("Use GetItem(string path, string fileKind) instead.")]
+
         public override RazorProjectItem GetItem(string path)
         {
             return GetItem(path, fileKind: null);
@@ -96,4 +96,4 @@ private static string JoinPath(string path1, string path2)
             return path1 + "/" + path2;
         }
     }
-}
+}

src/Mvc/Mvc.Razor.RuntimeCompilation/src/PageDirectiveFeature.cs

@@ -77,7 +77,7 @@ public override IEnumerable<RazorProjectItem> FindHierarchicalItems(string baseP
                 return Enumerable.Empty<RazorProjectItem>();
             }
 
-            [Obsolete("Use GetItem(string path, string fileKind) instead.")]
+
             public override RazorProjectItem GetItem(string path)
             {
                 return GetItem(path, fileKind: null);

src/Mvc/Mvc.Razor.RuntimeCompilation/test/TestInfrastructure/VirtualRazorProjectFileSystem.cs

@@ -18,7 +18,7 @@ public override IEnumerable<RazorProjectItem> EnumerateItems(string basePath)
             return directory?.EnumerateItems() ?? Enumerable.Empty<RazorProjectItem>();
         }
 
-        [Obsolete("Use GetItem(string path, string fileKind) instead.")]
+
         public override RazorProjectItem GetItem(string path)
         {
             return GetItem(path, fileKind: null);
@@ -44,4 +44,4 @@ public void Add(RazorProjectItem projectItem)
             _root.AddFile(new FileNode(filePath, projectItem));
         }
     }
-}
+}

src/Razor/Microsoft.AspNetCore.Razor.Language/src/DefaultRazorProjectFileSystem.cs

@@ -16,7 +16,7 @@ public DefaultRazorProjectFileSystem(string root)
             {
                 throw new ArgumentException(Resources.ArgumentCannotBeNullOrEmpty, nameof(root));
             }
-            
+
             Root = root.Replace('\\', '/').TrimEnd('/');
         }
 
@@ -61,7 +61,7 @@ public override RazorProjectItem GetItem(string path, string fileKind)
             return new DefaultRazorProjectItem("/", filePath, relativePhysicalPath, fileKind, new FileInfo(absolutePath), cssScope: null);
         }
 
-        [Obsolete("Use GetItem(string path, string fileKind) instead.")]
+
         public override RazorProjectItem GetItem(string path)
         {
             return GetItem(path, fileKind: null);

src/Razor/Microsoft.AspNetCore.Razor.Language/src/EmptyProjectFileSystem.cs

@@ -15,7 +15,7 @@ public override IEnumerable<RazorProjectItem> EnumerateItems(string basePath)
             return Enumerable.Empty<RazorProjectItem>();
         }
 
-        [Obsolete("Use GetItem(string path, string fileKind) instead.")]
+
         public override RazorProjectItem GetItem(string path)
         {
             return GetItem(path, fileKind: null);

src/Razor/Microsoft.AspNetCore.Razor.Language/src/RazorProject.cs

@@ -28,7 +28,7 @@ public abstract class RazorProject
         /// </summary>
         /// <param name="path">The path.</param>
         /// <returns>The <see cref="RazorProjectItem"/>.</returns>
-        [Obsolete("Use GetItem(string path, string fileKind) instead.")]
+
         public abstract RazorProjectItem GetItem(string path);
 
         /// <summary>
@@ -50,7 +50,7 @@ public abstract class RazorProject
         /// traverses to the project root.
         /// e.g.
         /// /Views/Home/View.cshtml -> [ /Views/Home/FileName.cshtml, /Views/FileName.cshtml, /FileName.cshtml ]
-        /// 
+        ///
         /// Project items returned by this method have inferred FileKinds from their corresponding file paths.
         /// </remarks>
         public IEnumerable<RazorProjectItem> FindHierarchicalItems(string path, string fileName)
@@ -70,7 +70,7 @@ public IEnumerable<RazorProjectItem> FindHierarchicalItems(string path, string f
         /// traverses to the <paramref name="basePath"/>.
         /// e.g.
         /// (/Views, /Views/Home/View.cshtml) -> [ /Views/Home/FileName.cshtml, /Views/FileName.cshtml ]
-        /// 
+        ///
         /// Project items returned by this method have inferred FileKinds from their corresponding file paths.
         /// </remarks>
         public virtual IEnumerable<RazorProjectItem> FindHierarchicalItems(string basePath, string path, string fileName)

src/Razor/Microsoft.AspNetCore.Razor.Language/src/VirtualRazorProjectFileSystem.cs

@@ -19,7 +19,7 @@ public override IEnumerable<RazorProjectItem> EnumerateItems(string basePath)
             return directory?.EnumerateItems() ?? Enumerable.Empty<RazorProjectItem>();
         }
 
-        [Obsolete("Use GetItem(string path, string fileKind) instead.")]
+
         public override RazorProjectItem GetItem(string path)
         {
             return GetItem(path, fileKind: null);

src/Razor/Microsoft.AspNetCore.Razor.Language/test/TestRazorProject.cs

@@ -26,7 +26,7 @@ public override IEnumerable<RazorProjectItem> EnumerateItems(string basePath)
             throw new NotImplementedException();
         }
 
-        [Obsolete("Use GetItem(string path, string fileKind) instead.")]
+
         public override RazorProjectItem GetItem(string path)
         {
             return GetItem(path, fileKind: null);

src/Razor/Microsoft.AspNetCore.Razor.Tools/src/CompositeRazorProjectFileSystem.cs

@@ -27,7 +27,7 @@ public override IEnumerable<RazorProjectItem> EnumerateItems(string basePath)
             }
         }
 
-        [Obsolete("Use GetItem(string path, string fileKind) instead.")]
+
         public override RazorProjectItem GetItem(string path)
         {
             return GetItem(path, fileKind: null);

src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common/Language/TestRazorProjectFileSystem.cs

@@ -28,7 +28,7 @@ public override IEnumerable<RazorProjectItem> EnumerateItems(string basePath)
             throw new NotImplementedException();
         }
 
-        [Obsolete("Use GetItem(string path, string fileKind) instead.")]
+
         public override RazorProjectItem GetItem(string path)
         {
             return GetItem(path, fileKind: null);