PR feedback

Author: JamesNK

src/Servers/Kestrel/Core/src/Internal/Http2/HPackHeaderWriter.cs

@@ -154,7 +154,6 @@ private static bool IsSensitive(int staticTableIndex, string name)
             switch (staticTableIndex)
             {
                 case H2StaticTable.SetCookie:
-                    return true;
                 case H2StaticTable.ContentDisposition:
                     return true;
                 case -1:

src/Servers/Kestrel/Core/src/Internal/Http2/Http2Connection.cs

@@ -1226,33 +1226,30 @@ private void UpdateConnectionState()
             }
         }
 
-        // We can't throw a Http2StreamErrorException here, it interrupts the header decompression state and may corrupt subsequent header frames on other streams.
-        // For now these either need to be connection errors or BadRequests. If we want to downgrade any of them to stream errors later then we need to
-        // rework the flow so that the remaining headers are drained and the decompression state is maintained.
         public void OnHeader(ReadOnlySpan<byte> name, ReadOnlySpan<byte> value)
         {
-            OnHeaderCore(index: null, indexOnly : false, name, value);
+            OnHeaderCore(index: null, indexedValue: false, name, value);
         }
 
         public void OnStaticIndexedHeader(int index)
         {
             Debug.Assert(index <= H2StaticTable.Count);
 
             ref readonly var entry = ref H2StaticTable.Get(index - 1);
-            OnHeaderCore(index, indexOnly: true, entry.Name, entry.Value);
+            OnHeaderCore(index, indexedValue: true, entry.Name, entry.Value);
         }
 
         public void OnStaticIndexedHeader(int index, ReadOnlySpan<byte> value)
         {
             Debug.Assert(index <= H2StaticTable.Count);
 
-            OnHeaderCore(index, indexOnly: false, H2StaticTable.Get(index - 1).Name, value);
+            OnHeaderCore(index, indexedValue: false, H2StaticTable.Get(index - 1).Name, value);
         }
 
         // We can't throw a Http2StreamErrorException here, it interrupts the header decompression state and may corrupt subsequent header frames on other streams.
         // For now these either need to be connection errors or BadRequests. If we want to downgrade any of them to stream errors later then we need to
         // rework the flow so that the remaining headers are drained and the decompression state is maintained.
-        private void OnHeaderCore(int? index, bool indexOnly, ReadOnlySpan<byte> name, ReadOnlySpan<byte> value)
+        private void OnHeaderCore(int? index, bool indexedValue, ReadOnlySpan<byte> name, ReadOnlySpan<byte> value)
         {
             // https://tools.ietf.org/html/rfc7540#section-6.5.2
             // "The value is based on the uncompressed size of header fields, including the length of the name and value in octets plus an overhead of 32 octets for each header field.";
@@ -1283,7 +1280,7 @@ private void OnHeaderCore(int? index, bool indexOnly, ReadOnlySpan<byte> name, R
                     // Throws InvalidOperation for bad encoding.
                     if (index != null)
                     {
-                        _currentHeadersStream.OnHeader(index.Value, indexOnly, name, value);
+                        _currentHeadersStream.OnHeader(index.Value, indexedValue, name, value);
                     }
                     else
                     {

src/Servers/Kestrel/Core/src/Internal/Http2/Http2Stream.cs

@@ -625,13 +625,13 @@ private enum StreamCompletionFlags
             Aborted = 4,
         }
 
-        public override void OnHeader(int index, bool indexOnly, ReadOnlySpan<byte> name, ReadOnlySpan<byte> value)
+        public override void OnHeader(int index, bool indexedValue, ReadOnlySpan<byte> name, ReadOnlySpan<byte> value)
         {
-            base.OnHeader(index, indexOnly, name, value);
+            base.OnHeader(index, indexedValue, name, value);
 
-            if (indexOnly)
+            if (indexedValue)
             {
-                // Special case setting index only headers for performance
+                // Special case setting headers when the value is indexed for performance.
                 switch (index)
                 {
                     case H2StaticTable.MethodGet: