PR feedback

Author: shirhatti

src/Servers/HttpSys/test/FunctionalTests/DelegateTests.cs

@@ -29,53 +29,54 @@ public async Task DelegateRequestTest()
                 options.RequestQueueName = queueName;
             });
 
-            DelegationRule wrapper = default;
+            DelegationRule destination = default;
 
             using var delegator = Utilities.CreateHttpServer(out var delegatorAddress, httpContext =>
             {
                 var transferFeature = httpContext.Features.Get<IHttpSysRequestTransferFeature>();
-                transferFeature.TransferRequest(wrapper);
+                transferFeature.TransferRequest(destination);
                 return Task.FromResult(0);
             });
 
             var delegationProperty = delegator.Features.Get<IServerDelegationFeature>();
-            wrapper = delegationProperty.CreateDelegationRule(queueName, receiverAddress);
+            destination = delegationProperty.CreateDelegationRule(queueName, receiverAddress);
 
             var responseString = await SendRequestAsync(delegatorAddress);
             Assert.Equal(_expectedResponseString, responseString);
-            wrapper?.Dispose();
+            destination?.Dispose();
         }
 
         [ConditionalFact]
         [DelegateSupportedCondition(true)]
         public async Task DelegateAfterWriteToResponseBodyShouldThrowTest()
         {
             var queueName = Guid.NewGuid().ToString();
-            using var receiver = Utilities.CreateHttpServer(out var receiverAddress, async httpContext =>
+            using var receiver = Utilities.CreateHttpServer(out var receiverAddress, httpContext =>
             {
-                await httpContext.Response.WriteAsync(_expectedResponseString);
+                httpContext.Response.StatusCode = StatusCodes.Status418ImATeapot;
+                return Task.CompletedTask;
             },
             options =>
             {
                 options.RequestQueueName = queueName;
             });
 
-            DelegationRule wrapper = default;
+            DelegationRule destination = default;
 
             using var delegator = Utilities.CreateHttpServer(out var delegatorAddress, async httpContext =>
             {
                 await httpContext.Response.WriteAsync(_expectedResponseString);
                 var transferFeature = httpContext.Features.Get<IHttpSysRequestTransferFeature>();
                 Assert.False(transferFeature.IsTransferable);
-                Assert.Throws<InvalidOperationException>(() => transferFeature.TransferRequest(wrapper));
+                Assert.Throws<InvalidOperationException>(() => transferFeature.TransferRequest(destination));
             });
 
             var delegationProperty = delegator.Features.Get<IServerDelegationFeature>();
-            wrapper = delegationProperty.CreateDelegationRule(queueName, receiverAddress);
+            destination = delegationProperty.CreateDelegationRule(queueName, receiverAddress);
 
             var responseString = await SendRequestAsync(delegatorAddress);
             Assert.Equal(_expectedResponseString, responseString);
-            wrapper?.Dispose();
+            destination?.Dispose();
         }
 
         [ConditionalFact]
@@ -92,53 +93,54 @@ public async Task WriteToBodyAfterDelegateShouldNoOp()
                 options.RequestQueueName = queueName;
             });
 
-            DelegationRule wrapper = default;
+            DelegationRule destination = default;
 
             using var delegator = Utilities.CreateHttpServer(out var delegatorAddress, httpContext =>
             {
                 var transferFeature = httpContext.Features.Get<IHttpSysRequestTransferFeature>();
-                transferFeature.TransferRequest(wrapper);
+                transferFeature.TransferRequest(destination);
                 Assert.False(transferFeature.IsTransferable);
                 return Task.CompletedTask;
             });
 
             var delegationProperty = delegator.Features.Get<IServerDelegationFeature>();
-            wrapper = delegationProperty.CreateDelegationRule(queueName, receiverAddress);
+            destination = delegationProperty.CreateDelegationRule(queueName, receiverAddress);
 
             var responseString = await SendRequestAsync(delegatorAddress);
             Assert.Equal(_expectedResponseString, responseString);
-            wrapper?.Dispose();
+            destination?.Dispose();
         }
 
         [ConditionalFact]
         [DelegateSupportedCondition(true)]
         public async Task DelegateAfterRequestBodyReadShouldThrow()
         {
             var queueName = Guid.NewGuid().ToString();
-            using var receiver = Utilities.CreateHttpServer(out var receiverAddress, async httpContext =>
+            using var receiver = Utilities.CreateHttpServer(out var receiverAddress, httpContext =>
             {
-                await httpContext.Response.WriteAsync(_expectedResponseString);
+                httpContext.Response.StatusCode = StatusCodes.Status418ImATeapot;
+                return Task.CompletedTask;
             },
            options =>
            {
                options.RequestQueueName = queueName;
            });
 
-            DelegationRule wrapper = default;
+            DelegationRule destination = default;
 
             using var delegator = Utilities.CreateHttpServer(out var delegatorAddress, async httpContext =>
             {
                 var memoryStream = new MemoryStream();
                 await httpContext.Request.Body.CopyToAsync(memoryStream);
                 var transferFeature = httpContext.Features.Get<IHttpSysRequestTransferFeature>();
-                Assert.Throws<InvalidOperationException>(() => transferFeature.TransferRequest(wrapper));
+                Assert.Throws<InvalidOperationException>(() => transferFeature.TransferRequest(destination));
             });
 
             var delegationProperty = delegator.Features.Get<IServerDelegationFeature>();
-            wrapper = delegationProperty.CreateDelegationRule(queueName, receiverAddress);
+            destination = delegationProperty.CreateDelegationRule(queueName, receiverAddress);
 
             _ = await SendRequestWithBodyAsync(delegatorAddress);
-            wrapper?.Dispose();
+            destination?.Dispose();
         }
 
         [ConditionalFact]

src/Shared/HttpSys/NativeInterop/HttpApiTypes.cs

@@ -71,6 +71,7 @@ internal enum HTTP_TIMEOUT_TYPE
             HeaderWait,
             MinSendRate,
         }
+
         internal enum HTTP_DELEGATE_REQUEST_PROPERTY_ID : uint
         {
             DelegateRequestReservedProperty,