Skip to content

Commit 84d7336

Browse files
committed
PR feedback
1 parent 32d98c6 commit 84d7336

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/Servers/Kestrel/Core/src/Internal/Http3/Http3Stream.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -353,6 +353,7 @@ private void CompleteStream(bool errored)
353353
// request stream.
354354

355355
// TODO(JamesNK): Abort the read half of the stream with H3_NO_ERROR
356+
// https://github.com/dotnet/aspnetcore/issues/33575
356357

357358
RequestBodyPipe.Writer.Complete();
358359
}

src/Servers/Kestrel/test/InMemory.FunctionalTests/Http3/Http3StreamTests.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2431,9 +2431,9 @@ public async Task PostRequest_ServerReadsPartialAndFinishes_SendsBodyWithEndStre
24312431
var clientTcs = new TaskCompletionSource<int>(TaskCreationOptions.RunContinuationsAsynchronously);
24322432
var headers = new[]
24332433
{
2434-
new KeyValuePair<string, string>(HeaderNames.Method, "GET"),
2434+
new KeyValuePair<string, string>(HeaderNames.Method, "POST"),
24352435
new KeyValuePair<string, string>(HeaderNames.Path, "/"),
2436-
new KeyValuePair<string, string>(HeaderNames.Scheme, "http"),
2436+
new KeyValuePair<string, string>(HeaderNames.Scheme, "https"),
24372437
};
24382438
var requestStream = await InitializeConnectionAndStreamsAsync(async context =>
24392439
{
@@ -2482,6 +2482,7 @@ public async Task PostRequest_ServerReadsPartialAndFinishes_SendsBodyWithEndStre
24822482
await requestStream.ExpectReceiveEndOfStream();
24832483

24842484
// TODO(JamesNK): Await the server aborting the sending half of the request stream.
2485+
// https://github.com/dotnet/aspnetcore/issues/33575
24852486
await Task.Delay(1000);
24862487

24872488
// Logged without an exception.

0 commit comments

Comments
 (0)