Skip to content

Commit 7dca017

Browse files
committed
Use ValueStringBuilder in HttpLogging Middleware
1 parent 028470e commit 7dca017

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/Middleware/HttpLogging/src/HttpRequestLog.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@ public override string ToString()
3737
{
3838
if (_cachedToString == null)
3939
{
40-
// TODO use string.Create instead of a StringBuilder here.
41-
var builder = new StringBuilder();
40+
var builder = new ValueStringBuilder();
4241
var count = _keyValues.Count;
4342
builder.Append("Request:");
4443
builder.Append(Environment.NewLine);

src/Middleware/HttpLogging/src/HttpResponseLog.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public override string ToString()
3737
{
3838
if (_cachedToString == null)
3939
{
40-
var builder = new StringBuilder();
40+
var builder = new ValueStringBuilder();
4141
var count = _keyValues.Count;
4242
builder.Append("Response:");
4343
builder.Append(Environment.NewLine);

src/Middleware/HttpLogging/src/Microsoft.AspNetCore.HttpLogging.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
</Description>
77
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
88
<IsAspNetCoreApp>true</IsAspNetCoreApp>
9+
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
910
<GenerateDocumentationFile>true</GenerateDocumentationFile>
1011
<IsPackable>false</IsPackable>
1112
<Nullable>enable</Nullable>
@@ -17,6 +18,6 @@
1718

1819
<Compile Include="$(RepoRoot)src\Shared\TaskToApm.cs" Link="Internal\TaskToApm.cs" />
1920
<Compile Include="$(SharedSourceRoot)Buffers\**\*.cs" LinkBase="Internal\" />
21+
<Compile Include="$(SharedSourceRoot)ValueStringBuilder\**\*.cs" />
2022
</ItemGroup>
21-
2223
</Project>

0 commit comments

Comments
 (0)