Suggestions from code review

Author: MackinnonBuck

src/Components/Components/src/ChangeDetection.cs

@@ -2,12 +2,21 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.Collections.Concurrent;
+using Microsoft.AspNetCore.Components.HotReload;
 
 namespace Microsoft.AspNetCore.Components;
 
 internal sealed class ChangeDetection
 {
-    private static readonly ConcurrentDictionary<Type, bool> _immutableNonObjectTypesCache = new();
+    private static readonly ConcurrentDictionary<Type, bool> _immutableObjectTypesCache = new();
+
+    static ChangeDetection()
+    {
+        if (HotReloadManager.Default.MetadataUpdateSupported)
+        {
+            HotReloadManager.Default.OnDeltaApplied += _immutableObjectTypesCache.Clear;
+        }
+    }
 
     public static bool MayHaveChanged<T1, T2>(T1 oldValue, T2 newValue)
     {
@@ -34,35 +43,18 @@ public static bool MayHaveChanged<T1, T2>(T1 oldValue, T2 newValue)
         return false;
     }
 
-    // The contents of this list need to trade off false negatives against computation
-    // time. So we don't want a huge list of types to check (or would have to move to
-    // a hashtable lookup, which is differently expensive). It's better not to include
-    // uncommon types here even if they are known to be immutable.
     // This logic assumes that no new System.TypeCode enum entries have been declared since 7.0, or at least that any new ones
     // represent immutable types. If System.TypeCode changes, review this logic to ensure it is still correct.
     // Supported immutable types : bool, byte, sbyte, short, ushort, int, uint, long, ulong, char, double,
     //                             string, DateTime, decimal, Guid, Enum, EventCallback, EventCallback<>.
     // For performance reasons, the following immutable types are not supported: IntPtr, UIntPtr, Type.
     private static bool IsKnownImmutableType(Type type)
         => Type.GetTypeCode(type) != TypeCode.Object
-        || _immutableNonObjectTypesCache.GetOrAdd(type, IsImmutableNonObjectCore);
+        || _immutableObjectTypesCache.GetOrAdd(type, IsImmutableObjectTypeCore);
 
-    private static bool IsImmutableNonObjectCore(Type type)
+    private static bool IsImmutableObjectTypeCore(Type type)
         => type == typeof(Guid)
         || type == typeof(DateOnly)
         || type == typeof(TimeOnly)
         || typeof(IEventCallback).IsAssignableFrom(type);
-
-    public static event Action? OnHotReload;
-
-    public static void ClearImmutableTypeCache()
-    {
-        _immutableNonObjectTypesCache.Clear();
-    }
-
-    public static void HotReloadHandler()
-    {
-        ClearImmutableTypeCache();
-        OnHotReload?.Invoke();
-    }
 }