Skip to content

Commit 6e53284

Browse files
committed
Feedback
1 parent e2bcd96 commit 6e53284

File tree

2 files changed

+2
-12
lines changed

2 files changed

+2
-12
lines changed

src/SignalR/clients/java/signalr/src/main/java/com/microsoft/signalr/HttpHubConnectionBuilder.java

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -56,22 +56,12 @@ HttpHubConnectionBuilder withHttpClient(HttpClient httpClient) {
5656
return this;
5757
}
5858

59-
/**
60-
* Sets Json as the {@link HubProtocol} to be used by the {@link HubConnection}.
61-
*
62-
* @return This instance of the HttpHubConnectionBuilder.
63-
*/
64-
public HttpHubConnectionBuilder withJson() {
65-
this.protocol = new JsonHubProtocol();
66-
return this;
67-
}
68-
6959
/**
7060
* Sets MessagePack as the {@link HubProtocol} to be used by the {@link HubConnection}.
7161
*
7262
* @return This instance of the HttpHubConnectionBuilder.
7363
*/
74-
public HttpHubConnectionBuilder withMessagePack() {
64+
public HttpHubConnectionBuilder withMessagePackHubProtocol() {
7565
this.protocol = new MessagePackHubProtocol();
7666
return this;
7767
}

src/SignalR/clients/java/signalr/src/test/java/com/microsoft/signalr/TestUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ static HubConnection createHubConnection(String url, Transport transport, boolea
3333
.shouldSkipNegotiate(skipNegotiate);
3434

3535
if (withMessagePack) {
36-
builder = builder.withMessagePack();
36+
builder = builder.withMessagePackHubProtocol();
3737
}
3838

3939
return builder.build();

0 commit comments

Comments
 (0)