Respond to feedback

Author: wtgodbe

src/SignalR/clients/java/signalr/src/main/java/com/microsoft/signalr/CloseMessage.java

@@ -17,11 +17,11 @@ public CloseMessage() {
     }
 
     public CloseMessage(String error) {
-        this (error, false);
+        this(error, false);
     }
 
     public CloseMessage(boolean allowReconnect) {
-        this (null, allowReconnect);
+        this(null, allowReconnect);
     }
 
     public CloseMessage(String error, boolean allowReconnect) {

src/SignalR/clients/java/signalr/src/main/java/com/microsoft/signalr/HubConnection.java

@@ -696,7 +696,6 @@ public Completable invoke(String method, Object... args) {
     public <T> Single<T> invoke(Class<T> returnType, String method, Object... args) {
         return this.<T>invoke(returnType, returnType, method, args);
     }
-    
 
     /**
      * Invokes a hub method on the server using the specified method name and arguments.
@@ -1079,8 +1078,6 @@ public <T1, T2, T3, T4, T5, T6, T7, T8> Subscription on(String target, Action8<T
     /**
      * Registers a handler that will be invoked when the hub method with the specified method name is invoked.
      * Should be used for generic classes and Parameterized Collections, like List or Map.
-     * 
-     * Should be invoked with the syntax
      *
      * @param target   The name of the hub method to define.
      * @param callback The handler that will be raised when the hub method is invoked.

src/SignalR/clients/java/signalr/src/main/java/com/microsoft/signalr/InvocationBinder.java

@@ -7,9 +7,8 @@
 import java.util.List;
 
 /**
- * An abstraction for passing around information about method signatures
+ * An abstraction for passing around information about method signatures.
  */
-
 public interface InvocationBinder {
     Type getReturnType(String invocationId);
     List<Type> getParameterTypes(String methodName);

src/SignalR/clients/java/signalr/src/main/java/com/microsoft/signalr/JsonHubProtocol.java

@@ -41,16 +41,16 @@ public TransferFormat getTransferFormat() {
 
     @Override
     public List<HubMessage> parseMessages(ByteBuffer payload, InvocationBinder binder) {
-    	String payloadStr;
-    	// If the payload is readOnly, we have to copy the bytes from its array to make the payload string
+        String payloadStr;
+        // If the payload is readOnly, we have to copy the bytes from its array to make the payload string
         if (payload.isReadOnly()) {
-        	byte[] payloadBytes = new byte[payload.remaining()];
+            byte[] payloadBytes = new byte[payload.remaining()];
             payload.get(payloadBytes, 0, payloadBytes.length);
             payloadStr = new String(payloadBytes, StandardCharsets.UTF_8);
         // Otherwise we can allocate directly from its array
         } else {
-        	// The position of the ByteBuffer may have been incremented - make sure we only grab the remaining bytes
-        	payloadStr = new String(payload.array(), payload.position(), payload.remaining(), StandardCharsets.UTF_8);
+            // The position of the ByteBuffer may have been incremented - make sure we only grab the remaining bytes
+            payloadStr = new String(payload.array(), payload.position(), payload.remaining(), StandardCharsets.UTF_8);
         }
         if (payloadStr.length() == 0) {
             return null;

src/SignalR/clients/java/signalr/src/main/java/com/microsoft/signalr/MessagePackHubProtocol.java

@@ -616,7 +616,7 @@ private Object readValue(MessageUnpacker unpacker, Type itemType, ByteBuffer pay
                 //Convert this to an object?
                 item = extensionValue;
                 */
-                throw new RuntimeException("Extension types are not supported yet");
+                throw new RuntimeException("Extension types are not supported");
             default:
                 return null;
         }

src/SignalR/clients/java/signalr/src/test/java/com/microsoft/signalr/ByteString.java

@@ -0,0 +1,53 @@
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+package com.microsoft.signalr;
+
+import java.nio.ByteBuffer;
+
+class ByteString{
+    
+    private byte[] src;
+
+    private ByteString(byte[] src) {
+        this.src = src;
+    }
+    
+    public static ByteString of(byte[] src) {
+        return new ByteString(src);
+    }
+    
+    public static ByteString of(ByteBuffer src) {
+        return new ByteString(src.array());
+    }
+    
+    public byte[] array() {
+        return src;
+    }
+
+    @Override
+    public boolean equals(Object obj) {
+        if (!(obj instanceof ByteString)) {
+            return false;
+        }
+        byte[] otherSrc = ((ByteString) obj).array();
+        if (otherSrc.length != src.length) {
+            return false;
+        }
+        for (int i = 0; i < src.length; i++) {
+            if (src[i] != otherSrc[i]) {
+                return false;
+            }
+        }
+        return true;
+    }
+    
+    @Override
+    public String toString() {
+        String str = "";
+        for (byte b: src) {
+            str += String.format("%02X", b);
+        }
+        return str;
+    }
+}

src/SignalR/clients/java/signalr/src/test/java/com/microsoft/signalr/HandshakeProtocolTest.java

@@ -14,7 +14,7 @@ public void VerifyCreateHandshakerequestMessage() {
         HandshakeRequestMessage handshakeRequest = new HandshakeRequestMessage("json", 1);
         ByteBuffer result = HandshakeProtocol.createHandshakeRequestMessage(handshakeRequest);
         String expectedResult = "{\"protocol\":\"json\",\"version\":1}\u001E";
-        assertEquals(expectedResult, TestUtils.ByteBufferToString(result));
+        assertEquals(expectedResult, TestUtils.byteBufferToString(result));
     }
 
     @Test