Feedback

Author: javiercn

src/Middleware/Diagnostics/src/ExceptionHandler/ExceptionHandlerExtensions.cs

@@ -62,7 +62,7 @@ public static IApplicationBuilder UseExceptionHandler(this IApplicationBuilder a
         return app.UseExceptionHandler(new ExceptionHandlerOptions
         {
             ExceptionHandlingPath = new PathString(errorHandlingPath),
-            UseNewServiceResolutionScope = newScope
+            CreateScopeForErrors = newScope
         });
     }
 

src/Middleware/Diagnostics/src/ExceptionHandler/ExceptionHandlerMiddlewareImpl.cs

@@ -143,8 +143,8 @@ private async Task HandleException(HttpContext context, ExceptionDispatchInfo ed
         {
             context.Request.Path = _options.ExceptionHandlingPath;
         }
-        var oldScope = _options.UseNewServiceResolutionScope ? context.RequestServices : null;
-        using var scope = _options.UseNewServiceResolutionScope ? context.RequestServices.GetRequiredService<IServiceScopeFactory>().CreateScope() : null;
+        var oldScope = _options.CreateScopeForErrors ? context.RequestServices : null;
+        using var scope = _options.CreateScopeForErrors ? context.RequestServices.GetRequiredService<IServiceScopeFactory>().CreateScope() : null;
 
         try
         {

src/Middleware/Diagnostics/src/ExceptionHandler/ExceptionHandlerOptions.cs

@@ -19,10 +19,10 @@ public class ExceptionHandlerOptions
 
     /// <summary>
     /// Gets or sets whether the handler needs to create a separate <see cref="IServiceProvider"/> scope and
-    /// replace it on <see cref="HttpContext"/>.
+    /// replace it on <see cref="HttpContext.RequestServices"/> when re-executing the request to handle an error.
     /// </summary>
     /// <remarks>The default value is <see langword="false"/>.</remarks>
-    public bool UseNewServiceResolutionScope { get; set; }
+    public bool CreateScopeForErrors { get; set; }
 
     /// <summary>
     /// The <see cref="RequestDelegate" /> that will handle the exception. If this is not

src/Middleware/Diagnostics/src/PublicAPI.Unshipped.txt

@@ -1,6 +1,6 @@
 #nullable enable
-Microsoft.AspNetCore.Builder.ExceptionHandlerOptions.UseNewServiceResolutionScope.get -> bool
-Microsoft.AspNetCore.Builder.ExceptionHandlerOptions.UseNewServiceResolutionScope.set -> void
+Microsoft.AspNetCore.Builder.ExceptionHandlerOptions.CreateScopeForErrors.get -> bool
+Microsoft.AspNetCore.Builder.ExceptionHandlerOptions.CreateScopeForErrors.set -> void
 Microsoft.AspNetCore.Diagnostics.IExceptionHandler
 Microsoft.AspNetCore.Diagnostics.IExceptionHandler.TryHandleAsync(Microsoft.AspNetCore.Http.HttpContext! httpContext, System.Exception! exception, System.Threading.CancellationToken cancellationToken) -> System.Threading.Tasks.ValueTask<bool>
 Microsoft.AspNetCore.Diagnostics.StatusCodeReExecuteFeature.OriginalStatusCode.get -> int