Skip to content

Commit 4ff2671

Browse files
committed
PR feedback
1 parent 66e6ee7 commit 4ff2671

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/Http/Http.Extensions/src/HttpRequestJsonExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,10 @@ public static ValueTask<TValue> ReadFromJsonAsync<TValue>(
8383
return JsonSerializer.DeserializeAsync(request.Body, type, options, cancellationToken);
8484
}
8585

86-
private static JsonSerializerOptions ResolveSerializerOptions(HttpContext? httpContext)
86+
private static JsonSerializerOptions ResolveSerializerOptions(HttpContext httpContext)
8787
{
8888
// Attempt to resolve options from DI then fallback to default options
89-
return httpContext?.RequestServices?.GetService<IOptions<JsonOptions>>()?.Value?.SerializerOptions ?? JsonOptions.DefaultSerializerOptions;
89+
return httpContext.RequestServices?.GetService<IOptions<JsonOptions>>()?.Value?.SerializerOptions ?? JsonOptions.DefaultSerializerOptions;
9090
}
9191

9292
private static InvalidOperationException CreateContentTypeError(HttpRequest request)

src/Http/Http.Extensions/src/HttpResponseJsonExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,10 @@ public static Task WriteAsJsonAsync(
105105
return JsonSerializer.SerializeAsync(response.Body, value, type, options, cancellationToken);
106106
}
107107

108-
private static JsonSerializerOptions ResolveSerializerOptions(HttpContext? httpContext)
108+
private static JsonSerializerOptions ResolveSerializerOptions(HttpContext httpContext)
109109
{
110110
// Attempt to resolve options from DI then fallback to default options
111-
return httpContext?.RequestServices?.GetService<IOptions<JsonOptions>>()?.Value?.SerializerOptions ?? JsonOptions.DefaultSerializerOptions;
111+
return httpContext.RequestServices?.GetService<IOptions<JsonOptions>>()?.Value?.SerializerOptions ?? JsonOptions.DefaultSerializerOptions;
112112
}
113113
}
114114
}

0 commit comments

Comments
 (0)