Rename enable setting

Author: JamesNK

src/Servers/Kestrel/Core/src/Http2Limits.cs

@@ -141,5 +141,13 @@ public int InitialStreamWindowSize
                 _initialStreamWindowSize = value;
             }
         }
+
+        /// <summary>
+        /// Gets or sets a value that controls whether dynamic compression of response headers is enabled.
+        /// </summary>
+        /// <remarks>
+        /// Defaults to true.
+        /// </remarks>
+        public bool EnableResponseHeaderCompression { get; set; } = true;
     }
 }

src/Servers/Kestrel/Core/src/Internal/Http2/Http2FrameWriter.cs

@@ -71,7 +71,7 @@ public Http2FrameWriter(
             _outgoingFrame = new Http2Frame();
             _headerEncodingBuffer = new byte[_maxFrameSize];
 
-            _hpackEncoder = new HPackEncoder(serviceContext.ServerOptions.DisableResponseDynamicHeaderCompression);
+            _hpackEncoder = new HPackEncoder(!serviceContext.ServerOptions.Limits.Http2.EnableResponseHeaderCompression);
         }
 
         public void UpdateMaxHeaderTableSize(uint maxHeaderTableSize)

src/Servers/Kestrel/Core/src/KestrelServerOptions.cs

@@ -55,14 +55,6 @@ public class KestrelServerOptions
         /// </remarks>
         public bool DisableStringReuse { get; set; } = false;
 
-        /// <summary>
-        /// Gets or sets a value that controls whether dynamic compression of response headers is enabled across HTTP/2 and HTTP/3 requests.
-        /// </summary>
-        /// <remarks>
-        /// Defaults to false.
-        /// </remarks>
-        public bool DisableResponseDynamicHeaderCompression { get; set; } = false;
-
         /// <summary>
         /// Enables the Listen options callback to resolve and use services registered by the application during startup.
         /// Typically initialized by UseKestrel()"/>.

src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs

@@ -1909,7 +1909,7 @@ await ExpectAsync(Http2FrameType.HEADERS,
         [Fact]
         public async Task HEADERS_DisableDynamicHeaderCompression_HeadersNotCompressed()
         {
-            _serviceContext.ServerOptions.DisableResponseDynamicHeaderCompression = true;
+            _serviceContext.ServerOptions.Limits.Http2.EnableResponseHeaderCompression = false;
 
             await InitializeConnectionAsync(_noopApplication);