Skip to content

Commit 4510576

Browse files
[master] Update dependencies from dotnet/arcade (#25577)
[master] Update dependencies from dotnet/arcade - Updates: - Microsoft.DotNet.Build.Tasks.Installers: from 5.0.0-beta.20431.1 to 5.0.0-beta.20453.7 - Microsoft.DotNet.Helix.Sdk: from 5.0.0-beta.20431.1 to 5.0.0-beta.20453.7 - Microsoft.DotNet.Arcade.Sdk: from 5.0.0-beta.20431.1 to 5.0.0-beta.20453.7 - Attempt to Remove MicrosoftNetCompilersToolsetPackageVersion - Revert "Attempt to Remove MicrosoftNetCompilersToolsetPackageVersion" This reverts commit 2287b6a. - Move MicrosoftNetCompilersToolsetPackageVersion from automated -> manual updates. - Remove Compilers.Toolset dependency declaration.
1 parent 8f6e83a commit 4510576

File tree

9 files changed

+30
-25
lines changed

9 files changed

+30
-25
lines changed

eng/Version.Details.xml

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -317,21 +317,17 @@
317317
<Uri>https://github.com/dotnet/runtime</Uri>
318318
<Sha>bb921d6566feb3c06a65a149a01a779072808779</Sha>
319319
</Dependency>
320-
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="5.0.0-beta.20452.19">
320+
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="5.0.0-beta.20453.7">
321321
<Uri>https://github.com/dotnet/arcade</Uri>
322-
<Sha>fd104228e5b97494a4ab0896a979b69928257ef9</Sha>
322+
<Sha>16b71a2f216c3c5be5860977c4cb03a95ee2f0e3</Sha>
323323
</Dependency>
324-
<Dependency Name="Microsoft.DotNet.Build.Tasks.Installers" Version="5.0.0-beta.20452.19">
324+
<Dependency Name="Microsoft.DotNet.Build.Tasks.Installers" Version="5.0.0-beta.20453.7">
325325
<Uri>https://github.com/dotnet/arcade</Uri>
326-
<Sha>fd104228e5b97494a4ab0896a979b69928257ef9</Sha>
326+
<Sha>16b71a2f216c3c5be5860977c4cb03a95ee2f0e3</Sha>
327327
</Dependency>
328-
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="5.0.0-beta.20452.19">
328+
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="5.0.0-beta.20453.7">
329329
<Uri>https://github.com/dotnet/arcade</Uri>
330-
<Sha>fd104228e5b97494a4ab0896a979b69928257ef9</Sha>
331-
</Dependency>
332-
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="3.8.0-3.20458.6">
333-
<Uri>https://github.com/dotnet/roslyn</Uri>
334-
<Sha>b446afd34759150c2ea3b86ab794104e12e64db1</Sha>
330+
<Sha>16b71a2f216c3c5be5860977c4cb03a95ee2f0e3</Sha>
335331
</Dependency>
336332
</ToolsetDependencies>
337333
</Dependencies>

eng/Versions.props

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,6 @@
6161
6262
-->
6363
<PropertyGroup Label="Automated">
64-
<!-- Packages from dotnet/roslyn -->
65-
<MicrosoftNetCompilersToolsetPackageVersion>3.8.0-3.20458.6</MicrosoftNetCompilersToolsetPackageVersion>
6664
<!-- Packages from dotnet/runtime -->
6765
<MicrosoftExtensionsDependencyModelPackageVersion>6.0.0-alpha.1.20460.3</MicrosoftExtensionsDependencyModelPackageVersion>
6866
<MicrosoftNETCoreAppInternalPackageVersion>6.0.0-alpha.1.20460.3</MicrosoftNETCoreAppInternalPackageVersion>
@@ -144,7 +142,7 @@
144142
<MicrosoftEntityFrameworkCorePackageVersion>6.0.0-alpha.1.20460.2</MicrosoftEntityFrameworkCorePackageVersion>
145143
<MicrosoftEntityFrameworkCoreDesignPackageVersion>6.0.0-alpha.1.20460.2</MicrosoftEntityFrameworkCoreDesignPackageVersion>
146144
<!-- Packages from dotnet/arcade -->
147-
<MicrosoftDotNetBuildTasksInstallersPackageVersion>5.0.0-beta.20452.19</MicrosoftDotNetBuildTasksInstallersPackageVersion>
145+
<MicrosoftDotNetBuildTasksInstallersPackageVersion>5.0.0-beta.20453.7</MicrosoftDotNetBuildTasksInstallersPackageVersion>
148146
</PropertyGroup>
149147
<!--
150148
@@ -193,6 +191,8 @@
193191
<SystemWindowsExtensionsV0PackageVersion>$(SystemWindowsExtensionsPackageVersion.Split('.')[0]).$(SystemWindowsExtensionsPackageVersion.Split('.')[1]).0</SystemWindowsExtensionsV0PackageVersion>
194192
</PropertyGroup>
195193
<PropertyGroup Label="Manual">
194+
<!-- Packages from dotnet/roslyn -->
195+
<MicrosoftNetCompilersToolsetPackageVersion>3.8.0-3.20458.6</MicrosoftNetCompilersToolsetPackageVersion>
196196
<!-- DiagnosticAdapter package pinned temporarily until migrated/deprecated -->
197197
<MicrosoftExtensionsDiagnosticAdapterPackageVersion>5.0.0-preview.4.20180.4</MicrosoftExtensionsDiagnosticAdapterPackageVersion>
198198
<!-- Build tool dependencies -->
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. See the LICENSE file in the project root for more information. -->
1+
<!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. -->
22
<Project>
33
<Import Project="Sdk.props" Sdk="Microsoft.DotNet.Arcade.Sdk" />
44
</Project>

eng/common/post-build/publish-using-darc.ps1

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,15 @@ param(
88
[Parameter(Mandatory=$false)][string] $EnableSourceLinkValidation,
99
[Parameter(Mandatory=$false)][string] $EnableSigningValidation,
1010
[Parameter(Mandatory=$false)][string] $EnableNugetValidation,
11-
[Parameter(Mandatory=$true)][string] $PublishInstallersAndChecksums,
11+
[Parameter(Mandatory=$false)][string] $PublishInstallersAndChecksums,
1212
[Parameter(Mandatory=$false)][string] $ArtifactsPublishingAdditionalParameters,
1313
[Parameter(Mandatory=$false)][string] $SigningValidationAdditionalParameters
1414
)
1515

1616
try {
1717
. $PSScriptRoot\post-build-utils.ps1
1818
# Hard coding darc version till the next arcade-services roll out, cos this version has required API changes for darc add-build-to-channel
19-
. $PSScriptRoot\..\darc-init.ps1 -darcVersion "1.1.0-beta.20418.1"
19+
$darc = Get-Darc "1.1.0-beta.20418.1"
2020

2121
$optionalParams = [System.Collections.ArrayList]::new()
2222

@@ -29,7 +29,7 @@ try {
2929
$optionalParams.Add("--no-wait") | Out-Null
3030
}
3131

32-
if ("true" -eq $PublishInstallersAndChecksums) {
32+
if ("false" -ne $PublishInstallersAndChecksums) {
3333
$optionalParams.Add("--publish-installers-and-checksums") | Out-Null
3434
}
3535

@@ -50,12 +50,11 @@ try {
5050
}
5151
}
5252

53-
& darc add-build-to-channel `
53+
& $darc add-build-to-channel `
5454
--id $buildId `
5555
--publishing-infra-version $PublishingInfraVersion `
5656
--default-channels `
5757
--source-branch master `
58-
--publish-installers-and-checksums `
5958
--azdev-pat $AzdoToken `
6059
--bar-uri $MaestroApiEndPoint `
6160
--password $MaestroToken `

eng/common/templates/post-build/channels/generic-internal-channel.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ parameters:
44
artifactsPublishingAdditionalParameters: ''
55
dependsOn:
66
- Validate
7-
publishInstallersAndChecksums: false
7+
publishInstallersAndChecksums: true
88
symbolPublishingAdditionalParameters: ''
99
stageName: ''
1010
channelName: ''
@@ -158,7 +158,7 @@ stages:
158158
/p:BlobBasePath='$(Build.ArtifactStagingDirectory)/BlobArtifacts/'
159159
/p:PackageBasePath='$(Build.ArtifactStagingDirectory)/PackageArtifacts/'
160160
/p:Configuration=Release
161-
/p:PublishInstallersAndChecksums=true
161+
/p:PublishInstallersAndChecksums=${{ parameters.publishInstallersAndChecksums }}
162162
/p:ChecksumsTargetStaticFeed=$(InternalChecksumsBlobFeedUrl)
163163
/p:ChecksumsAzureAccountKey=$(InternalChecksumsBlobFeedKey)
164164
/p:InstallersTargetStaticFeed=$(InternalInstallersBlobFeedUrl)

eng/common/templates/post-build/channels/generic-public-channel.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ parameters:
44
artifactsPublishingAdditionalParameters: ''
55
dependsOn:
66
- Validate
7-
publishInstallersAndChecksums: false
7+
publishInstallersAndChecksums: true
88
symbolPublishingAdditionalParameters: ''
99
stageName: ''
1010
channelName: ''

eng/common/templates/post-build/post-build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ parameters:
1919
enableSigningValidation: true
2020
enableSymbolValidation: false
2121
enableNugetValidation: true
22-
publishInstallersAndChecksums: false
22+
publishInstallersAndChecksums: true
2323
SDLValidationParameters:
2424
enable: false
2525
continueOnError: false

eng/common/tools.ps1

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -718,6 +718,16 @@ function IsWindowsPlatform() {
718718
return [environment]::OSVersion.Platform -eq [PlatformID]::Win32NT
719719
}
720720

721+
function Get-Darc($version) {
722+
$darcPath = "$TempDir\darc\$(New-Guid)"
723+
if ($version -ne $null) {
724+
& $PSScriptRoot\darc-init.ps1 -toolpath $darcPath -darcVersion $version | Out-Host
725+
} else {
726+
& $PSScriptRoot\darc-init.ps1 -toolpath $darcPath | Out-Host
727+
}
728+
return "$darcPath\darc.exe"
729+
}
730+
721731
. $PSScriptRoot\pipeline-logging-functions.ps1
722732

723733
$RepoRoot = Resolve-Path (Join-Path $PSScriptRoot '..\..')

global.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
},
3131
"msbuild-sdks": {
3232
"Yarn.MSBuild": "1.15.2",
33-
"Microsoft.DotNet.Arcade.Sdk": "5.0.0-beta.20452.19",
34-
"Microsoft.DotNet.Helix.Sdk": "5.0.0-beta.20452.19"
33+
"Microsoft.DotNet.Arcade.Sdk": "5.0.0-beta.20453.7",
34+
"Microsoft.DotNet.Helix.Sdk": "5.0.0-beta.20453.7"
3535
}
3636
}

0 commit comments

Comments
 (0)