Enable trim analyzer (#41683)

Co-authored-by: James Newton-King <[email protected]>
Co-authored-by: Mackinnon Buck <[email protected]>

Author: 3 people

eng/Workarounds.props

@@ -42,10 +42,4 @@
     <ErrorOnDuplicatePublishOutputFiles>false</ErrorOnDuplicatePublishOutputFiles>
   </PropertyGroup>
 
-  <!-- Trim analyzers are automatically enabled by IsTrimming=true. They currently break when run on aspnetcore.
-       Remove when trimming analyzers are fixed: https://github.com/dotnet/aspnetcore/issues/41016 -->
-  <PropertyGroup>
-    <EnableTrimAnalyzer Condition=" '$(EnableTrimAnalyzer)' == ''">false</EnableTrimAnalyzer>
-  </PropertyGroup>
-
 </Project>

src/Components/Components/src/BindConverter.cs

@@ -1826,6 +1826,7 @@ private static class FormatterDelegateCache
             }
         }
 
+        [UnconditionalSuppressMessage("Trimming", "IL2026", Justification = "We expect unknown underlying types are configured by application code to be retained.")]
         private static BindFormatter<T> MakeTypeConverterFormatter<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)] T>()
         {
             var typeConverter = TypeDescriptor.GetConverter(typeof(T));
@@ -2028,6 +2029,7 @@ bool ConvertToArray(object? obj, CultureInfo? culture, out T[]? value)
             }
         }
 
+        [UnconditionalSuppressMessage("Trimming", "IL2026", Justification = "We expect unknown underlying types are configured by application code to be retained.")]
         private static BindParser<T> MakeTypeConverterConverter<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)] T>()
         {
             var typeConverter = TypeDescriptor.GetConverter(typeof(T));

src/Components/Components/src/CascadingParameterState.cs

@@ -6,6 +6,7 @@
 using System.Reflection;
 using Microsoft.AspNetCore.Components.Reflection;
 using Microsoft.AspNetCore.Components.Rendering;
+using static Microsoft.AspNetCore.Internal.LinkerFlags;
 
 namespace Microsoft.AspNetCore.Components;
 
@@ -75,7 +76,7 @@ public static IReadOnlyList<CascadingParameterState> FindCascadingParameters(Com
     }
 
     private static ReflectedCascadingParameterInfo[] GetReflectedCascadingParameterInfos(
-        [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties | DynamicallyAccessedMemberTypes.NonPublicProperties)] Type componentType)
+        [DynamicallyAccessedMembers(Component)] Type componentType)
     {
         if (!_cachedInfos.TryGetValue(componentType, out var infos))
         {
@@ -87,7 +88,7 @@ private static ReflectedCascadingParameterInfo[] GetReflectedCascadingParameterI
     }
 
     private static ReflectedCascadingParameterInfo[] CreateReflectedCascadingParameterInfos(
-        [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties | DynamicallyAccessedMemberTypes.NonPublicProperties)] Type componentType)
+        [DynamicallyAccessedMembers(Component)] Type componentType)
     {
         List<ReflectedCascadingParameterInfo>? result = null;
         var candidateProps = ComponentProperties.GetCandidateBindableProperties(componentType);

src/Components/Components/src/DynamicComponent.cs

@@ -59,6 +59,7 @@ public void Attach(RenderHandle renderHandle)
     }
 
     /// <inheritdoc />
+    [UnconditionalSuppressMessage("Trimming", "IL2072", Justification = "We expect that types used with DynamicComponent will be defined in assemblies that don't get trimmed.")]
     public Task SetParametersAsync(ParameterView parameters)
     {
         // This manual parameter assignment logic will be marginally faster than calling

src/Components/Components/src/LayoutAttribute.cs

@@ -1,6 +1,9 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using System.Diagnostics.CodeAnalysis;
+using static Microsoft.AspNetCore.Internal.LinkerFlags;
+
 namespace Microsoft.AspNetCore.Components;
 
 /// <summary>
@@ -13,7 +16,7 @@ public sealed class LayoutAttribute : Attribute
     /// Constructs an instance of <see cref="LayoutAttribute"/>.
     /// </summary>
     /// <param name="layoutType">The type of the layout.</param>
-    public LayoutAttribute(Type layoutType)
+    public LayoutAttribute([DynamicallyAccessedMembers(Component)] Type layoutType)
     {
         LayoutType = layoutType ?? throw new ArgumentNullException(nameof(layoutType));
 

src/Components/Components/src/LayoutView.cs

@@ -46,6 +46,7 @@ public Task SetParametersAsync(ParameterView parameters)
         return Task.CompletedTask;
     }
 
+    [UnconditionalSuppressMessage("Trimming", "IL2072", Justification = "Layout components are preserved because the LayoutAttribute constructor parameter is correctly annotated.")]
     private void Render()
     {
         // In the middle goes the supplied content

src/Components/Components/src/RouteView.cs

@@ -3,6 +3,7 @@
 
 #nullable disable warnings
 
+using System.Diagnostics.CodeAnalysis;
 using System.Reflection;
 using Microsoft.AspNetCore.Components.Rendering;
 using Microsoft.AspNetCore.Components.Routing;
@@ -72,6 +73,7 @@ public Task SetParametersAsync(ParameterView parameters)
     /// Renders the component.
     /// </summary>
     /// <param name="builder">The <see cref="RenderTreeBuilder"/>.</param>
+    [UnconditionalSuppressMessage("Trimming", "IL2111", Justification = "Layout components are preserved because the LayoutAttribute constructor parameter is correctly annotated.")]
     protected virtual void Render(RenderTreeBuilder builder)
     {
         var pageLayoutType = RouteData.PageType.GetCustomAttribute<LayoutAttribute>()?.LayoutType

src/Components/Components/src/Routing/RouteTableFactory.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.Collections.Concurrent;
+using System.Diagnostics.CodeAnalysis;
 using System.Reflection;
 using Microsoft.AspNetCore.Components.Routing;
 
@@ -30,6 +31,7 @@ public static RouteTable Create(RouteKey routeKey)
 
     public static void ClearCaches() => Cache.Clear();
 
+    [UnconditionalSuppressMessage("Trimming", "IL2026", Justification = "Application code does not get trimmed, and the framework does not define routable components.")]
     private static List<Type> GetRouteableComponents(RouteKey routeKey)
     {
         var routeableComponents = new List<Type>();

src/Components/Forms/src/EditContextDataAnnotationsExtensions.cs

@@ -83,6 +83,7 @@ public DataAnnotationsEventSubscriptions(EditContext editContext, IServiceProvid
             }
         }
 
+        [UnconditionalSuppressMessage("Trimming", "IL2026", Justification = "Model types are expected to be defined in assemblies that do not get trimmed.")]
         private void OnFieldChanged(object? sender, FieldChangedEventArgs eventArgs)
         {
             var fieldIdentifier = eventArgs.FieldIdentifier;
@@ -108,6 +109,7 @@ private void OnFieldChanged(object? sender, FieldChangedEventArgs eventArgs)
             }
         }
 
+        [UnconditionalSuppressMessage("Trimming", "IL2026", Justification = "Model types are expected to be defined in assemblies that do not get trimmed.")]
         private void OnValidationRequested(object? sender, ValidationRequestedEventArgs e)
         {
             var validationContext = new ValidationContext(_editContext.Model, _serviceProvider, items: null);
@@ -152,6 +154,7 @@ public void Dispose()
             }
         }
 
+        [UnconditionalSuppressMessage("Trimming", "IL2080", Justification = "Model types are expected to be defined in assemblies that do not get trimmed.")]
         private static bool TryGetValidatableProperty(in FieldIdentifier fieldIdentifier, [NotNullWhen(true)] out PropertyInfo? propertyInfo)
         {
             var cacheKey = (ModelType: fieldIdentifier.Model.GetType(), fieldIdentifier.FieldName);

src/Components/Shared/src/ComponentParametersTypeCache.cs

@@ -24,7 +24,7 @@ internal sealed class ComponentParametersTypeCache
         }
     }
 
-    [RequiresUnreferencedCode("This type attempts to load component parameters that may be trimmed.")]
+    [UnconditionalSuppressMessage("Trimming", "IL2026", Justification = "We expect application code is configured to preserve component parameters.")]
     private static Type? ResolveType(Key key, Assembly[] assemblies)
     {
         Assembly? assembly = null;