Use ValueStringBuilder in HttpLoggingMiddleware (#33050)

Author: Kahbazi

src/Middleware/HttpLogging/src/HttpRequestLog.cs

@@ -37,8 +37,8 @@ public override string ToString()
         {
             if (_cachedToString == null)
             {
-                // TODO use string.Create instead of a StringBuilder here.
-                var builder = new StringBuilder();
+                // Use 2kb as a rough average size for request headers
+                var builder = new ValueStringBuilder(2 * 1024);
                 var count = _keyValues.Count;
                 builder.Append("Request:");
                 builder.Append(Environment.NewLine);
@@ -48,7 +48,7 @@ public override string ToString()
                     var kvp = _keyValues[i];
                     builder.Append(kvp.Key);
                     builder.Append(": ");
-                    builder.Append(kvp.Value);
+                    builder.Append(kvp.Value?.ToString());
                     builder.Append(Environment.NewLine);
                 }
 
@@ -57,7 +57,7 @@ public override string ToString()
                     var kvp = _keyValues[count - 1];
                     builder.Append(kvp.Key);
                     builder.Append(": ");
-                    builder.Append(kvp.Value);
+                    builder.Append(kvp.Value?.ToString());
                 }
 
                 _cachedToString = builder.ToString();

src/Middleware/HttpLogging/src/HttpResponseLog.cs

@@ -37,7 +37,8 @@ public override string ToString()
         {
             if (_cachedToString == null)
             {
-                var builder = new StringBuilder();
+                // Use 2kb as a rough average size for response headers
+                var builder = new ValueStringBuilder(2 * 1024);
                 var count = _keyValues.Count;
                 builder.Append("Response:");
                 builder.Append(Environment.NewLine);
@@ -47,7 +48,7 @@ public override string ToString()
                     var kvp = _keyValues[i];
                     builder.Append(kvp.Key);
                     builder.Append(": ");
-                    builder.Append(kvp.Value);
+                    builder.Append(kvp.Value?.ToString());
                     builder.Append(Environment.NewLine);
                 }
 
@@ -56,7 +57,7 @@ public override string ToString()
                     var kvp = _keyValues[count - 1];
                     builder.Append(kvp.Key);
                     builder.Append(": ");
-                    builder.Append(kvp.Value);
+                    builder.Append(kvp.Value?.ToString());
                 }
 
                 _cachedToString = builder.ToString();

src/Middleware/HttpLogging/src/Microsoft.AspNetCore.HttpLogging.csproj

@@ -6,6 +6,7 @@
     </Description>
     <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
     <IsAspNetCoreApp>true</IsAspNetCoreApp>
+    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <IsPackable>false</IsPackable>
     <Nullable>enable</Nullable>
@@ -20,5 +21,4 @@
     <Compile Include="$(SharedSourceRoot)Buffers\**\*.cs" LinkBase="Internal\" />
     <Compile Include="$(SharedSourceRoot)ValueStringBuilder\**\*.cs" />
   </ItemGroup>
-
 </Project>