Skip to content

Commit 3a2285d

Browse files
committed
PR feedback
1 parent 486263e commit 3a2285d

28 files changed

+100
-81
lines changed

src/Servers/Connections.Abstractions/src/IMulitplexedConnectionListener.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
using System.Threading.Tasks;
88
using Microsoft.AspNetCore.Http.Features;
99

10-
namespace Microsoft.AspNetCore.Connections.Experimental
10+
namespace Microsoft.AspNetCore.Connections
1111
{
1212
/// <summary>
1313
/// Defines an interface that represents a listener bound to a specific <see cref="EndPoint"/>.

src/Servers/Connections.Abstractions/src/IMultiplexedConnectionBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
using System;
55

6-
namespace Microsoft.AspNetCore.Connections.Experimental
6+
namespace Microsoft.AspNetCore.Connections
77
{
88
/// <summary>
99
/// Defines an interface that provides the mechanisms to configure a connection pipeline.

src/Servers/Connections.Abstractions/src/IMultiplexedConnectionFactory.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
using System.Threading.Tasks;
77
using Microsoft.AspNetCore.Http.Features;
88

9-
namespace Microsoft.AspNetCore.Connections.Experimental
9+
namespace Microsoft.AspNetCore.Connections
1010
{
1111
/// <summary>
1212
/// A factory abstraction for creating connections to an endpoint.

src/Servers/Connections.Abstractions/src/IMultiplexedConnectionListenerFactory.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
using System.Threading.Tasks;
77
using Microsoft.AspNetCore.Http.Features;
88

9-
namespace Microsoft.AspNetCore.Connections.Experimental
9+
namespace Microsoft.AspNetCore.Connections
1010
{
1111
/// <summary>
1212
/// Defines an interface that provides the mechanisms for binding to various types of <see cref="EndPoint"/>s.

src/Servers/Connections.Abstractions/src/MultiplexedConnectionBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
using System.Linq;
77
using System.Threading.Tasks;
88

9-
namespace Microsoft.AspNetCore.Connections.Experimental
9+
namespace Microsoft.AspNetCore.Connections
1010
{
1111
/// <summary>
1212
/// A default implementation for <see cref="IMultiplexedConnectionBuilder"/>.

src/Servers/Connections.Abstractions/src/MultiplexedConnectionContext.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
using System.Threading.Tasks;
77
using Microsoft.AspNetCore.Http.Features;
88

9-
namespace Microsoft.AspNetCore.Connections.Experimental
9+
namespace Microsoft.AspNetCore.Connections
1010
{
1111
/// <summary>
1212
/// Encapsulates all information about a multiplexed connection.

src/Servers/Connections.Abstractions/src/MultiplexedConnectionDelegate.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
using System.Threading.Tasks;
55

6-
namespace Microsoft.AspNetCore.Connections.Experimental
6+
namespace Microsoft.AspNetCore.Connections
77
{
88
/// <summary>
99
/// A function that can process a connection.
Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,25 @@
11
#nullable enable
22
*REMOVED*Microsoft.AspNetCore.Connections.IConnectionListener.AcceptAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask<Microsoft.AspNetCore.Connections.ConnectionContext!>
33
Microsoft.AspNetCore.Connections.IConnectionListener.AcceptAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask<Microsoft.AspNetCore.Connections.ConnectionContext?>
4-
Microsoft.AspNetCore.Connections.Experimental.IMultiplexedConnectionBuilder
5-
Microsoft.AspNetCore.Connections.Experimental.IMultiplexedConnectionBuilder.ApplicationServices.get -> System.IServiceProvider!
6-
Microsoft.AspNetCore.Connections.Experimental.IMultiplexedConnectionBuilder.Build() -> Microsoft.AspNetCore.Connections.Experimental.MultiplexedConnectionDelegate!
7-
Microsoft.AspNetCore.Connections.Experimental.IMultiplexedConnectionBuilder.Use(System.Func<Microsoft.AspNetCore.Connections.Experimental.MultiplexedConnectionDelegate!, Microsoft.AspNetCore.Connections.Experimental.MultiplexedConnectionDelegate!>! middleware) -> Microsoft.AspNetCore.Connections.Experimental.IMultiplexedConnectionBuilder!
8-
Microsoft.AspNetCore.Connections.Experimental.IMultiplexedConnectionFactory
9-
Microsoft.AspNetCore.Connections.Experimental.IMultiplexedConnectionFactory.ConnectAsync(System.Net.EndPoint! endpoint, Microsoft.AspNetCore.Http.Features.IFeatureCollection? features = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask<Microsoft.AspNetCore.Connections.Experimental.MultiplexedConnectionContext!>
10-
Microsoft.AspNetCore.Connections.Experimental.IMultiplexedConnectionListener
11-
Microsoft.AspNetCore.Connections.Experimental.IMultiplexedConnectionListener.AcceptAsync(Microsoft.AspNetCore.Http.Features.IFeatureCollection? features = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask<Microsoft.AspNetCore.Connections.Experimental.MultiplexedConnectionContext?>
12-
Microsoft.AspNetCore.Connections.Experimental.IMultiplexedConnectionListener.EndPoint.get -> System.Net.EndPoint!
13-
Microsoft.AspNetCore.Connections.Experimental.IMultiplexedConnectionListener.UnbindAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask
14-
Microsoft.AspNetCore.Connections.Experimental.IMultiplexedConnectionListenerFactory
15-
Microsoft.AspNetCore.Connections.Experimental.IMultiplexedConnectionListenerFactory.BindAsync(System.Net.EndPoint! endpoint, Microsoft.AspNetCore.Http.Features.IFeatureCollection? features = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask<Microsoft.AspNetCore.Connections.Experimental.IMultiplexedConnectionListener!>
16-
Microsoft.AspNetCore.Connections.Experimental.MultiplexedConnectionBuilder
17-
Microsoft.AspNetCore.Connections.Experimental.MultiplexedConnectionBuilder.ApplicationServices.get -> System.IServiceProvider!
18-
Microsoft.AspNetCore.Connections.Experimental.MultiplexedConnectionBuilder.Build() -> Microsoft.AspNetCore.Connections.Experimental.MultiplexedConnectionDelegate!
19-
Microsoft.AspNetCore.Connections.Experimental.MultiplexedConnectionBuilder.MultiplexedConnectionBuilder(System.IServiceProvider! applicationServices) -> void
20-
Microsoft.AspNetCore.Connections.Experimental.MultiplexedConnectionBuilder.Use(System.Func<Microsoft.AspNetCore.Connections.Experimental.MultiplexedConnectionDelegate!, Microsoft.AspNetCore.Connections.Experimental.MultiplexedConnectionDelegate!>! middleware) -> Microsoft.AspNetCore.Connections.Experimental.IMultiplexedConnectionBuilder!
21-
Microsoft.AspNetCore.Connections.Experimental.MultiplexedConnectionContext
22-
Microsoft.AspNetCore.Connections.Experimental.MultiplexedConnectionContext.MultiplexedConnectionContext() -> void
23-
Microsoft.AspNetCore.Connections.Experimental.MultiplexedConnectionDelegate
24-
abstract Microsoft.AspNetCore.Connections.Experimental.MultiplexedConnectionContext.AcceptAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask<Microsoft.AspNetCore.Connections.ConnectionContext?>
25-
abstract Microsoft.AspNetCore.Connections.Experimental.MultiplexedConnectionContext.ConnectAsync(Microsoft.AspNetCore.Http.Features.IFeatureCollection? features = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask<Microsoft.AspNetCore.Connections.ConnectionContext!>
4+
Microsoft.AspNetCore.Connections.IMultiplexedConnectionBuilder
5+
Microsoft.AspNetCore.Connections.IMultiplexedConnectionBuilder.ApplicationServices.get -> System.IServiceProvider!
6+
Microsoft.AspNetCore.Connections.IMultiplexedConnectionBuilder.Build() -> Microsoft.AspNetCore.Connections.MultiplexedConnectionDelegate!
7+
Microsoft.AspNetCore.Connections.IMultiplexedConnectionBuilder.Use(System.Func<Microsoft.AspNetCore.Connections.MultiplexedConnectionDelegate!, Microsoft.AspNetCore.Connections.MultiplexedConnectionDelegate!>! middleware) -> Microsoft.AspNetCore.Connections.IMultiplexedConnectionBuilder!
8+
Microsoft.AspNetCore.Connections.IMultiplexedConnectionFactory
9+
Microsoft.AspNetCore.Connections.IMultiplexedConnectionFactory.ConnectAsync(System.Net.EndPoint! endpoint, Microsoft.AspNetCore.Http.Features.IFeatureCollection? features = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask<Microsoft.AspNetCore.Connections.MultiplexedConnectionContext!>
10+
Microsoft.AspNetCore.Connections.IMultiplexedConnectionListener
11+
Microsoft.AspNetCore.Connections.IMultiplexedConnectionListener.AcceptAsync(Microsoft.AspNetCore.Http.Features.IFeatureCollection? features = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask<Microsoft.AspNetCore.Connections.MultiplexedConnectionContext?>
12+
Microsoft.AspNetCore.Connections.IMultiplexedConnectionListener.EndPoint.get -> System.Net.EndPoint!
13+
Microsoft.AspNetCore.Connections.IMultiplexedConnectionListener.UnbindAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask
14+
Microsoft.AspNetCore.Connections.IMultiplexedConnectionListenerFactory
15+
Microsoft.AspNetCore.Connections.IMultiplexedConnectionListenerFactory.BindAsync(System.Net.EndPoint! endpoint, Microsoft.AspNetCore.Http.Features.IFeatureCollection? features = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask<Microsoft.AspNetCore.Connections.IMultiplexedConnectionListener!>
16+
Microsoft.AspNetCore.Connections.MultiplexedConnectionBuilder
17+
Microsoft.AspNetCore.Connections.MultiplexedConnectionBuilder.ApplicationServices.get -> System.IServiceProvider!
18+
Microsoft.AspNetCore.Connections.MultiplexedConnectionBuilder.Build() -> Microsoft.AspNetCore.Connections.MultiplexedConnectionDelegate!
19+
Microsoft.AspNetCore.Connections.MultiplexedConnectionBuilder.MultiplexedConnectionBuilder(System.IServiceProvider! applicationServices) -> void
20+
Microsoft.AspNetCore.Connections.MultiplexedConnectionBuilder.Use(System.Func<Microsoft.AspNetCore.Connections.MultiplexedConnectionDelegate!, Microsoft.AspNetCore.Connections.MultiplexedConnectionDelegate!>! middleware) -> Microsoft.AspNetCore.Connections.IMultiplexedConnectionBuilder!
21+
Microsoft.AspNetCore.Connections.MultiplexedConnectionContext
22+
Microsoft.AspNetCore.Connections.MultiplexedConnectionContext.MultiplexedConnectionContext() -> void
23+
Microsoft.AspNetCore.Connections.MultiplexedConnectionDelegate
24+
abstract Microsoft.AspNetCore.Connections.MultiplexedConnectionContext.AcceptAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask<Microsoft.AspNetCore.Connections.ConnectionContext?>
25+
abstract Microsoft.AspNetCore.Connections.MultiplexedConnectionContext.ConnectAsync(Microsoft.AspNetCore.Http.Features.IFeatureCollection? features = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.ValueTask<Microsoft.AspNetCore.Connections.ConnectionContext!>

src/Servers/Kestrel/Core/src/Internal/Http3/Http3Connection.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
using System.Threading;
1212
using System.Threading.Tasks;
1313
using Microsoft.AspNetCore.Connections;
14-
using Microsoft.AspNetCore.Connections.Experimental;
1514
using Microsoft.AspNetCore.Connections.Features;
1615
using Microsoft.AspNetCore.Hosting.Server;
1716
using Microsoft.AspNetCore.Http.Features;

src/Servers/Kestrel/Core/src/Internal/Http3ConnectionContext.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
using System.Buffers;
55
using System.Net;
66
using Microsoft.AspNetCore.Connections;
7-
using Microsoft.AspNetCore.Connections.Experimental;
87
using Microsoft.AspNetCore.Http.Features;
98
using Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure;
109

0 commit comments

Comments
 (0)