Scope ActivityListener in test to not interfere with other tests (#36908)

BrennanConroy · web-flow · commit 358995621687 · 2021-09-24T12:33:30.000-07:00
diff --git a/src/Hosting/Hosting/test/HostingApplicationDiagnosticsTests.cs b/src/Hosting/Hosting/test/HostingApplicationDiagnosticsTests.cs
@@ -496,11 +496,12 @@ public void ActivityOnImportHookIsCalled()
         [Fact]
         public void ActivityListenersAreCalled()
         {
-            var hostingApplication = CreateApplication(out var features);
+            var testSource = new ActivitySource(Path.GetRandomFileName());
+            var hostingApplication = CreateApplication(out var features, activitySource: testSource);
             var parentSpanId = "";
             using var listener = new ActivityListener
             {
-                ShouldListenTo = activitySource => true,
+                ShouldListenTo = activitySource => ReferenceEquals(activitySource, testSource),
                 Sample = (ref ActivityCreationOptions<ActivityContext> _) => ActivitySamplingResult.AllData,
                 ActivityStarted = activity =>
                 {

Original file line number	Diff line number	Diff line change
`@@ -496,11 +496,12 @@ public void ActivityOnImportHookIsCalled()`
`496`	`496`	`[Fact]`
`497`	`497`	`public void ActivityListenersAreCalled()`
`498`	`498`	`{`
`499`		`- var hostingApplication = CreateApplication(out var features);`
	`499`	`+ var testSource = new ActivitySource(Path.GetRandomFileName());`
	`500`	`+ var hostingApplication = CreateApplication(out var features, activitySource: testSource);`
`500`	`501`	`var parentSpanId = "";`
`501`	`502`	`using var listener = new ActivityListener`
`502`	`503`	`{`
`503`		`- ShouldListenTo = activitySource => true,`
	`504`	`+ ShouldListenTo = activitySource => ReferenceEquals(activitySource, testSource),`
`504`	`505`	`Sample = (ref ActivityCreationOptions<ActivityContext> _) => ActivitySamplingResult.AllData,`
`505`	`506`	`ActivityStarted = activity =>`
`506`	`507`	`{`